1 files changed, 11 insertions, 13 deletions

diff --git a/spec/rubocop/cop/graphql/json_type_spec.rb b/spec/rubocop/cop/graphql/json_type_spec.rb
index 6d9f86e44d2..91838c1708e 100644
--- a/spec/rubocop/cop/graphql/json_type_spec.rb
+++ b/spec/rubocop/cop/graphql/json_type_spec.rb
@@ -5,29 +5,29 @@ require 'rubocop'
 require_relative '../../../../rubocop/cop/graphql/json_type'
 
 RSpec.describe RuboCop::Cop::Graphql::JSONType do
-  include CopHelper
+  let(:msg) do
+    'Avoid using GraphQL::Types::JSON. See: https://docs.gitlab.com/ee/development/api_graphql_styleguide.html#json'
+  end
 
   subject(:cop) { described_class.new }
 
   context 'fields' do
     it 'adds an offense when GraphQL::Types::JSON is used' do
-      inspect_source(<<~RUBY.strip)
+      expect_offense(<<~RUBY)
         class MyType
           field :some_field, GraphQL::Types::JSON
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{msg}
         end
       RUBY
-
-      expect(cop.offenses.size).to eq(1)
     end
 
     it 'adds an offense when GraphQL::Types::JSON is used with other keywords' do
-      inspect_source(<<~RUBY.strip)
+      expect_offense(<<~RUBY)
         class MyType
           field :some_field, GraphQL::Types::JSON, null: true, description: 'My description'
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{msg}
         end
       RUBY
-
-      expect(cop.offenses.size).to eq(1)
     end
 
     it 'does not add an offense for other types' do
@@ -41,23 +41,21 @@ RSpec.describe RuboCop::Cop::Graphql::JSONType do
 
   context 'arguments' do
     it 'adds an offense when GraphQL::Types::JSON is used' do
-      inspect_source(<<~RUBY.strip)
+      expect_offense(<<~RUBY)
         class MyType
           argument :some_arg, GraphQL::Types::JSON
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{msg}
         end
       RUBY
-
-      expect(cop.offenses.size).to eq(1)
     end
 
     it 'adds an offense when GraphQL::Types::JSON is used with other keywords' do
-      inspect_source(<<~RUBY.strip)
+      expect_offense(<<~RUBY)
         class MyType
           argument :some_arg, GraphQL::Types::JSON, null: true, description: 'My description'
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{msg}
         end
       RUBY
-
-      expect(cop.offenses.size).to eq(1)
     end
 
     it 'does not add an offense for other types' do