1 files changed, 11 insertions, 19 deletions

diff --git a/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb b/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb
index 25350ad1ecb..2da29606024 100644
--- a/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb
+++ b/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb
@@ -5,46 +5,38 @@ require 'rubocop'
 require_relative '../../../../rubocop/cop/migration/add_concurrent_foreign_key'
 
 RSpec.describe RuboCop::Cop::Migration::AddConcurrentForeignKey do
-  include CopHelper
-
   let(:cop) { described_class.new }
 
-  context 'outside of a migration' do
+  context 'when outside of a migration' do
     it 'does not register any offenses' do
-      inspect_source('def up; add_foreign_key(:projects, :users, column: :user_id); end')
-
-      expect(cop.offenses).to be_empty
+      expect_no_offenses('def up; add_foreign_key(:projects, :users, column: :user_id); end')
     end
   end
 
-  context 'in a migration' do
+  context 'when in a migration' do
     before do
       allow(cop).to receive(:in_migration?).and_return(true)
     end
 
     it 'registers an offense when using add_foreign_key' do
-      inspect_source('def up; add_foreign_key(:projects, :users, column: :user_id); end')
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.offenses.map(&:line)).to eq([1])
-      end
+      expect_offense(<<~RUBY)
+        def up
+          add_foreign_key(:projects, :users, column: :user_id)
+          ^^^^^^^^^^^^^^^ `add_foreign_key` requires downtime, use `add_concurrent_foreign_key` instead
+        end
+      RUBY
     end
 
     it 'does not register an offense when a `NOT VALID` foreign key is added' do
-      inspect_source('def up; add_foreign_key(:projects, :users, column: :user_id, validate: false); end')
-
-      expect(cop.offenses).to be_empty
+      expect_no_offenses('def up; add_foreign_key(:projects, :users, column: :user_id, validate: false); end')
     end
 
     it 'does not register an offense when `add_foreign_key` is within `with_lock_retries`' do
-      inspect_source <<~RUBY
+      expect_no_offenses(<<~RUBY)
         with_lock_retries do
           add_foreign_key :key, :projects, column: :project_id, on_delete: :cascade
         end
       RUBY
-
-      expect(cop.offenses).to be_empty
     end
   end
 end