1 files changed, 59 insertions, 89 deletions

diff --git a/spec/rubocop/cop/migration/datetime_spec.rb b/spec/rubocop/cop/migration/datetime_spec.rb
index a3cccae21e0..24be3bea8c3 100644
--- a/spec/rubocop/cop/migration/datetime_spec.rb
+++ b/spec/rubocop/cop/migration/datetime_spec.rb
@@ -5,40 +5,8 @@ require 'rubocop'
 require_relative '../../../../rubocop/cop/migration/datetime'
 
 RSpec.describe RuboCop::Cop::Migration::Datetime do
-  include CopHelper
-
   subject(:cop) { described_class.new }
 
-  let(:create_table_migration_with_datetime) do
-    %q(
-      class Users < ActiveRecord::Migration[6.0]
-        DOWNTIME = false
-
-        def change
-          create_table :users do |t|
-            t.string :username, null: false
-            t.datetime :last_sign_in
-          end
-        end
-      end
-    )
-  end
-
-  let(:create_table_migration_with_timestamp) do
-    %q(
-      class Users < ActiveRecord::Migration[6.0]
-        DOWNTIME = false
-
-        def change
-          create_table :users do |t|
-            t.string :username, null: false
-            t.timestamp :last_sign_in
-          end
-        end
-      end
-    )
-  end
-
   let(:create_table_migration_without_datetime) do
     %q(
       class Users < ActiveRecord::Migration[6.0]
@@ -120,92 +88,94 @@ RSpec.describe RuboCop::Cop::Migration::Datetime do
     )
   end
 
-  context 'in migration' do
+  context 'when in migration' do
     before do
       allow(cop).to receive(:in_migration?).and_return(true)
     end
 
     it 'registers an offense when the ":datetime" data type is used on create_table' do
-      inspect_source(create_table_migration_with_datetime)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.offenses.map(&:line)).to eq([8])
-        expect(cop.offenses.first.message).to include('`datetime`')
-      end
+      expect_offense(<<~RUBY)
+        class Users < ActiveRecord::Migration[6.0]
+          DOWNTIME = false
+
+          def change
+            create_table :users do |t|
+              t.string :username, null: false
+              t.datetime :last_sign_in
+                ^^^^^^^^ Do not use the `datetime` data type[...]
+            end
+          end
+        end
+      RUBY
     end
 
     it 'registers an offense when the ":timestamp" data type is used on create_table' do
-      inspect_source(create_table_migration_with_timestamp)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.offenses.map(&:line)).to eq([8])
-        expect(cop.offenses.first.message).to include('timestamp')
-      end
+      expect_offense(<<~RUBY)
+        class Users < ActiveRecord::Migration[6.0]
+          DOWNTIME = false
+
+          def change
+            create_table :users do |t|
+              t.string :username, null: false
+              t.timestamp :last_sign_in
+                ^^^^^^^^^ Do not use the `timestamp` data type[...]
+            end
+          end
+        end
+      RUBY
     end
 
     it 'does not register an offense when the ":datetime" data type is not used on create_table' do
-      inspect_source(create_table_migration_without_datetime)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(0)
-      end
+      expect_no_offenses(create_table_migration_without_datetime)
     end
 
     it 'does not register an offense when the ":datetime_with_timezone" data type is used on create_table' do
-      inspect_source(create_table_migration_with_datetime_with_timezone)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(0)
-      end
+      expect_no_offenses(create_table_migration_with_datetime_with_timezone)
     end
 
     it 'registers an offense when the ":datetime" data type is used on add_column' do
-      inspect_source(add_column_migration_with_datetime)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.offenses.map(&:line)).to eq([7])
-        expect(cop.offenses.first.message).to include('`datetime`')
-      end
+      expect_offense(<<~RUBY)
+        class Users < ActiveRecord::Migration[6.0]
+          DOWNTIME = false
+
+          def change
+            add_column(:users, :username, :text)
+            add_column(:users, :last_sign_in, :datetime)
+            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use the `datetime` data type[...]
+          end
+        end
+      RUBY
     end
 
     it 'registers an offense when the ":timestamp" data type is used on add_column' do
-      inspect_source(add_column_migration_with_timestamp)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.offenses.map(&:line)).to eq([7])
-        expect(cop.offenses.first.message).to include('timestamp')
-      end
+      expect_offense(<<~RUBY)
+        class Users < ActiveRecord::Migration[6.0]
+          DOWNTIME = false
+
+          def change
+            add_column(:users, :username, :text)
+            add_column(:users, :last_sign_in, :timestamp)
+            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use the `timestamp` data type[...]
+          end
+        end
+      RUBY
     end
 
     it 'does not register an offense when the ":datetime" data type is not used on add_column' do
-      inspect_source(add_column_migration_without_datetime)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(0)
-      end
+      expect_no_offenses(add_column_migration_without_datetime)
     end
 
     it 'does not register an offense when the ":datetime_with_timezone" data type is used on add_column' do
-      inspect_source(add_column_migration_with_datetime_with_timezone)
-
-      aggregate_failures do
-        expect(cop.offenses.size).to eq(0)
-      end
+      expect_no_offenses(add_column_migration_with_datetime_with_timezone)
     end
   end
 
-  context 'outside of migration' do
-    it 'registers no offense' do
-      inspect_source(add_column_migration_with_datetime)
-      inspect_source(add_column_migration_with_timestamp)
-      inspect_source(add_column_migration_without_datetime)
-      inspect_source(add_column_migration_with_datetime_with_timezone)
-
-      expect(cop.offenses.size).to eq(0)
+  context 'when outside of migration' do
+    it 'registers no offense', :aggregate_failures do
+      expect_no_offenses(add_column_migration_with_datetime)
+      expect_no_offenses(add_column_migration_with_timestamp)
+      expect_no_offenses(add_column_migration_without_datetime)
+      expect_no_offenses(add_column_migration_with_datetime_with_timezone)
     end
   end
 end