2 files changed, 70 insertions, 27 deletions

diff --git a/spec/rubocop/cop/migration/background_migrations_spec.rb b/spec/rubocop/cop/migration/background_migrations_spec.rb
new file mode 100644
index 00000000000..3242211ab47
--- /dev/null
+++ b/spec/rubocop/cop/migration/background_migrations_spec.rb
@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'fast_spec_helper'
+require_relative '../../../../rubocop/cop/migration/background_migrations'
+
+RSpec.describe RuboCop::Cop::Migration::BackgroundMigrations do
+  let(:cop) { described_class.new }
+
+  context 'when queue_background_migration_jobs_by_range_at_intervals is used' do
+    it 'registers an offense' do
+      expect_offense(<<~RUBY)
+        def up
+          queue_background_migration_jobs_by_range_at_intervals('example', 'example', 1, batch_size: 1, track_jobs: true)
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Background migrations are deprecated. Please use a Batched Background Migration instead[...]
+        end
+      RUBY
+    end
+  end
+
+  context 'when requeue_background_migration_jobs_by_range_at_intervals is used' do
+    it 'registers an offense' do
+      expect_offense(<<~RUBY)
+        def up
+          requeue_background_migration_jobs_by_range_at_intervals('example', 1)
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Background migrations are deprecated. Please use a Batched Background Migration instead[...]
+        end
+      RUBY
+    end
+  end
+
+  context 'when migrate_in is used' do
+    it 'registers an offense' do
+      expect_offense(<<~RUBY)
+        def up
+          migrate_in(1, 'example', 1, ['example'])
+          ^^^^^^^^^^ Background migrations are deprecated. Please use a Batched Background Migration instead[...]
+        end
+      RUBY
+    end
+  end
+end
diff --git a/spec/rubocop/cop/migration/migration_record_spec.rb b/spec/rubocop/cop/migration/migration_record_spec.rb
index bab0ca469df..bfe6228c421 100644
--- a/spec/rubocop/cop/migration/migration_record_spec.rb
+++ b/spec/rubocop/cop/migration/migration_record_spec.rb
@@ -6,53 +6,55 @@ require_relative '../../../../rubocop/cop/migration/migration_record'
 RSpec.describe RuboCop::Cop::Migration::MigrationRecord do
   subject(:cop) { described_class.new }
 
-  shared_examples 'a disabled cop' do
+  shared_examples 'a disabled cop' do |klass|
     it 'does not register any offenses' do
       expect_no_offenses(<<~SOURCE)
         class MyMigration < Gitlab::Database::Migration[2.0]
-          class Project < ActiveRecord::Base
+          class Project < #{klass}
           end
         end
       SOURCE
     end
   end
 
-  context 'outside of a migration' do
-    it_behaves_like 'a disabled cop'
-  end
-
-  context 'in migration' do
-    before do
-      allow(cop).to receive(:in_migration?).and_return(true)
+  %w(ActiveRecord::Base ApplicationRecord).each do |klass|
+    context 'outside of a migration' do
+      it_behaves_like 'a disabled cop', klass
     end
 
-    context 'in an old migration' do
+    context 'in migration' do
       before do
-        allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE - 5)
+        allow(cop).to receive(:in_migration?).and_return(true)
       end
 
-      it_behaves_like 'a disabled cop'
-    end
+      context 'in an old migration' do
+        before do
+          allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE - 5)
+        end
 
-    context 'that is recent' do
-      before do
-        allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE)
+        it_behaves_like 'a disabled cop', klass
       end
 
-      it 'adds an offense if inheriting from ActiveRecord::Base' do
-        expect_offense(<<~RUBY)
-          class Project < ActiveRecord::Base
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't inherit from ActiveRecord::Base but use MigrationRecord instead.[...]
+      context 'that is recent' do
+        before do
+          allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE)
+        end
+
+        it "adds an offense if inheriting from #{klass}" do
+          expect_offense(<<~RUBY)
+          class Project < #{klass}
+          ^^^^^^^^^^^^^^^^#{'^' * klass.length} Don't inherit from ActiveRecord::Base or ApplicationRecord but use MigrationRecord instead.[...]
           end
-        RUBY
-      end
+          RUBY
+        end
 
-      it 'adds an offense if inheriting from ::ActiveRecord::Base' do
-        expect_offense(<<~RUBY)
-          class Project < ::ActiveRecord::Base
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't inherit from ActiveRecord::Base but use MigrationRecord instead.[...]
+        it "adds an offense if inheriting from ::#{klass}" do
+          expect_offense(<<~RUBY)
+          class Project < ::#{klass}
+          ^^^^^^^^^^^^^^^^^^#{'^' * klass.length} Don't inherit from ActiveRecord::Base or ApplicationRecord but use MigrationRecord instead.[...]
           end
-        RUBY
+          RUBY
+        end
       end
     end
   end