1 files changed, 54 insertions, 31 deletions

diff --git a/spec/services/groups/group_links/destroy_service_spec.rb b/spec/services/groups/group_links/destroy_service_spec.rb
index e63adc07313..6aaf5f45069 100644
--- a/spec/services/groups/group_links/destroy_service_spec.rb
+++ b/spec/services/groups/group_links/destroy_service_spec.rb
@@ -3,54 +3,77 @@
 require 'spec_helper'
 
 RSpec.describe Groups::GroupLinks::DestroyService, '#execute' do
-  let(:user) { create(:user) }
-
+  let_it_be(:user) { create(:user) }
   let_it_be(:group) { create(:group, :private) }
   let_it_be(:shared_group) { create(:group, :private) }
   let_it_be(:project) { create(:project, group: shared_group) }
   let_it_be(:owner) { create(:user) }
 
-  before do
-    group.add_developer(owner)
-    shared_group.add_owner(owner)
-  end
-
   subject { described_class.new(shared_group, owner) }
 
-  context 'single link' do
-    let!(:link) { create(:group_group_link, shared_group: shared_group, shared_with_group: group) }
+  context 'when authorizing by user' do
+    before do
+      group.add_developer(owner)
+      shared_group.add_owner(owner)
+    end
+
+    context 'single link' do
+      let!(:link) { create(:group_group_link, shared_group: shared_group, shared_with_group: group) }
 
-    it 'destroys link' do
-      expect { subject.execute(link) }.to change { shared_group.shared_with_group_links.count }.from(1).to(0)
+      it 'destroys the link' do
+        expect { subject.execute(link) }.to change { shared_group.shared_with_group_links.count }.from(1).to(0)
+      end
+
+      it 'revokes project authorization', :sidekiq_inline do
+        group.add_developer(user)
+
+        expect { subject.execute(link) }.to(
+          change { Ability.allowed?(user, :read_project, project) }.from(true).to(false))
+      end
     end
 
-    it 'revokes project authorization', :sidekiq_inline do
-      group.add_developer(user)
+    context 'multiple links' do
+      let_it_be(:another_group) { create(:group, :private) }
+      let_it_be(:another_shared_group) { create(:group, :private) }
+
+      let!(:links) do
+        [
+          create(:group_group_link, shared_group: shared_group, shared_with_group: group),
+          create(:group_group_link, shared_group: shared_group, shared_with_group: another_group),
+          create(:group_group_link, shared_group: another_shared_group, shared_with_group: group),
+          create(:group_group_link, shared_group: another_shared_group, shared_with_group: another_group)
+        ]
+      end
 
-      expect { subject.execute(link) }.to(
-        change { Ability.allowed?(user, :read_project, project) }.from(true).to(false))
+      it 'updates project authorization once per group' do
+        expect(GroupGroupLink).to receive(:delete).and_call_original
+        expect(group).to receive(:refresh_members_authorized_projects).with(direct_members_only: true, blocking: false).once
+        expect(another_group).to receive(:refresh_members_authorized_projects).with(direct_members_only: true, blocking: false).once
+
+        subject.execute(links)
+      end
     end
   end
 
-  context 'multiple links' do
-    let_it_be(:another_group) { create(:group, :private) }
-    let_it_be(:another_shared_group) { create(:group, :private) }
-
-    let!(:links) do
-      [
-        create(:group_group_link, shared_group: shared_group, shared_with_group: group),
-        create(:group_group_link, shared_group: shared_group, shared_with_group: another_group),
-        create(:group_group_link, shared_group: another_shared_group, shared_with_group: group),
-        create(:group_group_link, shared_group: another_shared_group, shared_with_group: another_group)
-      ]
+  context 'when skipping authorization' do
+    let!(:link) { create(:group_group_link, shared_group: shared_group, shared_with_group: group) }
+
+    context 'with provided group and owner' do
+      it 'destroys the link' do
+        expect do
+          subject.execute(link, skip_authorization: true)
+        end.to change { shared_group.shared_with_group_links.count }.from(1).to(0)
+      end
     end
 
-    it 'updates project authorization once per group' do
-      expect(GroupGroupLink).to receive(:delete).and_call_original
-      expect(group).to receive(:refresh_members_authorized_projects).with(direct_members_only: true, blocking: false).once
-      expect(another_group).to receive(:refresh_members_authorized_projects).with(direct_members_only: true, blocking: false).once
+    context 'without providing group or owner' do
+      subject { described_class.new(nil, nil) }
 
-      subject.execute(links)
+      it 'destroys the link' do
+        expect do
+          subject.execute(link, skip_authorization: true)
+        end.to change { shared_group.shared_with_group_links.count }.from(1).to(0)
+      end
     end
   end
 end