diff options
Diffstat (limited to 'spec/services/groups')
-rw-r--r-- | spec/services/groups/create_service_spec.rb | 57 | ||||
-rw-r--r-- | spec/services/groups/update_statistics_service_spec.rb | 55 |
2 files changed, 112 insertions, 0 deletions
diff --git a/spec/services/groups/create_service_spec.rb b/spec/services/groups/create_service_spec.rb index 81cab973b30..7ec523a1f2b 100644 --- a/spec/services/groups/create_service_spec.rb +++ b/spec/services/groups/create_service_spec.rb @@ -8,6 +8,10 @@ RSpec.describe Groups::CreateService, '#execute' do subject { service.execute } + shared_examples 'has sync-ed traversal_ids' do + specify { expect(subject.reload.traversal_ids).to eq([subject.parent&.traversal_ids, subject.id].flatten.compact) } + end + describe 'visibility level restrictions' do let!(:service) { described_class.new(user, group_params) } @@ -77,6 +81,18 @@ RSpec.describe Groups::CreateService, '#execute' do it 'adds an onboarding progress record' do expect { subject }.to change(OnboardingProgress, :count).from(0).to(1) end + + context 'with before_commit callback' do + it_behaves_like 'has sync-ed traversal_ids' + end + + context 'with after_create callback' do + before do + stub_feature_flags(sync_traversal_ids_before_commit: false) + end + + it_behaves_like 'has sync-ed traversal_ids' + end end context 'when user can not create a group' do @@ -102,6 +118,18 @@ RSpec.describe Groups::CreateService, '#execute' do it 'does not add an onboarding progress record' do expect { subject }.not_to change(OnboardingProgress, :count).from(0) end + + context 'with before_commit callback' do + it_behaves_like 'has sync-ed traversal_ids' + end + + context 'with after_create callback' do + before do + stub_feature_flags(sync_traversal_ids_before_commit: false) + end + + it_behaves_like 'has sync-ed traversal_ids' + end end context 'as guest' do @@ -289,4 +317,33 @@ RSpec.describe Groups::CreateService, '#execute' do end end end + + describe 'logged_out_marketing_header experiment', :experiment do + let(:service) { described_class.new(user, group_params) } + + subject { service.execute } + + before do + stub_experiments(logged_out_marketing_header: :candidate) + end + + it 'tracks signed_up event' do + expect(experiment(:logged_out_marketing_header)).to track( + :namespace_created, + namespace: an_instance_of(Group) + ).on_next_instance.with_context(actor: user) + + subject + end + + context 'when group has not been persisted' do + let(:service) { described_class.new(user, group_params.merge(name: '<script>alert("Attack!")</script>')) } + + it 'does not track signed_up event' do + expect(experiment(:logged_out_marketing_header)).not_to track(:namespace_created) + + subject + end + end + end end diff --git a/spec/services/groups/update_statistics_service_spec.rb b/spec/services/groups/update_statistics_service_spec.rb new file mode 100644 index 00000000000..5bef51c2727 --- /dev/null +++ b/spec/services/groups/update_statistics_service_spec.rb @@ -0,0 +1,55 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Groups::UpdateStatisticsService do + let_it_be(:group, reload: true) { create(:group) } + + let(:statistics) { %w(wiki_size) } + + subject(:service) { described_class.new(group, statistics: statistics)} + + describe '#execute', :aggregate_failures do + context 'when group is nil' do + let(:group) { nil } + + it 'does nothing' do + expect(NamespaceStatistics).not_to receive(:new) + + result = service.execute + + expect(result).to be_error + end + end + + context 'with an existing group' do + context 'when namespace statistics exists for the group' do + it 'uses the existing statistics and refreshes them' do + namespace_statistics = create(:namespace_statistics, namespace: group) + + expect(namespace_statistics).to receive(:refresh!).with(only: statistics.map(&:to_sym)).and_call_original + + result = service.execute + + expect(result).to be_success + end + end + + context 'when namespace statistics does not exist for the group' do + it 'creates the statistics and refreshes them' do + expect_next_instance_of(NamespaceStatistics) do |instance| + expect(instance).to receive(:refresh!).with(only: statistics.map(&:to_sym)).and_call_original + end + + result = nil + + expect do + result = service.execute + end.to change { NamespaceStatistics.count }.by(1) + + expect(result).to be_success + end + end + end + end +end |