Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/services/incident_management/timeline_events/update_service_spec.rb')
-rw-r--r--spec/services/incident_management/timeline_events/update_service_spec.rb21
1 files changed, 11 insertions, 10 deletions
diff --git a/spec/services/incident_management/timeline_events/update_service_spec.rb b/spec/services/incident_management/timeline_events/update_service_spec.rb
index 728f2fa3e9d..f612c72e2a8 100644
--- a/spec/services/incident_management/timeline_events/update_service_spec.rb
+++ b/spec/services/incident_management/timeline_events/update_service_spec.rb
@@ -32,6 +32,10 @@ RSpec.describe IncidentManagement::TimelineEvents::UpdateService do
expect(execute.message).to eq(message)
end
+ it 'does not update the note' do
+ expect { execute }.not_to change { timeline_event.reload.note }
+ end
+
it_behaves_like 'does not track incident management event', :incident_management_timeline_event_edited
end
@@ -94,16 +98,7 @@ RSpec.describe IncidentManagement::TimelineEvents::UpdateService do
context 'when note is blank' do
let(:params) { { note: '', occurred_at: occurred_at } }
- it_behaves_like 'successful response'
- it_behaves_like 'passing the correct was_changed value', :occurred_at
-
- it 'does not update the note' do
- expect { execute }.not_to change { timeline_event.reload.note }
- end
-
- it 'updates occurred_at' do
- expect { execute }.to change { timeline_event.occurred_at }.to(params[:occurred_at])
- end
+ it_behaves_like 'error response', "Note can't be blank"
end
context 'when occurred_at is nil' do
@@ -121,6 +116,12 @@ RSpec.describe IncidentManagement::TimelineEvents::UpdateService do
end
end
+ context 'when occurred_at is blank' do
+ let(:params) { { note: 'Updated note', occurred_at: '' } }
+
+ it_behaves_like 'error response', "Occurred at can't be blank"
+ end
+
context 'when both occurred_at and note is nil' do
let(:params) { {} }