diff options
Diffstat (limited to 'spec/services/packages')
4 files changed, 153 insertions, 2 deletions
diff --git a/spec/services/packages/cleanup/update_policy_service_spec.rb b/spec/services/packages/cleanup/update_policy_service_spec.rb new file mode 100644 index 00000000000..a11fbb766f5 --- /dev/null +++ b/spec/services/packages/cleanup/update_policy_service_spec.rb @@ -0,0 +1,105 @@ +# frozen_string_literal: true +require 'spec_helper' + +RSpec.describe Packages::Cleanup::UpdatePolicyService do + using RSpec::Parameterized::TableSyntax + + let_it_be_with_reload(:project) { create(:project) } + let_it_be(:current_user) { create(:user) } + + let(:params) { { keep_n_duplicated_package_files: 50 } } + + describe '#execute' do + subject { described_class.new(project: project, current_user: current_user, params: params).execute } + + shared_examples 'creating the policy' do + it 'creates a new one' do + expect { subject }.to change { ::Packages::Cleanup::Policy.count }.from(0).to(1) + + expect(subject.payload[:packages_cleanup_policy]).to be_present + expect(subject.success?).to be_truthy + expect(project.packages_cleanup_policy).to be_persisted + expect(project.packages_cleanup_policy.keep_n_duplicated_package_files).to eq('50') + end + + context 'with invalid parameters' do + let(:params) { { keep_n_duplicated_package_files: 100 } } + + it 'does not create one' do + expect { subject }.not_to change { ::Packages::Cleanup::Policy.count } + + expect(subject.status).to eq(:error) + expect(subject.message).to eq('Keep n duplicated package files is invalid') + end + end + end + + shared_examples 'updating the policy' do + it 'updates the existing one' do + expect { subject }.not_to change { ::Packages::Cleanup::Policy.count } + + expect(subject.payload[:packages_cleanup_policy]).to be_present + expect(subject.success?).to be_truthy + expect(project.packages_cleanup_policy.keep_n_duplicated_package_files).to eq('50') + end + + context 'with invalid parameters' do + let(:params) { { keep_n_duplicated_package_files: 100 } } + + it 'does not update one' do + expect { subject }.not_to change { policy.keep_n_duplicated_package_files } + + expect(subject.status).to eq(:error) + expect(subject.message).to eq('Keep n duplicated package files is invalid') + end + end + end + + shared_examples 'denying access' do + it 'returns an error' do + subject + + expect(subject.message).to eq('Access denied') + expect(subject.status).to eq(:error) + end + end + + context 'with existing container expiration policy' do + let_it_be(:policy) { create(:packages_cleanup_policy, project: project) } + + where(:user_role, :shared_examples_name) do + :maintainer | 'updating the policy' + :developer | 'denying access' + :reporter | 'denying access' + :guest | 'denying access' + :anonymous | 'denying access' + end + + with_them do + before do + project.send("add_#{user_role}", current_user) unless user_role == :anonymous + end + + it_behaves_like params[:shared_examples_name] + end + end + + context 'without existing container expiration policy' do + where(:user_role, :shared_examples_name) do + :maintainer | 'creating the policy' + :developer | 'denying access' + :reporter | 'denying access' + :guest | 'denying access' + :anonymous | 'denying access' + end + + with_them do + before do + project.send("add_#{user_role}", current_user) unless user_role == :anonymous + end + + it_behaves_like params[:shared_examples_name] + end + end + end +end diff --git a/spec/services/packages/go/create_package_service_spec.rb b/spec/services/packages/go/create_package_service_spec.rb index 5c5fec0aa3a..4ca1119fbaa 100644 --- a/spec/services/packages/go/create_package_service_spec.rb +++ b/spec/services/packages/go/create_package_service_spec.rb @@ -35,6 +35,22 @@ RSpec.describe Packages::Go::CreatePackageService do expect(file.file_sha1).not_to be_nil expect(file.file_sha256).not_to be_nil end + + context 'with FIPS mode', :fips_mode do + it 'does not generate file_md5' do + file_name = "#{version.name}.#{type}" + expect(subject.package_files.map { |f| f.file_name }).to include(file_name) + + file = subject.package_files.with_file_name(file_name).first + expect(file).not_to be_nil + expect(file.file).not_to be_nil + expect(file.size).to eq(file.file.size) + expect(file.file_name).to eq(file_name) + expect(file.file_md5).to be_nil + expect(file.file_sha1).not_to be_nil + expect(file.file_sha256).not_to be_nil + end + end end describe '#execute' do diff --git a/spec/services/packages/maven/metadata/append_package_file_service_spec.rb b/spec/services/packages/maven/metadata/append_package_file_service_spec.rb index c406ab93630..f3a90d31158 100644 --- a/spec/services/packages/maven/metadata/append_package_file_service_spec.rb +++ b/spec/services/packages/maven/metadata/append_package_file_service_spec.rb @@ -22,6 +22,18 @@ RSpec.describe ::Packages::Maven::Metadata::AppendPackageFileService do expect_file("#{metadata_file_name}.sha256") expect_file("#{metadata_file_name}.sha512") end + + context 'with FIPS mode', :fips_mode do + it 'does not generate file_md5' do + expect { subject }.to change { package.package_files.count }.by(4) + expect(subject).to be_success + + expect_file(metadata_file_name, with_content: content, with_content_type: 'application/xml', fips: true) + expect_file("#{metadata_file_name}.sha1", fips: true) + expect_file("#{metadata_file_name}.sha256", fips: true) + expect_file("#{metadata_file_name}.sha512", fips: true) + end + end end context 'with nil content' do @@ -36,17 +48,22 @@ RSpec.describe ::Packages::Maven::Metadata::AppendPackageFileService do it_behaves_like 'returning an error service response', message: 'package is not set' end - def expect_file(file_name, with_content: nil, with_content_type: '') + def expect_file(file_name, fips: false, with_content: nil, with_content_type: '') package_file = package.package_files.recent.with_file_name(file_name).first expect(package_file.file).to be_present expect(package_file.file_name).to eq(file_name) expect(package_file.size).to be > 0 - expect(package_file.file_md5).to be_present expect(package_file.file_sha1).to be_present expect(package_file.file_sha256).to be_present expect(package_file.file.content_type).to eq(with_content_type) + if fips + expect(package_file.file_md5).not_to be_present + else + expect(package_file.file_md5).to be_present + end + if with_content expect(package_file.file.read).to eq(with_content) end diff --git a/spec/services/packages/rubygems/create_gemspec_service_spec.rb b/spec/services/packages/rubygems/create_gemspec_service_spec.rb index 198e978a47e..839fb4d955a 100644 --- a/spec/services/packages/rubygems/create_gemspec_service_spec.rb +++ b/spec/services/packages/rubygems/create_gemspec_service_spec.rb @@ -24,5 +24,18 @@ RSpec.describe Packages::Rubygems::CreateGemspecService do expect(gemspec_file.file_sha1).not_to be_nil expect(gemspec_file.file_sha256).not_to be_nil end + + context 'with FIPS mode', :fips_mode do + it 'does not generate file_md5' do + expect { subject }.to change { package.package_files.count }.by(1) + + gemspec_file = package.package_files.find_by(file_name: "#{gemspec.name}.gemspec") + expect(gemspec_file.file).not_to be_nil + expect(gemspec_file.size).not_to be_nil + expect(gemspec_file.file_md5).to be_nil + expect(gemspec_file.file_sha1).not_to be_nil + expect(gemspec_file.file_sha256).not_to be_nil + end + end end end |