diff options
Diffstat (limited to 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb')
-rw-r--r-- | spec/services/projects/hashed_storage/rollback_repository_service_spec.rb | 152 |
1 files changed, 0 insertions, 152 deletions
diff --git a/spec/services/projects/hashed_storage/rollback_repository_service_spec.rb b/spec/services/projects/hashed_storage/rollback_repository_service_spec.rb deleted file mode 100644 index 1e5d4ae4d20..00000000000 --- a/spec/services/projects/hashed_storage/rollback_repository_service_spec.rb +++ /dev/null @@ -1,152 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -RSpec.describe Projects::HashedStorage::RollbackRepositoryService, :clean_gitlab_redis_shared_state, feature_category: :groups_and_projects do - let(:gitlab_shell) { Gitlab::Shell.new } - let(:project) { create(:project, :repository, :wiki_repo, :design_repo, storage_version: ::Project::HASHED_STORAGE_FEATURES[:repository]) } - let(:legacy_storage) { Storage::LegacyProject.new(project) } - let(:hashed_storage) { Storage::Hashed.new(project) } - - subject(:service) { described_class.new(project: project, old_disk_path: project.disk_path) } - - describe '#execute' do - let(:old_disk_path) { hashed_storage.disk_path } - let(:new_disk_path) { legacy_storage.disk_path } - - before do - allow(service).to receive(:gitlab_shell) { gitlab_shell } - end - - context 'repository lock' do - it 'tries to lock the repository' do - expect(service).to receive(:try_to_set_repository_read_only!) - - service.execute - end - - it 'fails when a git operation is in progress' do - allow(project).to receive(:git_transfer_in_progress?) { true } - - expect { service.execute }.to raise_error(Projects::HashedStorage::RepositoryInUseError) - end - end - - context 'when repository doesnt exist on disk' do - let(:project) { create(:project) } - - it 'skips the disk change but decrease the version' do - service.execute - - expect(project.legacy_storage?).to be_truthy - end - end - - context 'when succeeds' do - it 'renames project, wiki and design repositories' do - service.execute - - expect(gitlab_shell.repository_exists?(project.repository_storage, "#{new_disk_path}.git")).to be_truthy - expect(gitlab_shell.repository_exists?(project.repository_storage, "#{new_disk_path}.wiki.git")).to be_truthy - expect(gitlab_shell.repository_exists?(project.repository_storage, "#{new_disk_path}.design.git")).to be_truthy - end - - it 'updates project to be legacy and not read-only' do - service.execute - - expect(project.legacy_storage?).to be_truthy - expect(project.repository_read_only).to be_falsey - end - - it 'move operation is called for both repositories' do - expect_move_repository(old_disk_path, new_disk_path) - expect_move_repository("#{old_disk_path}.wiki", "#{new_disk_path}.wiki") - expect_move_repository("#{old_disk_path}.design", "#{new_disk_path}.design") - - service.execute - end - - it 'writes project full path to gitaly' do - service.execute - - expect(project.repository.full_path).to eq project.full_path - end - end - - context 'when exception happens' do - it 'handles OpenSSL::Cipher::CipherError' do - expect(project).to receive(:ensure_runners_token).and_raise(OpenSSL::Cipher::CipherError) - - expect { service.execute }.not_to raise_exception - end - - it 'ensures rollback when OpenSSL::Cipher::CipherError' do - expect(project).to receive(:ensure_runners_token).and_raise(OpenSSL::Cipher::CipherError) - expect(service).to receive(:rollback_folder_move).and_call_original - - service.execute - project.reload - - expect(project.hashed_storage?(:repository)).to be_truthy - expect(project.repository_read_only?).to be_falsey - end - - it 'handles Gitlab::Git::CommandError' do - expect(project).to receive(:set_full_path).and_raise(Gitlab::Git::CommandError) - - expect { service.execute }.not_to raise_exception - end - - it 'ensures rollback when Gitlab::Git::CommandError' do - expect(project).to receive(:set_full_path).and_raise(Gitlab::Git::CommandError) - expect(service).to receive(:rollback_folder_move).and_call_original - - service.execute - project.reload - - expect(project.hashed_storage?(:repository)).to be_truthy - expect(project.repository_read_only?).to be_falsey - end - end - - context 'when one move fails' do - it 'rolls repositories back to original name' do - allow(service).to receive(:move_repository).and_call_original - allow(service).to receive(:move_repository).with(old_disk_path, new_disk_path).once { false } # will disable first move only - - expect(service).to receive(:rollback_folder_move).and_call_original - - service.execute - - expect(gitlab_shell.repository_exists?(project.repository_storage, "#{new_disk_path}.git")).to be_falsey - expect(gitlab_shell.repository_exists?(project.repository_storage, "#{new_disk_path}.wiki.git")).to be_falsey - expect(gitlab_shell.repository_exists?(project.repository_storage, "#{new_disk_path}.design.git")).to be_falsey - expect(project.repository_read_only?).to be_falsey - end - - context 'when rollback fails' do - before do - gitlab_shell.mv_repository(project.repository_storage, old_disk_path, new_disk_path) - end - - it 'does not try to move nil repository over existing' do - expect(gitlab_shell).not_to receive(:mv_repository).with(project.repository_storage, old_disk_path, new_disk_path) - expect_move_repository("#{old_disk_path}.wiki", "#{new_disk_path}.wiki") - expect_move_repository("#{old_disk_path}.design", "#{new_disk_path}.design") - - service.execute - end - end - end - - it 'works even when project validation fails' do - allow(project).to receive(:valid?) { false } - - expect { service.execute }.to change { project.legacy_storage? }.to(true) - end - - def expect_move_repository(from_name, to_name) - expect(gitlab_shell).to receive(:mv_repository).with(project.repository_storage, from_name, to_name).and_call_original - end - end -end |