Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/services/projects/update_pages_service_spec.rb')
-rw-r--r--spec/services/projects/update_pages_service_spec.rb28
1 files changed, 27 insertions, 1 deletions
diff --git a/spec/services/projects/update_pages_service_spec.rb b/spec/services/projects/update_pages_service_spec.rb
index 714256d9b08..52ec80c252b 100644
--- a/spec/services/projects/update_pages_service_spec.rb
+++ b/spec/services/projects/update_pages_service_spec.rb
@@ -5,7 +5,7 @@ require "spec_helper"
describe Projects::UpdatePagesService do
let_it_be(:project, refind: true) { create(:project, :repository) }
let_it_be(:pipeline) { create(:ci_pipeline, project: project, sha: project.commit('HEAD').sha) }
- let_it_be(:build) { create(:ci_build, pipeline: pipeline, ref: 'HEAD') }
+ let(:build) { create(:ci_build, pipeline: pipeline, ref: 'HEAD') }
let(:invalid_file) { fixture_file_upload('spec/fixtures/dk.png') }
let(:file) { fixture_file_upload("spec/fixtures/pages.zip") }
@@ -204,6 +204,32 @@ describe Projects::UpdatePagesService do
end
end
+ context 'when file size is spoofed' do
+ let(:metadata) { spy('metadata') }
+
+ include_context 'pages zip with spoofed size'
+
+ before do
+ file = fixture_file_upload(fake_zip_path, 'pages.zip')
+ metafile = fixture_file_upload('spec/fixtures/pages.zip.meta')
+
+ create(:ci_job_artifact, :archive, file: file, job: build)
+ create(:ci_job_artifact, :metadata, file: metafile, job: build)
+
+ allow(build).to receive(:artifacts_metadata_entry)
+ .and_return(metadata)
+ allow(metadata).to receive(:total_size).and_return(100)
+ end
+
+ it 'raises an error' do
+ expect do
+ subject.execute
+ end.to raise_error(Projects::UpdatePagesService::FailedToExtractError,
+ 'Entry public/index.html should be 1B but is larger when inflated')
+ expect(deploy_status).to be_script_failure
+ end
+ end
+
def deploy_status
GenericCommitStatus.find_by(name: 'pages:deploy')
end