Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/services/protected_branches/destroy_service_spec.rb')
-rw-r--r--spec/services/protected_branches/destroy_service_spec.rb27
1 files changed, 19 insertions, 8 deletions
diff --git a/spec/services/protected_branches/destroy_service_spec.rb b/spec/services/protected_branches/destroy_service_spec.rb
index 4e55c72f312..9fa07820148 100644
--- a/spec/services/protected_branches/destroy_service_spec.rb
+++ b/spec/services/protected_branches/destroy_service_spec.rb
@@ -3,30 +3,41 @@
require 'spec_helper'
RSpec.describe ProtectedBranches::DestroyService do
- let(:protected_branch) { create(:protected_branch) }
- let(:project) { protected_branch.project }
+ let_it_be_with_reload(:project) { create(:project) }
+
+ let(:protected_branch) { create(:protected_branch, project: project) }
let(:user) { project.first_owner }
- describe '#execute' do
- subject(:service) { described_class.new(project, user) }
+ subject(:service) { described_class.new(project, user) }
+ describe '#execute' do
it 'destroys a protected branch' do
service.execute(protected_branch)
expect(protected_branch).to be_destroyed
end
- context 'when a policy restricts rule deletion' do
- before do
- policy = instance_double(ProtectedBranchPolicy, allowed?: false)
- expect(ProtectedBranchPolicy).to receive(:new).and_return(policy)
+ it 'refreshes the cache' do
+ expect_next_instance_of(ProtectedBranches::CacheService) do |cache_service|
+ expect(cache_service).to receive(:refresh)
end
+ service.execute(protected_branch)
+ end
+
+ context 'when a policy restricts rule deletion' do
it "prevents deletion of the protected branch rule" do
+ disallow(:destroy_protected_branch, protected_branch)
+
expect do
service.execute(protected_branch)
end.to raise_error(Gitlab::Access::AccessDeniedError)
end
end
end
+
+ def disallow(ability, protected_branch)
+ allow(Ability).to receive(:allowed?).and_call_original
+ allow(Ability).to receive(:allowed?).with(user, ability, protected_branch).and_return(false)
+ end
end