diff options
Diffstat (limited to 'spec/services/users')
3 files changed, 87 insertions, 28 deletions
diff --git a/spec/services/users/refresh_authorized_projects_service_spec.rb b/spec/services/users/refresh_authorized_projects_service_spec.rb index a31902c7f16..e6ccb2b16e7 100644 --- a/spec/services/users/refresh_authorized_projects_service_spec.rb +++ b/spec/services/users/refresh_authorized_projects_service_spec.rb @@ -52,7 +52,7 @@ RSpec.describe Users::RefreshAuthorizedProjectsService do it 'is called' do ProjectAuthorization.delete_all - expect(callback).to receive(:call).with(project.id, Gitlab::Access::MAINTAINER).once + expect(callback).to receive(:call).with(project.id, Gitlab::Access::OWNER).once service.execute end @@ -73,7 +73,7 @@ RSpec.describe Users::RefreshAuthorizedProjectsService do to_be_removed = [project_authorization.project_id] to_be_added = [ - { user_id: user.id, project_id: project.id, access_level: Gitlab::Access::MAINTAINER } + { user_id: user.id, project_id: project.id, access_level: Gitlab::Access::OWNER } ] expect(service).to receive(:update_authorizations) @@ -82,31 +82,6 @@ RSpec.describe Users::RefreshAuthorizedProjectsService do service.execute_without_lease end - it 'removes duplicate entries' do - [Gitlab::Access::MAINTAINER, Gitlab::Access::REPORTER].each do |access_level| - user.project_authorizations.create!(project: project, access_level: access_level) - end - - to_be_removed = [project.id] - - to_be_added = [ - { user_id: user.id, project_id: project.id, access_level: Gitlab::Access::MAINTAINER } - ] - expect(service).to( - receive(:update_authorizations) - .with(to_be_removed, to_be_added) - .and_call_original) - - service.execute_without_lease - - expect(user.project_authorizations.count).to eq(1) - project_authorization = ProjectAuthorization.where( - project_id: project.id, - user_id: user.id, - access_level: Gitlab::Access::MAINTAINER) - expect(project_authorization).to exist - end - it 'sets the access level of a project to the highest available level' do user.project_authorizations.delete_all @@ -116,7 +91,7 @@ RSpec.describe Users::RefreshAuthorizedProjectsService do to_be_removed = [project_authorization.project_id] to_be_added = [ - { user_id: user.id, project_id: project.id, access_level: Gitlab::Access::MAINTAINER } + { user_id: user.id, project_id: project.id, access_level: Gitlab::Access::OWNER } ] expect(service).to receive(:update_authorizations) diff --git a/spec/services/users/saved_replies/create_service_spec.rb b/spec/services/users/saved_replies/create_service_spec.rb new file mode 100644 index 00000000000..e01b6248308 --- /dev/null +++ b/spec/services/users/saved_replies/create_service_spec.rb @@ -0,0 +1,44 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Users::SavedReplies::CreateService do + describe '#execute' do + let_it_be(:current_user) { create(:user) } + let_it_be(:saved_reply) { create(:saved_reply, user: current_user) } + + subject { described_class.new(current_user: current_user, name: name, content: content).execute } + + context 'when create fails' do + let(:name) { saved_reply.name } + let(:content) { '' } + + it { is_expected.not_to be_success } + + it 'does not create new Saved Reply in database' do + expect { subject }.not_to change(::Users::SavedReply, :count) + end + + it 'returns error messages' do + expect(subject.errors).to match_array(["Content can't be blank", "Name has already been taken"]) + end + end + + context 'when create succeeds' do + let(:name) { 'new_saved_reply_name' } + let(:content) { 'New content for Saved Reply' } + + it { is_expected.to be_success } + + it 'creates new Saved Reply in database' do + expect { subject }.to change(::Users::SavedReply, :count).by(1) + end + + it 'returns new saved reply', :aggregate_failures do + expect(subject[:saved_reply]).to eq(::Users::SavedReply.last) + expect(subject[:saved_reply].name).to eq(name) + expect(subject[:saved_reply].content).to eq(content) + end + end + end +end diff --git a/spec/services/users/saved_replies/update_service_spec.rb b/spec/services/users/saved_replies/update_service_spec.rb new file mode 100644 index 00000000000..b67d09977c6 --- /dev/null +++ b/spec/services/users/saved_replies/update_service_spec.rb @@ -0,0 +1,40 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Users::SavedReplies::UpdateService do + describe '#execute' do + let_it_be(:current_user) { create(:user) } + let_it_be(:saved_reply) { create(:saved_reply, user: current_user) } + let_it_be(:other_saved_reply) { create(:saved_reply, user: current_user) } + let_it_be(:saved_reply_from_other_user) { create(:saved_reply) } + + subject { described_class.new(current_user: current_user, saved_reply: saved_reply, name: name, content: content).execute } + + context 'when update fails' do + let(:name) { other_saved_reply.name } + let(:content) { '' } + + it { is_expected.not_to be_success } + + it 'returns error messages' do + expect(subject.errors).to match_array(["Content can't be blank", "Name has already been taken"]) + end + end + + context 'when update succeeds' do + let(:name) { saved_reply_from_other_user.name } + let(:content) { 'New content for Saved Reply' } + + it { is_expected.to be_success } + + it 'updates new Saved Reply in database' do + expect { subject }.not_to change(::Users::SavedReply, :count) + end + + it 'returns saved reply' do + expect(subject[:saved_reply]).to eq(saved_reply) + end + end + end +end |