diff options
Diffstat (limited to 'spec/tasks/gitlab/backup_rake_spec.rb')
| -rw-r--r-- | spec/tasks/gitlab/backup_rake_spec.rb | 78 |
1 files changed, 38 insertions, 40 deletions
diff --git a/spec/tasks/gitlab/backup_rake_spec.rb b/spec/tasks/gitlab/backup_rake_spec.rb index 8963164ac53..e5a210bb344 100644 --- a/spec/tasks/gitlab/backup_rake_spec.rb +++ b/spec/tasks/gitlab/backup_rake_spec.rb @@ -1,7 +1,6 @@ # frozen_string_literal: true -require 'spec_helper' -require 'rake' +require 'rake_helper' RSpec.describe 'gitlab:app namespace rake task', :delete do let(:enable_registry) { true } @@ -24,14 +23,10 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do before(:all) do Rake.application.rake_require 'active_record/railties/databases' - Rake.application.rake_require 'tasks/gitlab/helpers' Rake.application.rake_require 'tasks/gitlab/backup' Rake.application.rake_require 'tasks/gitlab/shell' Rake.application.rake_require 'tasks/gitlab/db' Rake.application.rake_require 'tasks/cache' - - # empty task as env is already loaded - Rake::Task.define_task :environment end before do @@ -39,6 +34,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do FileUtils.rm(tars_glob, force: true) FileUtils.rm(backup_files, force: true) FileUtils.rm_rf(backup_directories, secure: true) + FileUtils.mkdir_p('tmp/tests/public/uploads') reenable_backup_sub_tasks stub_container_registry_config(enabled: enable_registry) end @@ -47,12 +43,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do FileUtils.rm(tars_glob, force: true) FileUtils.rm(backup_files, force: true) FileUtils.rm_rf(backup_directories, secure: true) - end - - def run_rake_task(task_name) - FileUtils.mkdir_p('tmp/tests/public/uploads') - Rake::Task[task_name].reenable - Rake.application.invoke_task task_name + FileUtils.rm_rf('tmp/tests/public/uploads', secure: true) end def reenable_backup_sub_tasks @@ -92,11 +83,11 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'invokes restoration on match' do - expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout_from_any_process end it 'prints timestamps on messages' do - expect { run_rake_task('gitlab:backup:restore') }.to output(/.*\d{4}-\d{2}-\d{2}\s\d{2}:\d{2}:\d{2}\s[-+]\d{4}\s--\s.*/).to_stdout + expect { run_rake_task('gitlab:backup:restore') }.to output(/.*\d{4}-\d{2}-\d{2}\s\d{2}:\d{2}:\d{2}\s[-+]\d{4}\s--\s.*/).to_stdout_from_any_process end end end @@ -105,14 +96,16 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do before do # We only need a backup of the repositories for this test stub_env('SKIP', 'db,uploads,builds,artifacts,lfs,registry') + + create(:project, :repository) end it 'removes stale data' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process excluded_project = create(:project, :repository, name: 'mepmep') - expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout_from_any_process raw_repo = excluded_project.repository.raw @@ -124,9 +117,10 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do context 'when the backup is restored' do let!(:included_project) { create(:project, :repository) } + let!(:original_checksum) { included_project.repository.checksum } before do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process backup_tar = Dir.glob(File.join(Gitlab.config.backup.path, '*_gitlab_backup.tar')).last allow(Dir).to receive(:glob).and_return([backup_tar]) @@ -153,11 +147,12 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'restores the data' do - expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout_from_any_process raw_repo = included_project.repository.raw expect(raw_repo.empty?).to be(false) + expect(included_project.repository.checksum).to eq(original_checksum) end end end @@ -169,8 +164,9 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do allow(ActiveRecord::Base.connection).to receive(:reconnect!) end + let!(:project) { create(:project, :repository) } + describe 'backup creation and deletion using custom_hooks' do - let(:project) { create(:project, :repository) } let(:user_backup_path) { "repositories/#{project.disk_path}" } before do @@ -184,7 +180,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do context 'project uses custom_hooks and successfully creates backup' do it 'creates custom_hooks.tar and project bundle' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process tar_contents, exit_status = Gitlab::Popen.popen(%W{tar -tvf #{backup_tar}}) @@ -195,8 +191,8 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'restores files correctly' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout - expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process + expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout_from_any_process repo_path = Gitlab::GitalyClient::StorageSettings.allow_disk_access do project.repository.path @@ -210,7 +206,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do it 'prints a progress message to stdout' do task_list.each do |task| - expect { run_rake_task("gitlab:backup:#{task}:create") }.to output(/Dumping /).to_stdout + expect { run_rake_task("gitlab:backup:#{task}:create") }.to output(/Dumping /).to_stdout_from_any_process end end end @@ -219,7 +215,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do context 'tar creation' do context 'archive file permissions' do it 'sets correct permissions on the tar file' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process expect(File.exist?(backup_tar)).to be_truthy expect(File::Stat.new(backup_tar).mode.to_s(8)).to eq('100600') @@ -231,7 +227,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'uses the custom permissions' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process expect(File::Stat.new(backup_tar).mode.to_s(8)).to eq('100651') end @@ -239,7 +235,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'sets correct permissions on the tar contents' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process tar_contents, exit_status = Gitlab::Popen.popen( %W{tar -tvf #{backup_tar} db uploads.tar.gz repositories builds.tar.gz artifacts.tar.gz pages.tar.gz lfs.tar.gz registry.tar.gz} @@ -258,7 +254,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'deletes temp directories' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process temp_dirs = Dir.glob( File.join(Gitlab.config.backup.path, '{db,repositories,uploads,builds,artifacts,pages,lfs,registry}') @@ -271,7 +267,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do let(:enable_registry) { false } it 'does not create registry.tar.gz' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process tar_contents, exit_status = Gitlab::Popen.popen( %W{tar -tvf #{backup_tar}} @@ -301,10 +297,8 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do shared_examples 'includes repositories in all repository storages' do specify :aggregate_failures do project_a = create(:project, :repository) - project_a.track_project_repository project_snippet_a = create(:project_snippet, :repository, project: project_a, author: project_a.owner) project_b = create(:project, :repository, repository_storage: second_storage_name) - project_b.track_project_repository project_snippet_b = create(:project_snippet, :repository, project: project_b, author: project_b.owner) project_snippet_b.snippet_repository.update!(shard: project_b.project_repository.shard) create(:wiki_page, container: project_a) @@ -313,7 +307,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do move_repository_to_secondary(project_b) move_repository_to_secondary(project_snippet_b) - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process tar_contents, exit_status = Gitlab::Popen.popen( %W{tar -tvf #{backup_tar} repositories} @@ -379,7 +373,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do .and_call_original end - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process end it 'passes through concurrency environment variables' do @@ -392,7 +386,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do .and_call_original end - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process end end end @@ -401,10 +395,12 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do describe "Skipping items" do before do stub_env('SKIP', 'repositories,uploads') + + create(:project, :repository) end it "does not contain skipped item" do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process tar_contents, _exit_status = Gitlab::Popen.popen( %W{tar -tvf #{backup_tar} db uploads.tar.gz repositories builds.tar.gz artifacts.tar.gz pages.tar.gz lfs.tar.gz registry.tar.gz} @@ -421,7 +417,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'does not invoke repositories restore' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process allow(Rake::Task['gitlab:shell:setup']) .to receive(:invoke).and_return(true) @@ -436,17 +432,19 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do expect(Rake::Task['gitlab:backup:lfs:restore']).to receive :invoke expect(Rake::Task['gitlab:backup:registry:restore']).to receive :invoke expect(Rake::Task['gitlab:shell:setup']).to receive :invoke - expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:restore') }.to output.to_stdout_from_any_process end end describe 'skipping tar archive creation' do before do stub_env('SKIP', 'tar') + + create(:project, :repository) end it 'created files with backup content and no tar archive' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process dir_contents = Dir.children(Gitlab.config.backup.path) @@ -465,7 +463,7 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do end it 'those component files can be restored from' do - expect { run_rake_task("gitlab:backup:create") }.to output.to_stdout + expect { run_rake_task("gitlab:backup:create") }.to output.to_stdout_from_any_process allow(Rake::Task['gitlab:shell:setup']) .to receive(:invoke).and_return(true) @@ -480,13 +478,13 @@ RSpec.describe 'gitlab:app namespace rake task', :delete do expect(Rake::Task['gitlab:backup:lfs:restore']).to receive :invoke expect(Rake::Task['gitlab:backup:registry:restore']).to receive :invoke expect(Rake::Task['gitlab:shell:setup']).to receive :invoke - expect { run_rake_task("gitlab:backup:restore") }.to output.to_stdout + expect { run_rake_task("gitlab:backup:restore") }.to output.to_stdout_from_any_process end end describe "Human Readable Backup Name" do it 'name has human readable time' do - expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout + expect { run_rake_task('gitlab:backup:create') }.to output.to_stdout_from_any_process expect(backup_tar).to match(/\d+_\d{4}_\d{2}_\d{2}_\d+\.\d+\.\d+.*_gitlab_backup.tar$/) end |