diff options
Diffstat (limited to 'spec/tasks/gitlab/db')
-rw-r--r-- | spec/tasks/gitlab/db/truncate_legacy_tables_rake_spec.rb | 157 | ||||
-rw-r--r-- | spec/tasks/gitlab/db/validate_config_rake_spec.rb | 2 |
2 files changed, 158 insertions, 1 deletions
diff --git a/spec/tasks/gitlab/db/truncate_legacy_tables_rake_spec.rb b/spec/tasks/gitlab/db/truncate_legacy_tables_rake_spec.rb new file mode 100644 index 00000000000..f9ebb985255 --- /dev/null +++ b/spec/tasks/gitlab/db/truncate_legacy_tables_rake_spec.rb @@ -0,0 +1,157 @@ +# frozen_string_literal: true + +require 'rake_helper' + +RSpec.describe 'gitlab:db:truncate_legacy_tables', :silence_stdout, :reestablished_active_record_base, + :suppress_gitlab_schemas_validate_connection do + let(:main_connection) { ApplicationRecord.connection } + let(:ci_connection) { Ci::ApplicationRecord.connection } + let(:test_gitlab_main_table) { '_test_gitlab_main_table' } + let(:test_gitlab_ci_table) { '_test_gitlab_ci_table' } + + before :all do + Rake.application.rake_require 'active_record/railties/databases' + Rake.application.rake_require 'tasks/seed_fu' + Rake.application.rake_require 'tasks/gitlab/db/validate_config' + Rake.application.rake_require 'tasks/gitlab/db/truncate_legacy_tables' + + # empty task as env is already loaded + Rake::Task.define_task :environment + end + + before do + skip_if_multiple_databases_not_setup + + # Filling the table on both databases main and ci + Gitlab::Database.database_base_models.each_value do |base_model| + base_model.connection.execute(<<~SQL) + CREATE TABLE #{test_gitlab_main_table} (id integer NOT NULL); + INSERT INTO #{test_gitlab_main_table} VALUES(generate_series(1, 50)); + SQL + base_model.connection.execute(<<~SQL) + CREATE TABLE #{test_gitlab_ci_table} (id integer NOT NULL); + INSERT INTO #{test_gitlab_ci_table} VALUES(generate_series(1, 50)); + SQL + end + + allow(Gitlab::Database::GitlabSchema).to receive(:tables_to_schema).and_return( + { + test_gitlab_main_table => :gitlab_main, + test_gitlab_ci_table => :gitlab_ci + } + ) + end + + shared_examples 'truncating legacy tables' do + before do + allow(ENV).to receive(:[]).and_return(nil) + end + + context 'when tables are not locked for writes' do + it 'raises an error when trying to truncate the tables' do + error_message = /is not locked for writes. Run the rake task gitlab:db:lock_writes first/ + expect { truncate_legacy_tables }.to raise_error(error_message) + end + end + + context 'when tables are locked for writes' do + before do + # Locking ci table on the main database + Gitlab::Database::LockWritesManager.new( + table_name: test_gitlab_ci_table, + connection: main_connection, + database_name: "main" + ).lock_writes + + # Locking main table on the ci database + Gitlab::Database::LockWritesManager.new( + table_name: test_gitlab_main_table, + connection: ci_connection, + database_name: "ci" + ).lock_writes + end + + it 'calls TablesTruncate with the correct parameters and default minimum batch size' do + expect(Gitlab::Database::TablesTruncate).to receive(:new).with( + database_name: database_name, + min_batch_size: 5, + logger: anything, + dry_run: false, + until_table: nil + ).and_call_original + + truncate_legacy_tables + end + + it 'truncates the legacy table' do + expect do + truncate_legacy_tables + end.to change { connection.select_value("SELECT count(*) from #{legacy_table}") }.from(50).to(0) + end + + it 'does not truncate the table that belongs to the connection schema' do + expect do + truncate_legacy_tables + end.not_to change { connection.select_value("SELECT count(*) from #{active_table}") } + end + + context 'when running in dry_run mode' do + before do + allow(ENV).to receive(:[]).with("DRY_RUN").and_return("true") + end + + it 'does not truncate any tables' do + expect do + truncate_legacy_tables + end.not_to change { connection.select_value("SELECT count(*) from #{legacy_table}") } + end + + it 'prints the truncation sql statement to the output' do + expect do + truncate_legacy_tables + end.to output(/TRUNCATE TABLE #{legacy_table} RESTRICT/).to_stdout + end + end + + context 'when passing until_table parameter via environment variable' do + before do + allow(ENV).to receive(:[]).with("UNTIL_TABLE").and_return(legacy_table) + end + + it 'sends the table name to TablesTruncate' do + expect(Gitlab::Database::TablesTruncate).to receive(:new).with( + database_name: database_name, + min_batch_size: 5, + logger: anything, + dry_run: false, + until_table: legacy_table + ).and_call_original + + truncate_legacy_tables + end + end + end + end + + context 'when truncating ci tables on the main database' do + subject(:truncate_legacy_tables) { run_rake_task('gitlab:db:truncate_legacy_tables:main') } + + let(:connection) { ApplicationRecord.connection } + let(:database_name) { 'main' } + let(:active_table) { test_gitlab_main_table } + let(:legacy_table) { test_gitlab_ci_table } + + it_behaves_like 'truncating legacy tables' + end + + context 'when truncating main tables on the ci database' do + subject(:truncate_legacy_tables) { run_rake_task('gitlab:db:truncate_legacy_tables:ci') } + + let(:connection) { Ci::ApplicationRecord.connection } + let(:database_name) { 'ci' } + let(:active_table) { test_gitlab_ci_table } + let(:legacy_table) { test_gitlab_main_table } + + it_behaves_like 'truncating legacy tables' + end +end diff --git a/spec/tasks/gitlab/db/validate_config_rake_spec.rb b/spec/tasks/gitlab/db/validate_config_rake_spec.rb index ad15c7f0d1c..1d47c94aa77 100644 --- a/spec/tasks/gitlab/db/validate_config_rake_spec.rb +++ b/spec/tasks/gitlab/db/validate_config_rake_spec.rb @@ -216,7 +216,7 @@ RSpec.describe 'gitlab:db:validate_config', :silence_stdout, :suppress_gitlab_sc let(:exception) { ActiveRecord::StatementInvalid.new("READONLY") } before do - allow(exception).to receive(:cause).and_return(PG::ReadOnlySqlTransaction.new("cannot execute INSERT in a read-only transaction")) + allow(exception).to receive(:cause).and_return(PG::ReadOnlySqlTransaction.new("cannot execute UPSERT in a read-only transaction")) allow(ActiveRecord::InternalMetadata).to receive(:upsert).at_least(:once).and_raise(exception) end |