1 files changed, 11 insertions, 21 deletions
diff --git a/spec/views/admin/application_settings/_repository_storage.html.haml_spec.rb b/spec/views/admin/application_settings/_repository_storage.html.haml_spec.rb
index dc8f259eb56..244157a3b14 100644
--- a/spec/views/admin/application_settings/_repository_storage.html.haml_spec.rb
+++ b/spec/views/admin/application_settings/_repository_storage.html.haml_spec.rb
@@ -10,42 +10,32 @@ RSpec.describe 'admin/application_settings/_repository_storage.html.haml' do
     assign(:application_setting, app_settings)
   end
 
-  context 'additional storage config' do
+  context 'with storage weights configured' do
     let(:repository_storages_weighted) do
       {
         'default' => 100,
-        'mepmep' => 50
+        'mepmep' => 50,
+        'something_old' => 100
       }
     end
 
-    it 'lists them all' do
+    it 'lists storages with weight', :aggregate_failures do
       render
 
-      Gitlab.config.repositories.storages.keys.each do |storage_name|
-        expect(rendered).to have_content(storage_name)
-      end
-
-      expect(rendered).to have_content('foobar')
+      expect(rendered).to have_field('default', with: 100)
+      expect(rendered).to have_field('mepmep', with: 50)
     end
-  end
 
-  context 'fewer storage configs' do
-    let(:repository_storages_weighted) do
-      {
-        'default' => 100,
-        'mepmep' => 50,
-        'something_old' => 100
-      }
+    it 'lists storages without weight' do
+      render
+
+      expect(rendered).to have_field('foobar', with: 0)
     end
 
     it 'lists only configured storages' do
       render
 
-      Gitlab.config.repositories.storages.keys.each do |storage_name|
-        expect(rendered).to have_content(storage_name)
-      end
-
-      expect(rendered).not_to have_content('something_old')
+      expect(rendered).not_to have_field('something_old')
     end
   end
 end