1 files changed, 118 insertions, 0 deletions
diff --git a/spec/workers/packages/cleanup/delete_orphaned_dependencies_worker_spec.rb b/spec/workers/packages/cleanup/delete_orphaned_dependencies_worker_spec.rb
new file mode 100644
index 00000000000..ffa7767075e
--- /dev/null
+++ b/spec/workers/packages/cleanup/delete_orphaned_dependencies_worker_spec.rb
@@ -0,0 +1,118 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Packages::Cleanup::DeleteOrphanedDependenciesWorker, feature_category: :package_registry do
+  let(:worker) { described_class.new }
+
+  it { is_expected.to include_module(CronjobQueue) }
+  it { expect(described_class.idempotent?).to be_truthy }
+
+  describe '#perform', :clean_gitlab_redis_shared_state do
+    let_it_be(:orphaned_dependencies) { create_list(:packages_dependency, 2) }
+    let_it_be(:linked_dependency) do
+      create(:packages_dependency).tap do |dependency|
+        create(:packages_dependency_link, dependency: dependency)
+      end
+    end
+
+    subject { worker.perform }
+
+    it 'deletes only orphaned dependencies' do
+      expect { subject }.to change { Packages::Dependency.count }.by(-2)
+      expect(Packages::Dependency.all).to contain_exactly(linked_dependency)
+    end
+
+    it 'executes 3 queries' do
+      queries = ActiveRecord::QueryRecorder.new { subject }
+
+      # 1. (each_batch lower bound) SELECT packages_dependencies.id FROM packages_dependencies
+      #                               WHERE packages_dependencies.id >= 0
+      #                               ORDER BY packages_dependencies.id ASC LIMIT 1;
+      # 2. (each_batch upper bound) SELECT packages_dependencies.id FROM packages_dependencies
+      #                               WHERE packages_dependencies.id >= 0
+      #                               AND packages_dependencies.id >= 1 ORDER BY packages_dependencies.id ASC
+      #                               LIMIT 1 OFFSET 100;
+      # 3. (delete query) DELETE FROM packages_dependencies WHERE packages_dependencies.id >= 0
+      #                     AND packages_dependencies.id >= 1
+      #                     AND (NOT EXISTS (
+      #                       SELECT 1 FROM packages_dependency_links
+      #                         WHERE packages_dependency_links.dependency_id = packages_dependencies.id
+      #                     ));
+      expect(queries.count).to eq(3)
+    end
+
+    context 'when the worker is running for more than the max time' do
+      before do
+        allow(worker).to receive(:over_time?).and_return(true)
+      end
+
+      it 'sets the last processed dependency id in redis cache' do
+        subject
+
+        Gitlab::Redis::SharedState.with do |redis|
+          expect(redis.get('last_processed_packages_dependency_id').to_i).to eq(Packages::Dependency.last.id)
+        end
+      end
+    end
+
+    context 'when the worker reaches the maximum number of batches' do
+      before do
+        stub_const('Packages::Cleanup::DeleteOrphanedDependenciesWorker::MAX_BATCHES', 1)
+      end
+
+      it 'iterates over only 1 batch' do
+        expect { subject }.to change { Packages::Dependency.count }.by(-2)
+      end
+
+      it 'sets the last processed dependency id in redis cache' do
+        subject
+
+        Gitlab::Redis::SharedState.with do |redis|
+          expect(redis.get('last_processed_packages_dependency_id').to_i).to eq(Packages::Dependency.last.id)
+        end
+      end
+    end
+
+    context 'when the worker finishes processing in less than the max time' do
+      before do
+        Gitlab::Redis::SharedState.with do |redis|
+          redis.set('last_processed_packages_dependency_id', orphaned_dependencies.first.id)
+        end
+      end
+
+      it 'clears the last processed last_processed_packages_dependency_id from redis cache' do
+        Gitlab::Redis::SharedState.with do |redis|
+          expect { subject }
+            .to change { redis.get('last_processed_packages_dependency_id') }.to(nil)
+        end
+      end
+    end
+
+    context 'when logging extra metadata' do
+      before do
+        stub_const('Packages::Cleanup::DeleteOrphanedDependenciesWorker::MAX_BATCHES', 1)
+      end
+
+      it 'logs the last proccessed id & the deleted rows count', :aggregate_failures do
+        expect(worker).to receive(:log_extra_metadata_on_done).with(
+          :last_processed_packages_dependency_id,
+          Packages::Dependency.last.id
+        )
+        expect(worker).to receive(:log_extra_metadata_on_done).with(:deleted_rows_count, 2)
+
+        subject
+      end
+    end
+
+    context 'when the FF is disabled' do
+      before do
+        stub_feature_flags(packages_delete_orphaned_dependencies_worker: false)
+      end
+
+      it 'does not execute the worker' do
+        expect { subject }.not_to change { Packages::Dependency.count }
+      end
+    end
+  end
+end