Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-02-23 | Prefer leading style for Style/DotPosition | Douwe Maan | |
2017-02-23 | Enable Style/ConditionalAssignment | Douwe Maan | |
2017-02-23 | Enable Style/ColonMethodCall | Douwe Maan | |
2017-02-23 | Disable Style/BracesAroundHashParameters | Douwe Maan | |
2017-02-23 | Enable Style/BarePercentLiterals | Douwe Maan | |
2017-02-23 | Enable Security/JSONLoad | Douwe Maan | |
2017-02-23 | Enable Rails/Validation | Douwe Maan | |
2017-02-23 | Disable Rails/OutputSafety | Douwe Maan | |
2017-02-23 | Disable Rails/DynamicFindBy | Douwe Maan | |
2017-02-23 | Enable Performance/RedundantMatch | Douwe Maan | |
2017-02-23 | Enable Performance/RedundantBlockCall | Douwe Maan | |
2017-02-23 | Disable Lint/UnneededSplatExpansion | Douwe Maan | |
2017-02-23 | Enable Lint/UnifiedInteger | Douwe Maan | |
2017-02-23 | Enable Performance/RedundantMerge | Douwe Maan | |
2017-02-23 | Disable some more cops | Douwe Maan | |
2017-02-23 | Disable a few RSpec cops | Douwe Maan | |
2017-02-23 | Custom cops don’t need to be mentioned in .rubocop.yml | Douwe Maan | |
2017-02-23 | Disable Lint/UnusedMethodArgument | Douwe Maan | |
2017-02-23 | Disable Style/TrailingCommaInLiteral | Douwe Maan | |
2017-02-23 | Enable Style/SpaceInsideBrackets | Douwe Maan | |
2017-02-23 | Enable Style/MutableConstant | Douwe Maan | |
2017-02-23 | Enable Style/DotPosition | Douwe Maan | |
2017-02-22 | No more and/or | Douwe Maan | |
2017-02-13 | Merge branch 'rs-rubocop-rspec' into 'master' | Rémy Coutable | |
Enable Style/RedundantException, Lint/EmptyWhen, and RSpec/ExpectActual cops See merge request !9151 | |||
2017-02-13 | Enable `Lint/EmptyWhen` cop and correct offense | Robert Speicher | |
2017-02-13 | Merge branch 'zj-drop-ruby-21-tests' into 'master' | Rémy Coutable | |
Update Rubocop to Ruby 2.3 See merge request !8994 | |||
2017-02-11 | Enable `Style/RedundantException` cop and correct offense | Robert Speicher | |
2017-02-11 | Enable the `RSpec/ExpectActual` cop and correct offenses | Robert Speicher | |
2017-02-11 | Explicitly disable the RSpec/BeEql cop | Robert Speicher | |
This is a little too picky, even for us. | |||
2017-02-09 | Add a spec for our custom GemFetcher cop | Robert Speicher | |
2017-02-07 | Update Rubocop to ruby 2.3 | Z.J. van de Weg | |
2017-02-02 | ignore node_modules in rubocop | Mike Greiling | |
2017-01-11 | Fix Rubocop YAML config files to avoid CE->EE issues | Grzegorz Bizon | |
2016-12-16 | Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741 | Rydkin Maxim | |
2016-10-20 | Change target Ruby version for Rubocop to 2.1. | Adam Niedzielski | |
We have to use the lowest common denominator to check the supported syntax and in our case it is Ruby 2.1. Please note that it will not help with unsupported syntax in HAML files because they are not checked by Rubocop. | |||
2016-10-04 | Update RuboCop to 0.43.0 and update configuration | Robert Speicher | |
`Style/VariableNumber` is explicitly disabled because I don't think we care if we name a variable `var_1` or `var1`. | |||
2016-10-03 | Enable Lint/StringConversionInInterpolation cop and autocorrect offenses | Robert Speicher | |
2016-09-21 | Revert "Merge branch 'rs-update-rubocop-rspec' into 'master'" | Robert Speicher | |
This reverts commit 70faf5fdfbfa0e427b12d4181a9302394974c3cf, reversing changes made to 2307eb84dcd1748cc231719017551111310d1bf9. | |||
2016-09-15 | Update `.rubocop.yml` for rubocop-rspec 1.7.0 | Robert Speicher | |
2016-09-01 | Rubocop syntax 2.3 | Z.J. van de Weg | |
2016-08-09 | Merge branch 'rubocop/enable-more-cops-for-empty-lines' into 'master' | Robert Speicher | |
Enable some Rubocop cops related to new lines ## What does this MR do? This MR enabled two additional Rubocop cops: Keeps track of empty lines around block bodies. `Style/EmptyLinesAroundBlockBody` Keeps track of empty lines around method bodies. ` Style/EmptyLinesAroundMethodBody` See merge request !5637 | |||
2016-08-08 | Merge branch 'rubocop/EmptyLinesAroundModuleBody' into 'master' | Douwe Maan | |
Enable Style/EmptyLinesAround Module/Class Body cop ## What does this MR do? Enable a new rubocop cops as discussed here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1877/diffs#note_13021078 ## Are there points in the code the reviewer needs to double check? May be a good idea to send a message to people to prevent `master` red because of the new cop. ## Why was this MR needed? We want to improve code style and not waste endbosses time checking style manually ## What are the relevant issue numbers? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5692 | |||
2016-08-06 | Enable Style/SpaceAroundEqualsInParameterDefault cop | Gabriel Mazetto | |
2016-08-06 | Enable Style/EmptyLinesAroundClassBody cop | Gabriel Mazetto | |
2016-08-06 | Enable Style/EmptyLinesAroundModuleBody cop | Gabriel Mazetto | |
2016-08-03 | Enable some Rubocop cops related to new lines | Grzegorz Bizon | |
2016-07-29 | Merge branch 'rubocop/enable-access-modifiers-cops' into 'master' | Robert Speicher | |
Enable Rubocop cops that check access modifiers ## What does this MR do? This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly. This also fixes existing offenses. ## Why was this MR needed? Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis. ## What are the relevant issue numbers? See #17478 Closes #17372 See merge request !5014 | |||
2016-07-20 | Enable Style/MultilineTernaryOperator rubocop cop | Grzegorz Bizon | |
Avoid multi-line ?: (the ternary operator). Use if/unless instead. See #17478 | |||
2016-07-19 | Enable Rubocop cops for invalid access modifiers | Grzegorz Bizon | |
This enables following cops: Check for useless access modifiers Lint/UselessAccessModifier Checks for attempts to use `private` or `protected` to set the visibility of a class method, which does not work. Lint/IneffectiveAccessModifier This also disables two false possitives in concerns. | |||
2016-07-13 | Disable two cops as recommended. | Connor Shea | |