Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-07-20Enable Style/MultilineTernaryOperator rubocop copGrzegorz Bizon
Avoid multi-line ?: (the ternary operator). Use if/unless instead. See #17478
2016-07-13Disable two cops as recommended.Connor Shea
2016-07-13Remove some disabled cops.Connor Shea
2016-07-13Update rubocop to 0.41.2Z.J. van de Weg
https://github.com/bbatsov/rubocop/blob/v0.41.2/CHANGELOG.md
2016-07-08Enable Style/IdenticalConditionalBranches Rubocop copGrzegorz Bizon
2016-07-01Enable Style/EmptyLines cop, remove redundant onesGrzegorz Bizon
2016-06-30Enable Style/UnneededCapitalW Rubocop copGrzegorz Bizon
2016-06-29Merge branch 'rubocop/enable-space-after-cops' into 'master' Robert Speicher
Enable Style/SpaceAfterComma and Colon Rubocop cops See #17478 See merge request !4991
2016-06-29Enable Style/SpaceAfterComma Rubocop copGrzegorz Bizon
2016-06-29Enable Style/SpaceAfterColon Rubocop copsGrzegorz Bizon
2016-06-29Added RuboCop cops for checking DB migrationsYorick Peterse
There are currently two cops for this: * Migration/AddIndex: checks if indexes are added concurrently * Migration/ColumnWithDefault: checks if columns with default values are added in a concurrent manner Both cops are fairly simple and make no attempt at correcting the code as this is quite hard to do (e.g. modifications may need to be applied in various places in the same file). They however should provide enough to catch people ignoring the comments in generated migrations telling them to use add_concurrent_index or add_column_with_default.
2016-06-13Merge branch 'style/enable-multiline-block-chain-rubocop-cop' into 'master' Robert Speicher
Enable Style/MultilineBlockChain rubocop style cop Avoid multi-line chains of blocks. See #17478. See merge request !4349
2016-06-10Enable Style/MultilineBlockChain rubocop style copGrzegorz Bizon
See #17478
2016-06-09Enable RuboCop for migrationsSean McGivern
Migrations shouldn't fail RuboCop checks - especially lint checks, such as the nested method check. To avoid changing code in existing migrations, add the magic comment to the top of each of them to skip that file.
2016-06-08Merge branch 'rubocop/disable-uniq-before-pluck-cop' into 'master' Robert Speicher
Disable Rails/UniqBeforePluck rubocop cop Rails/UniqBeforePluck seems to have some bugs * https://github.com/bbatsov/rubocop/issues/3122 * https://github.com/bbatsov/rubocop/issues/3148 and we had some problems in EE with that https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/425#note_12245005 See merge request !4477
2016-06-05Merge branch 'rubocop/enable-ambiguous-operator-rubocop-lint' into 'master' Robert Speicher
Enable Lint/AmbiguousOperator rubocop cop Enforce using parentheses if ambiguous operators are detected, like `header *some_method` or `array.select &:even?`. See #17478 See merge request !4454
2016-06-04Disable Rails/UniqBeforePluck rubocop copGrzegorz Bizon
2016-06-03Enable Lint/AmbiguousOperator rubocop copGrzegorz Bizon
See #17478
2016-06-03Enable Style/EmptyLinesAroundAccessModifier rubocop copGrzegorz Bizon
See #17478
2016-06-01Merge branch 'style/enable-semicolon-rubocop-cop' into 'master' Robert Speicher
Enable Style/Semicolon rubocop style cop Don't use semicolons to terminate expressions. See #17478. See merge request !4351
2016-06-01Merge branch 'rubocop/enable-style-for-cop' into 'master' Robert Speicher
Enable Style/For rubocop cop > Do not use `for`, unless you know exactly why. Most of the time iterators should be used instead. `for` is implemented in terms of `each` (so you're adding a level of indirection), but with a twist - `for` doesn't introduce a new scope (unlike `each`) and variables defined in its block will be visible outside it. See #17478 See merge request !4397
2016-06-01Enable Style/For rubocop copGrzegorz Bizon
Do not use for, unless you know exactly why. See #17478
2016-06-01Merge branch 'issue_15557' into 'master' Rémy Coutable
Fix error 500 when sorting issues by milestone due date and filtering by labels fixes #15557 See merge request !4327
2016-06-01Enable Style/Semicolon rubocop style copGrzegorz Bizon
See #17478
2016-06-01Add leading comment space copFelipe Artur
2016-05-30Merge branch 'rubocop/enable-space-before-comma-cop' into 'master' Robert Speicher
Enable Style/SpaceBeforeComma rubocop cop No spaces before commas. See #17478 See merge request !4360
2016-05-30Merge branch 'rubocop/enable-performance-times-map-cop' into 'master' Robert Speicher
Enable Performance/TimesMap Rubocop cop Use Array.new with a block instead of `.times.collect` / `.times.map`. See #17478 See merge request !4357
2016-05-30Merge branch 'rubocop/enable-negatedif-style-cop' into 'master' Robert Speicher
Enable Style/NegatedIf Rubocop cop Favor `unless` over `if` for negative conditions (or control flow ||). ```ruby # bad do_something if !some_condition # bad do_something if not some_condition # good do_something unless some_condition # good some_condition || do_something ``` See #17478 See merge request !4355
2016-05-30Merge branch 'rubocop/enable-literal-in-condition-cop' into 'master' Robert Speicher
Enable Lint/LiteralInCondition rubocop cop Detects literals used in conditions. See #17478 See merge request !4354
2016-05-30Merge branch 'style/enable-multiline-if-then-rubocop-cop' into 'master' Robert Speicher
Enable Style/MultilineIfThen rubocop cop Do not use then for multi-line if. See #7478. See merge request !4353
2016-05-30Merge branch 'style/enable-method-def-parentheses-rubocop-cop' into 'master' Robert Speicher
Enable Style/MethodDefParentheses rubocop cop Use def with parentheses when there are parameters. See #17478 See merge request !4352
2016-05-30Merge branch 'style/enable-rubocop-indent-assignment-cop' into 'master' Robert Speicher
Enable Style/IndentAssignment Rubocop style cop Checks the indentation of the first line of the right-hand-side of a multi-line assignment. See #17478 See merge request !4348
2016-05-30Merge branch 'style/enable-while-until-do-rubocop-style-cop' into 'master' Robert Speicher
Enable Style/WhileUntilDo rubocop style cop Checks for redundant `do` after `while` or `until`. See #17478 See merge request !4350
2016-05-30Merge branch 'style/enable-rubocop-end-of-line-cop' into 'master' Robert Speicher
Enable Style/EndOfLine Rubocop style cop Use Unix-style line endings. Removed carriage return character from end of each line in `app/controllers/projects/find_file_controller.rb` See #17478 See merge request !4347
2016-05-30Merge branch 'style/enable-block-alignment-rubocop-lint' into 'master' Robert Speicher
Enable Lint/BlockAlignment Rubocop cop See #17478 See merge request !4346
2016-05-30Merge branch 'rubocop/enable-redundant-parentheses-cop' into 'master' Robert Speicher
Enable Style/RedundantParentheses rubocop cop Checks for parentheses that seem not to serve any purpose. See #17478 See merge request !4361
2016-05-30Merge branch 'rubocop/enable-space-before-comment-cop' into 'master' Robert Speicher
Enable Style/SpaceBeforeComment rubocop cop See #17478 See merge request !4358
2016-05-30Enable Style/RedundantParentheses rubocop copGrzegorz Bizon
See #17478
2016-05-30Enable Style/SpaceBeforeComma rubocop copGrzegorz Bizon
No spaces before commas. See #17478
2016-05-30Enable Style/SpaceAfterMethodName rubocop copGrzegorz Bizon
See #17478
2016-05-30Enable Style/SpaceBeforeComment rubocop copGrzegorz Bizon
See #17478
2016-05-30Enable Performance/TimesMap Rubocop copGrzegorz Bizon
Use Array.new with a block instead of `.times.collect` / `.times.map`. See #17478
2016-05-30Enable Style/NegatedIf Rubocop copGrzegorz Bizon
Favor `unless` over `if` for negative conditions (or control flow ||). See #17478
2016-05-30Enable Lint/LiteralInCondition rubocop copGrzegorz Bizon
Checks of literals used in conditions. See #17478
2016-05-30Enable Style/MultilineIfThen rubocop copGrzegorz Bizon
Do not use then for multi-line if. See #7478.
2016-05-30Enable Style/MethodDefParentheses rubocop copGrzegorz Bizon
Use def with parentheses when there are parameters. See #17478
2016-05-30Enable Style/WhileUntilDo rubocop style copGrzegorz Bizon
See #17478
2016-05-30Enable Style/IndentAssignment Rubocop style copGrzegorz Bizon
See #17478
2016-05-30Enable Style/EndOfLine Rubocop style copGrzegorz Bizon
Use Unix-style line endings. See #17478.
2016-05-30Enable Lint/BlockAlignment Rubocop copGrzegorz Bizon
See #17478