Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-08-06Enable Style/SpaceAroundEqualsInParameterDefault copGabriel Mazetto
2016-07-29Merge branch 'rubocop/enable-access-modifiers-cops' into 'master' Robert Speicher
Enable Rubocop cops that check access modifiers ## What does this MR do? This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly. This also fixes existing offenses. ## Why was this MR needed? Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis. ## What are the relevant issue numbers? See #17478 Closes #17372 See merge request !5014
2016-07-20Enable Style/MultilineTernaryOperator rubocop copGrzegorz Bizon
Avoid multi-line ?: (the ternary operator). Use if/unless instead. See #17478
2016-07-19Enable Rubocop cops for invalid access modifiersGrzegorz Bizon
This enables following cops: Check for useless access modifiers Lint/UselessAccessModifier Checks for attempts to use `private` or `protected` to set the visibility of a class method, which does not work. Lint/IneffectiveAccessModifier This also disables two false possitives in concerns.
2016-07-13Disable all cops with offenses.Connor Shea
2016-07-13Resolve feedback.Connor Shea
2016-07-13Disable two cops as recommended.Connor Shea
2016-07-13Remove some disabled cops.Connor Shea
2016-07-13Update rubocop to 0.41.2Z.J. van de Weg
https://github.com/bbatsov/rubocop/blob/v0.41.2/CHANGELOG.md