Age | Commit message (Collapse) | Author |
|
|
|
Enable SingleLinePerSelector in scss-lint
## What does this MR do?
Enables `SingleLinePerSelector` in `.scss-lint.yml`
## Are there points in the code the reviewer needs to double check?
This MR touches a lot of files, just need another pair of eyes to look through and make sure I didn't break anything.
## Why was this MR needed?
Improve SCSS maintainability and consistency
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#23485
See merge request !7081
|
|
Enable SpaceAfterVariableColon in scss-lint
## What does this MR do?
Enables `SpaceAfterVariableColon` in `.scss-lint.yml`
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Improve SCSS maintainability and consistency
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#23485
See merge request !7080
|
|
Enable SpaceAroundOperator in scss-lint
## What does this MR do?
Enables `SpaceAroundOperator` in .`scss-lint.yml`
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Improve SCSS maintainability and consistency
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#23485
See merge request !7078
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Enable the UrlFormat and UrlQuotes SCSS Linters.
There were no lints to fix for this one, so it's just preventative.
UrlFormat: URLs should be valid and not contain protocols or domain names.
UrlQuotes: URLs should always be enclosed within quotes.
cc: @jschatz1
See merge request !3770
|
|
|
|
Prevents empty SCSS rules from being included in the SCSS.
Also fixes the handful of lints caught by the linter.
|
|
Also add some previously missing linters.
|
|
Also resolve all instances of spaces not being included before opening
braces.
|
|
passing sooner.
Discussed in #14299.
[ci skip]
|
|
documentation for SCSS Style Guide.
See !3069 for more information.
|