Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-27Improve responses for Runner's new job requestsce-split-conflict-and-validation-errors-from-job-scheduling-error-analyseTomasz Maczukin
When job is being scheduled, GitLab tries to detect concurrent requests that would get the same job. In that case only the first Runner that asked for a job gets it, and all other requests are internally handled again (until there are other jobs in the queue that matches suchi specific Runner). When such "conflict" situation was detected and no job was found in the loop repeat, Runner receives a `409 Conflict` response, which leaves a track about such situation. It additionally triggers a request back-off on Runner, so in highly concurrent installations it should generate some intervals between concurrent requests from different Runners. However, one of the symptoms used for finding the "conflict" situation is the `StateMachines::InvalidTransition` exception, which may be also thrown when some data doesn't pass validation. This is a case that should definitely not produce a `409 Conflict` response, but instead a `400 Bad Request` one with details about what was wrong should be sent. This commit adds a needed update to the `Ci::RegisterJobService` service and the `/api/v4/jobs/request` endpoint. It efectively splits the 'conflict' and 'validation error' cases for job scheduling. More details about the problem and why we'fe decided to handle it like that can be found in https://gitlab.com/gitlab-org/gitlab-runner/issues/4360.
2019-08-27Merge branch 'fix-nil-error-in-gitlab-danger-teammate' into 'master'Lin Jen-Shin
Fix a nil error in Gitlab::Danger::Teammate See merge request gitlab-org/gitlab-ce!32284
2019-08-27Merge branch 'docs/update-api-snippets' into 'master'Achilleas Pipinellis
Add example requests for snippets API See merge request gitlab-org/gitlab-ce!31964
2019-08-27Add example requests for snippets APIRainer Kern
2019-08-27Fix a nil error in Gitlab::Danger::TeammateRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27Merge branch 'qa-autodevops-smoke-check' into 'master'Dan Davison
Ensure autodevops is enabled before running Smoke test See merge request gitlab-org/gitlab-ce!31867
2019-08-27Merge branch 'docs-document-category-labels' into 'master'Achilleas Pipinellis
Improve documentation of stage, group, category, feature labels See merge request gitlab-org/gitlab-ce!32053
2019-08-27Merge branch 'ashmckenzie/remove-mdl-gem' into 'master'Achilleas Pipinellis
Remove the mdl gem as it's no longer in use See merge request gitlab-org/gitlab-ce!32253
2019-08-27Merge branch 'qa/issue-boards-navigation' into 'master'Sanad Liaquat
Update view for testability and update page object See merge request gitlab-org/gitlab-ce!32224
2019-08-27Merge branch 'remove-docker-tag-for-reports-jobs' into 'master'Nick Thomas
Don't set tags for the reports jobs See merge request gitlab-org/gitlab-ce!32276
2019-08-27Merge branch 'winh-prepend-entity' into 'master'Yorick Peterse
Replace prepend_entity with prepend_if_ee helper Closes gitlab-ee#13639 See merge request gitlab-org/gitlab-ce!32214
2019-08-27Replace prepend_entity with prepend_if_eeWinnie Hellmann
(cherry picked from commit 897a9d308db46b620b738b98f2b0e5630ac7d2dd)
2019-08-27Merge branch 'ce-ealcantara-eks-move-gke-dropdown-directory' into 'master'Mike Greiling
CE-backport: Move create cluster Vue apps to create_cluster directory. See merge request gitlab-org/gitlab-ce!32220
2019-08-27Don't set tags for the reports jobsRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27Move gke_cluster_dropdowns to create_cluster dirEnrique Alcantara
This commit creates a create_cluster directory to collect all Vue applications related to creating kubernetes applications using gitlab. It also moves the gke_cluster_dropdowns collection of apps to the create_cluster directory. gke_cluster_dropdowns contains dropdown components used to select configuration options to create a Kubernetes cluster in Google Cloud.
2019-08-27Merge branch ↵Lin Jen-Shin
'65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master' Detect the new stage labels in `Gitlab::Danger::Teammate` Closes #65312 See merge request gitlab-org/gitlab-ce!32261
2019-08-27Merge branch ↵Jan Provaznik
'66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master' Use `stub_full_request` to fix spec failure Closes #66641 See merge request gitlab-org/gitlab-ce!32259
2019-08-27Merge branch 'docs/fix-linting-problems' into 'master'Kushal Pandya
Removes trailing whitespace to fix linting See merge request gitlab-org/gitlab-ce!32265
2019-08-27Removes trailing whitespace to fix lintingEvan Read
2019-08-27Use `stub_full_request` to fix spec failureHeinrich Lee Yu
Also change test URL sequest to .test TLD
2019-08-27Merge branch '13806-fix' into 'master'Lin Jen-Shin
Add nil check for Gitlab.config.prometheus Closes #13806 See merge request gitlab-org/gitlab-ce!32201
2019-08-27Merge branch 'docs-update-needs-example' into 'master'Kamil Trzciński
Update the syntax of DAG example See merge request gitlab-org/gitlab-ce!32137
2019-08-27Introduce facet labelsRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27Improve documentation of stage, group, category, feature labelsRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27Merge branch 'nik-db-migrations-prefer-atomic-docs' into 'master'Evan Read
Update DB migrations style guide: prefer atomic migrations when possible See merge request gitlab-org/gitlab-ce!31915
2019-08-27Migrations guide: use atomic steps, when possibleMayra Cabrera
Currently, the DB migrations guide says that "you must" use non-blocking operations (such as CREATE INDEX CONCURRENTLY), always. But this does not make sense in cases of empty tables and leads to splitting the work to multiple non-atomic (with disable_ddl_transaction!) DB migrations. To follow KISS principle, to have fewer DB migrations steps, to have them atomic when it's possible and simplify deployment and troubleshooting, the following exceptions were added to the doc: - index creation, - index dropping, - defining an FK, - adding a column with DEFAULT,
2019-08-27Detect the new stage labels in Gitlab::Danger::TeammateRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27Merge branch 'docs/markdownlint-before-nanoc' into 'master'Evan Read
Run markdownlint before Nanoc checks See merge request gitlab-org/gitlab-ce!32256
2019-08-27Run markdownlint before Nanoc checksAchilleas Pipinellis
Make it simpler to run markdownlint by moving it before we do those hacks to run Nanoc.
2019-08-27Merge branch '57657-promote-label-to-group-label-via-api-endpoint' into 'master'Sean McGivern
Promote Label to Group Label via API endpoint Closes #57657 See merge request gitlab-org/gitlab-ce!25218
2019-08-27Remove the mdl gem as it's no longer in useAsh McKenzie
2019-08-27Merge branch 'docs-sethgitlab-featureflags' into 'master'Achilleas Pipinellis
Update index of feature flags See merge request gitlab-org/gitlab-ce!32217
2019-08-27Update index of feature flagsSeth Berger
Made it clear the pages are about feature flags, and not documentation.
2019-08-27Merge branch 'docs-capitalization-2' into 'master'Achilleas Pipinellis
Update capitalization in /dev docs See merge request gitlab-org/gitlab-ce!32189
2019-08-27Update capitalization in /dev docsMarcel Amirault
Clean up capitalization in /development /gitlab-basics and /install
2019-08-27Merge branch 'docs-capitalization-3' into 'master'Achilleas Pipinellis
Update capitalization in /integrations and /raketasks See merge request gitlab-org/gitlab-ce!32241
2019-08-27Update capitalization in /integrations and /raketasksMarcel Amirault
Also updates redirect text in /project-services
2019-08-27Merge branch 'sh-project-feature-nplus-one' into 'master'Jan Provaznik
Remove N+1 SQL query loading project feature in dashboard Closes #66482 See merge request gitlab-org/gitlab-ce!32169
2019-08-27Merge branch 'patch-25' into 'master'Evan Read
[#2838] add cache override explanation See merge request gitlab-org/gitlab-ce!32024
2019-08-27[#2838] add cache override explanationJace Bennest
2019-08-27Merge branch 'patch-73' into 'master'Evan Read
Update `only` `chat` statement to correct singular form See merge request gitlab-org/gitlab-ce!32116
2019-08-27Update `only` `chat` statement to correct singular formDaniel Gruesso
2019-08-27Merge branch 'qa-ml-dequarantine-tests' into 'master'Ramya Authappan
Remove passing tests from quarantine Closes gitlab-org/quality/nightly#127 See merge request gitlab-org/gitlab-ce!32237
2019-08-27Merge branch 'docs-fix-omniauth-line' into 'master'Evan Read
Add missing blank line to omniauth doc See merge request gitlab-org/gitlab-ce!32250
2019-08-27Add missing blank line to omniauth docMarcel Amirault
2019-08-27Merge branch '63502-encrypt-deploy-token' into 'master'Stan Hu
Resolve "Store deploy tokens encrypted" Closes #63502 See merge request gitlab-org/gitlab-ce!30679
2019-08-27Merge branch 'feature-branch-gather-jobs-data' into 'master'Stan Hu
Reduce the complexity of our CI configuration Closes #51367 and #65702 See merge request gitlab-org/gitlab-ce!31728
2019-08-27Merge branch 'oauth_bypass_two_factor' into 'master'Michael Kozono
Add option to allow OAuth providers to bypass two factor Closes #56059 See merge request gitlab-org/gitlab-ce!31996
2019-08-27Update docs and comments about saml with allow_bypass_two_factordodocat
allow_bypass_two_factor configration dose not work with saml provider
2019-08-27Merge branch 'docs-no-more-k8s-service-template' into 'master'Evan Read
Docs: Remove mention of Kubernetes service templates See merge request gitlab-org/gitlab-ce!32093