Age | Commit message (Collapse) | Author |
|
When job is being scheduled, GitLab tries to detect concurrent requests
that would get the same job. In that case only the first Runner that
asked for a job gets it, and all other requests are internally handled
again (until there are other jobs in the queue that matches suchi
specific Runner).
When such "conflict" situation was detected and no job was found in the
loop repeat, Runner receives a `409 Conflict` response, which leaves a
track about such situation. It additionally triggers a request back-off
on Runner, so in highly concurrent installations it should generate some
intervals between concurrent requests from different Runners.
However, one of the symptoms used for finding the "conflict" situation
is the `StateMachines::InvalidTransition` exception, which may be also
thrown when some data doesn't pass validation. This is a case that
should definitely not produce a `409 Conflict` response, but instead a
`400 Bad Request` one with details about what was wrong should be sent.
This commit adds a needed update to the `Ci::RegisterJobService` service
and the `/api/v4/jobs/request` endpoint. It efectively splits the
'conflict' and 'validation error' cases for job scheduling.
More details about the problem and why we'fe decided to handle it like
that can be found in
https://gitlab.com/gitlab-org/gitlab-runner/issues/4360.
|
|
Fix a nil error in Gitlab::Danger::Teammate
See merge request gitlab-org/gitlab-ce!32284
|
|
Add example requests for snippets API
See merge request gitlab-org/gitlab-ce!31964
|
|
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Ensure autodevops is enabled before running Smoke test
See merge request gitlab-org/gitlab-ce!31867
|
|
Improve documentation of stage, group, category, feature labels
See merge request gitlab-org/gitlab-ce!32053
|
|
Remove the mdl gem as it's no longer in use
See merge request gitlab-org/gitlab-ce!32253
|
|
Update view for testability and update page object
See merge request gitlab-org/gitlab-ce!32224
|
|
Don't set tags for the reports jobs
See merge request gitlab-org/gitlab-ce!32276
|
|
Replace prepend_entity with prepend_if_ee helper
Closes gitlab-ee#13639
See merge request gitlab-org/gitlab-ce!32214
|
|
(cherry picked from commit 897a9d308db46b620b738b98f2b0e5630ac7d2dd)
|
|
CE-backport: Move create cluster Vue apps to create_cluster directory.
See merge request gitlab-org/gitlab-ce!32220
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
This commit creates a create_cluster directory to collect
all Vue applications related to creating kubernetes applications
using gitlab.
It also moves the gke_cluster_dropdowns collection of apps to
the create_cluster directory. gke_cluster_dropdowns contains
dropdown components used to select configuration options to
create a Kubernetes cluster in Google Cloud.
|
|
'65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master'
Detect the new stage labels in `Gitlab::Danger::Teammate`
Closes #65312
See merge request gitlab-org/gitlab-ce!32261
|
|
'66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master'
Use `stub_full_request` to fix spec failure
Closes #66641
See merge request gitlab-org/gitlab-ce!32259
|
|
Removes trailing whitespace to fix linting
See merge request gitlab-org/gitlab-ce!32265
|
|
|
|
Also change test URL sequest to .test TLD
|
|
Add nil check for Gitlab.config.prometheus
Closes #13806
See merge request gitlab-org/gitlab-ce!32201
|
|
Update the syntax of DAG example
See merge request gitlab-org/gitlab-ce!32137
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Update DB migrations style guide: prefer atomic migrations when possible
See merge request gitlab-org/gitlab-ce!31915
|
|
Currently, the DB migrations guide says that "you must" use non-blocking
operations (such as CREATE INDEX CONCURRENTLY), always.
But this does not make sense in cases of empty tables and leads to
splitting the work to multiple non-atomic
(with disable_ddl_transaction!) DB migrations.
To follow KISS principle, to have fewer DB migrations steps,
to have them atomic when it's possible and simplify deployment
and troubleshooting, the following exceptions were added
to the doc:
- index creation,
- index dropping,
- defining an FK,
- adding a column with DEFAULT,
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Run markdownlint before Nanoc checks
See merge request gitlab-org/gitlab-ce!32256
|
|
Make it simpler to run markdownlint by moving it before
we do those hacks to run Nanoc.
|
|
Promote Label to Group Label via API endpoint
Closes #57657
See merge request gitlab-org/gitlab-ce!25218
|
|
|
|
Update index of feature flags
See merge request gitlab-org/gitlab-ce!32217
|
|
Made it clear the pages are about feature flags,
and not documentation.
|
|
Update capitalization in /dev docs
See merge request gitlab-org/gitlab-ce!32189
|
|
Clean up capitalization in /development /gitlab-basics and
/install
|
|
Update capitalization in /integrations and /raketasks
See merge request gitlab-org/gitlab-ce!32241
|
|
Also updates redirect text in /project-services
|
|
Remove N+1 SQL query loading project feature in dashboard
Closes #66482
See merge request gitlab-org/gitlab-ce!32169
|
|
[#2838] add cache override explanation
See merge request gitlab-org/gitlab-ce!32024
|
|
|
|
Update `only` `chat` statement to correct singular form
See merge request gitlab-org/gitlab-ce!32116
|
|
|
|
Remove passing tests from quarantine
Closes gitlab-org/quality/nightly#127
See merge request gitlab-org/gitlab-ce!32237
|
|
Add missing blank line to omniauth doc
See merge request gitlab-org/gitlab-ce!32250
|
|
|
|
Resolve "Store deploy tokens encrypted"
Closes #63502
See merge request gitlab-org/gitlab-ce!30679
|
|
Reduce the complexity of our CI configuration
Closes #51367 and #65702
See merge request gitlab-org/gitlab-ce!31728
|
|
Add option to allow OAuth providers to bypass two factor
Closes #56059
See merge request gitlab-org/gitlab-ce!31996
|
|
allow_bypass_two_factor configration dose not work with saml provider
|
|
Docs: Remove mention of Kubernetes service templates
See merge request gitlab-org/gitlab-ce!32093
|