| Age | Commit message (Collapse) | Author |
|---|
|
use single quote for consistency
See merge request !7442
|
|
Resolve "Link from build page to its pipeline"
## What does this MR do?
Adds references and links to a build's pipeline within both individual build pages and the build index.
## Are there points in the code the reviewer needs to double check?
Nothing springs to mind
## Why was this MR needed?
See #22307
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22307
See merge request !7082
|
|
Only run builds on master of CE or EE
This should reduce builds run by projects still running all pipelines for CE
See merge request !6869
|
|
Fix link to index.md UX guide in development README.md
Fix wrong link to UX docs that introduced by
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7142
See merge request !7444
|
|
[ci skip]
|
|
|
|
Improvements to hover/active/focus states in header items
## What does this MR do?
Adds some improvements to buttons, dropdowns, inputs, etc. in the header area.
## Are there points in the code the reviewer needs to double check?
I'm not sure.
## Why was this MR needed?
Requested in an issue.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24202
This is not complete yet. I'm new to this, so please let me know what all steps do I need to do (tests, changelog, etc.).
See merge request !7412
|
|
Fix record not found error on NewNoteWorker processing
Resolves #22678
See merge request !6863
|
|
fix Super User spacing
See merge request !7433
|
|
update redis server details
See merge request !7436
|
|
|
|
|
|
|
|
|
|
|
|
- Also remove unnecessary param
|
|
Update 8.14-rc1 migrations to minimize downtime and deploy time
## What does this MR do?
Modify 8.14-rc1 migrations and code to minimize downtime and deploy time
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
8.14-rc1 migrations took too much time in staging, so we didn't want to take too much downtime in production
## Does this MR meet the acceptance criteria?
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24386
See merge request !7427
|
|
Ensure labels are loaded for all "show" methods of MR Controller
Closes #24397
See merge request !7416
|
|
See https://gitlab.com/gitlab-org/gitlab-ce/issues/24386
|
|
Allow certain Sidekiq jobs to be throttled
## What does this MR do?
Allows certain slow running Sidekiq jobs to be throttled. It is disabled by default and can be enabled via the Application Settings.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
## What are the relevant issue numbers?
Related to #23352
See merge request !7292
|
|
Migration to Vuejs version 2
List of required changes for our Vue usages
- `init` :arrow_right: `beforeCreate`
- `read` :arrow_right: `mounted`
- `$els` :arrow_right: `$refs`
- :no_entry_sign: `$remove` completely removed. :white_check_mark: Use `indexOf` and `splice`
- :no_entry_sign: HTML embedding with `{{{ }}}` is deprecated. :white_check_mark: Use `v-html`
See merge request !7254
|
|
Previously, they were only being loaded on the actual `show` action, but
not the actions representing the tabs (commits, builds, etc).
|
|
UX guide restructure
The goal of this MR was to update the current UI guide to more of an UX guide (starting to detail when to use certain controls and patterns), and add structure to help organize the information. This initial version of the UX guide also lays down the groundwork for principles and personality. This guide is currently documenting the existing design, and will continue to be updated as the design evolves.
Some inspiration/references used:
- https://medium.com/ge-design/ges-predix-design-system-8236d47b0891#.nkf0chj8r
- http://uxcellence.com/2015/11/04/product-principles/
- https://blog.asana.com/2013/10/design-principles/
See merge request !7142
|
|
|
|
[ci skip]
|
|
|
|
|
|
19205 Redesign group page header to match new navigation
## What does this MR do?
Redesigns group page to match comps
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #19205
See merge request !7363
|
|
Remove project_title additions from builds and environments
## What does this MR do?
Removed soon-to-be un-needed project title additions from builds and environments.
**This MR depends on !5998, which introduces subnav to these pages. Without it we're just removing a useful link.**
## Are there points in the code the reviewer needs to double check?
@iamphill Is this right of me? One of these still exists in `projects/artifacts/browse`, I'm not sure whether to fix the issue with `project_title`, which already has some issues with its chevron, or just remove it as it will soon be redundant.
## Why was this MR needed?
## Screenshots (if relevant)
**BEFORE:**
**AFTER:**
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21764
See merge request !6160
|
|
'master'
Account for fixed position MR when scrolling to elements
## What does this MR do?
This MR accounts for the new merge request fixed affix bar when scrolling to an element on the MR page.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
The fixed MR tabs bar was not being taken into account when shifting permalink scroll targets so that they are unobscured by navigation elements.
## Screenshots (if relevant)
Issues discussion permalink:
Merge request discussion permalink:
Merge request diff permalink:
Commit diff page permalinks work as well, but aren't highlighted currently (see: #23696)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #23520
See merge request !7051
|
|
Fix project records with invalid visibility_level values
See merge request !7391
|
|
Fix the collapsed diff when converting a symlink to a regular file
#21610
!6828
See merge request !6953
|
|
Require projects before creating milestone
Closes #24101
See merge request !7301
|
|
Use GitLab.com link, remove GitHub link
Fix dead link GitHub=>GitLab
See merge request !7418
|
|
|
|
Use config param in `Repository#update_ref!`
See merge request !7395
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Block out pages needed for ux_guide
Add resources stub to ux_guide home
Fill out principles and basics
Add TOC to basics
Move all of UI guide to new UX guide structure
Add first level structure on ux-guide pages
Add more details to buttons
Add button images. Update link on development
Renamed surfaces to templates. Add tooltip details
Update typography and icons on Basics page
Add images for color. First draft of voice and tone
Delete findings page
Refine pages. Fill out Surfaces pages
Clean up layout on basics, surfaces, features. Add anchorlinks and counts to components
Fill out components page
Add item title and system info block
Fill out Features page
Switch tooltip placement image
|
|
Remove additional padding on right-aligned items in MR widget.
## What does this MR do?
Remove additional padding on right-aligned items in MR widget. So links look aligned.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
Because the links are not aligned.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24369
See merge request !7411
|
|
'24279-issue-merge-request-sidebar-todo-button-style-improvement' into 'master'
Removed gray button styling from todo buttons in sidebars
## What does this MR do?
Removes gray button styling from todo buttons in sidebars
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
gray buttons are inconsistent and look disabled
## Screenshots (if relevant)
before:
after:
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24279
See merge request !7387
|
|
|
|
Fixes #24369.
|
