| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Remove inconsistent font weight for sidebar's labels
## What does this MR do?
Removes the `.bold` css class from the sidebar label default value so that it is no longer bold :smile:
**None** => None
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Fixes a UI inconsistency
## What are the relevant issue numbers?
Closes #21141
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5984
|
|
Fix inconsistent checkbox alignment
## What does this MR do?
Vertically aligns the checkboxes to the top so that it is aligned with the issue titles
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Fixes existing UI inconsistency
## What are the relevant issue numbers?
Closes #21398
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6032
|
|
Front End - Rewrote ES5 `user.js` to ES6 `user.js.es6`
## What does this MR do?
This MR removes the `users.js` file in `app/assets/javascripts/users.js` and replaces it with ES6.
* It also adds the file extension `.es6` so that the sprockets babel gem can transpile it to ES5.
* The new file is: `users.js.es6` in `app/assets/javascripts/`
* Replaced `new User` with `new gl.User` in `app/views/users/show.html.haml`
## Are there points in the code the reviewer needs to double check?
I followed the AirBnb guide, but if there are any mistakes let me know!
## Why was this MR needed?
Because the entire coffee script codebase was transferred over to ES5 with a plan to move everything over to ES6 :smile:
## What are the relevant issue numbers?
#20098
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5676
|
|
Add the total number of issues in the JSON response in issue board lists
## What does this MR do?
Add the total number of issues in the JSON response in issue board lists
## Why was this MR needed?
The issue board lists should always show the total number of issues in the list, not the current amount fetched by endless scroll.
Closes #21327
See merge request !5904
|
|
|
|
Change widths of content in MR pipeline tab
## What does this MR do?
* Fixes width of items in pipelines tab
* Removes scrollbars on Windows
## Screenshots (if relevant)
#### What are the relevant issue numbers?
Closes #21396
Closes #21781
See merge request !6157
|
|
'21508-inconsistency-personal-dashboard-todos-page-uses-old-interface-wrong-dropdown-filter-buttons' into 'master'
Update todo view filter dropdowns
## What does this MR do?
Swaps out old `select2` dropdowns on todo page with newer dropdowns.
Also removes todo inline JS.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
### Project
### Author
### Type
### Action
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21508
Related to #19866
See merge request !6072
|
|
Remove prefixes from transition CSS property
## What does this MR do?
Removes vendor prefixes from the CSS transition property
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Reduces unnecessary CSS
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21614
See merge request !6093
|
|
Add curve to generic commit status pipeline
#### What does this MR do?
Add curve to generic commit status pipeline
#### Screenshots (if relevant)
Before:
After:
See merge request !6156
|
|
Enable Ruby 2.3 for rubocop too
See merge request !6153
|
|
|
|
Optimize branch lookups and force a repository reload for Repository#find_branch
See merge request !6087
|
|
Some minor updates to upgrade guides for 8.12.
See merge request !6154
|
|
|
|
|
|
Resolve "Inconsistency: Repo Title "down caret" cropped on smaller viewports"
## What does this MR do?
Fixes an issue where the dropdown chevron for a project list was not visible on smaller viewports.
This MR also changes the dropdown trigger into a `button` element for better accessibility (it can now be tabbed to like any link).
## Are there points in the code the reviewer needs to double check?
None that I can think of.
## Why was this MR needed?
Better accessibility and support for smaller viewports.
## Screenshots (if relevant)
Dropdown toggle now targetable by pressing tab to select.
Chevron no longer hidden when project title length triggers `overflow: ellipsis`.
## Does this MR meet the acceptance criteria?
- [x] CHANGELOG entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21506
See merge request !6140
|
|
|
|
Replace play icon font with svg
## What does this MR do?
Replaces the `play` font awesome icon with svg
## Are there points in the code the reviewer needs to double check?
Make sure that the svg is looking great on all the changed pages
## Why was this MR needed?
SVG is better than fonts :smile:
## What are the relevant issue numbers?
#21455
## Screenshots (if relevant)
Before (Pipeline):
After (Pipeline):
Before (Environments):
After (Environments):
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6038
|
|
Center build stage columns in pipeline overview
## What does this MR do?
Centers the build stage table content and headers in the [pipeline view](https://gitlab.com/gitlab-org/gitlab-ce/pipelines)
## Are there points in the code the reviewer needs to double check?
Need to check whether it is okay to remove the following ([commit that added this property](https://gitlab.com/gitlab-org/gitlab-ce/commit/6130376ad6673facb729b78878f9156a29948a5b))
```
.light {
width: 3px;
}
```
## Why was this MR needed?
Improve UI
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21708
See merge request !6135
|
|
|
|
|
|
Project tools visibility level
## part of #19734
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5606
|
|
Merge request sha info
## What does this MR do?
Exposes `sha` and `merge_commit_sha` items in `MergeRequest` API endpoint data.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
It's useful information.
## What are the relevant issue numbers?
Closes #20456.
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5966
|
|
|
|
Use JavaScript tooltips for mentions
## What does this MR do?
- use JavaScript tooltips instead of plain title for mentions (issue, merge request, snippet, user, group, commit, commit range, milestone)
## Why was this MR needed?
JavaScript tooltips look nicer and can wrap.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5261#note_13106713, fixes #21500
See merge request !5301
|
|
Order award tooltips by their created_at date
## What are the relevant issue numbers?
Closes #20601
See merge request !6086
|
|
|
|
|
|
|
|
|
|
|
|
polishing off the selected dropdown states
|
|
ProjectSelect.js (or different)
|
|
|
|
|
|
|
|
|
|
into 'master'
Fix suggested colors options for new labels in the admin area
## What does this MR do?
Execute the JS related to the suggested colors options when user access the new label in the admin area.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
Clicking in a suggested color when creating a new label in the admin area don't change the background color.
## Screenshots (if relevant)
* Before
* After
## Does this MR meet the acceptance criteria?
- [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/21726
See merge request !6138
|
|
Expire commit view partial after a day
See merge request !6128
|
|
|
|
Add MR Documentation description template
Add an MR Documentation template for `gitlab-ce`.
See merge request !6145
|
|
|
|
If `git gc` runs and `Repository` has an instance to `Rugged::Repository`, a
bug in libgit2 may cause the instance to return a stale value or a missing
branch. This change not only optimizes the branch lookup so we don't have
to iterate through every branch, but it also works around the `git gc`
issue by forcing a repository reload every time `Repository#find_branch`
is called.
See: https://github.com/libgit2/libgit2/issues/1534
Closes #15392, #21470
|
|
|
|
|
|
|
|
|
|
|
