| Age | Commit message (Collapse) | Author |
|---|
|
This reverts commit b826c9ff17b701344028832d523522a3cb925a23
|
|
Use container helper instead of hard coded container
## What does this MR do?
Add `container_class` helper class to fix layout bug
## What are the relevant issue numbers?
#18333
## Screenshots (if relevant)
Fixed:
Fluid:
See merge request !4543
|
|
Fixed dropdown link line-height
## What does this MR do?
Fixes line-height issue on dropdown menu links
## Why was this MR needed?
The line-height of some dropdown links were taking the parent, most noticeable the commit header
## Screenshots (if relevant)
Before:
After:
See merge request !4531
|
|
Improve ui consistency
* Decline idea of using gray buttons actively in UI
* remove icons from some buttons that already has text
* standardizes margin between buttons
First step in https://gitlab.com/gitlab-org/gitlab-ce/issues/18324
See merge request !4533
|
|
Allow custom text on 'almost there' page
Add a new application setting, after_sign_up_text. This is text to be
rendered as Markdown and shown on the 'almost there' page after a user
signs up, but before they've confirmed their account.
Closes #14098.
See merge request !4098
|
|
'master'
Allow clones from /namespace/project
Allow `git clone https://host/namespace/project` to work, in addition to `git clone https://host/namespace/project.git`
Closes #13840.
See merge request !4530
|
|
Redirect /namespace/project/info/refs to
/namespace/project.git/info/refs, so `git clone` works on either
namespace/project.git or namespace/project.
|
|
Added minimum password length to password field
Add a placeholder to the password field in the register form with the minimum number of characters required. Also added a pattern to the field to stop it submitting if less than that.
Closes #17765
See merge request !4458
|
|
Set target="_blank" for external links
Closes #14553
See merge request !4526
|
|
|
|
Disable Rails/UniqBeforePluck rubocop cop
Rails/UniqBeforePluck seems to have some bugs
* https://github.com/bbatsov/rubocop/issues/3122
* https://github.com/bbatsov/rubocop/issues/3148
and we had some problems in EE with that https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/425#note_12245005
See merge request !4477
|
|
[ci skip]
|
|
Add a new application setting, after_sign_up_text. This is text to be
rendered as Markdown and shown on the 'almost there' page after a user
signs up, but before they've confirmed their account.
Tweak the styles for that page so that centered lists look reasonable.
|
|
|
|
|
|
|
|
|
|
Sidebar updates
## What does this MR do?
Updates `nav/_admin.html.haml` and `nav/_explore.html.haml` to match new compact sidebar design
## Screenshots (if relevant)
See merge request !4517
|
|
Update Knapsack report only on master
## What does this MR do?
Makes to generate Knapsack report only on master. This speed-ups tests, because the last stage can be run significant time after previous stages.
See merge request !4540
|
|
Optimize issuable APIs interaction with notes
See merge request !4471
|
|
Remove notification settings in batches
## What does this MR do?
This improves the performance of the migration `db/migrate/20160603180330_remove_duplicated_notification_settings.rb` by removing duplicate rows in batches instead of using a single big `DELETE FROM` query.
## Why was this MR needed?
The original migration would locally take 45 minutes to complete, possibly up to hours on GitLab.com and similar setups.
## What are the relevant issue numbers?
#18289
See merge request !4529
|
|
|
|
Removable labels from filtered issuables label bar
When filtering by labels, a remove button appears next to each label. This then removes that label & refreshes the issuable filter form
Closes #15474
See merge request !4178
|
|
Backported from EE shared form for web hooks
## What does this MR do?
EE uses a shared form for web hooks - so this brings that across to CE.
See merge request !4457
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
|
|
This was not a clear cut n+1 query, given that if you're directly subscribed to all issues
that the API is returning you never really need to check for the notes. However, if you're
subscribed to _all_ of them, then for each issuable you need to go once to `notes`, and
once to `users` (for the authors). By preemtively loading notes and authors, at worst you have
1 extra query, and at best you saved 2n extra queries. We also took advantage of this preloading
of notes when counting user notes.
|
|
unnecessary queries
`notes_with_associations` are used for `participant` declarations, but `Participable`
only really cares about the target entity project, and not the participants
projects.
`notes_with_associations` are also used in `Commit::has_been_reverted?` which
employs the reference extractor of the commit, so no references to the notes
projects are made there (`Mentionable::all_references` cares only about the
`author` and other `attr_mentionable`). A paralel situation occurs on
`Issue::referenced_merge_requests`.
|
|
This improves performance of the duplicate notification settings
migration by removing duplicates in batches instead of using one big
"DELETE FROM" query.
The previous query would locally run over 45 minutes without even
finishing. This new setup finished in a matter of seconds.
Fixes #18289
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Add fog-azure to supported backup list
!4396 left out Azure by accident.
See merge request !4444
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Dismantling Grack::Auth part 1: Git HTTP clients
Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/14501
This does not completely get rid of Grack::Auth yet because Git LFS
support is 'behind' it and I would like to not make this MR bigger
than needed.
- changed tests to make HTTP requests instead of calling Rack apps
- added missing test cases for Git HTTP authentication
- moved Git HTTP requests into a 'normal' Rails controller
See merge request !3361
|
|
Fix endless redirections when accessing user OAuth applications when they are disabled
## What does this MR do?
This MR fixes a bug where the browser would be redirect endlessly when attempting to access the user's OAuth applications when an admin has disabled this system-wide setting.
## Are there points in the code the reviewer needs to double check?
I assume disabling the nav button is better than showing a page that says, "OAuth applications are disabled by the admin."
## Why was this MR needed?
Lots of users were confused when they hit endless redirect errors.
## What are the relevant issue numbers?
#14770
See merge request !4525
|
|
* make sidebar button white
* make header button gray if not primary
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Fix markdown_spec to not use `before(:all)` in order to properly cleanup database after testing
See merge request !4515
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
are disabled
Also hides the "Applications" nav button if OAuth applications are disabled by the admin.
Closes #14770
|
|
Add a test for User#ci_authorized_runners
## What does this MR do?
Add a test for User#ci_authorized_runners
## Are there points in the code the reviewer needs to double check?
Should we add `Project#add_user` so that it's similar to `Group#add_user`?
## Why was this MR needed?
I am going to make some changes to this method for !4093, but I couldn't find a corresponding test so I want to add it in case I would break anything.
## What are the relevant issue numbers?
This is a test for current behaviour, before implementing #3407
See merge request !4404
|
|
Check if GitHub rate limite API was reached before update Webhooks
## What does this MR do?
Checks if the job needs to sleep, and wait for the rate limit to be reseted before update each Webhook.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
The import process can fail if the API rate limit was reached during the import process.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/17498
## Screenshots (if relevant)
Not relevant.
See merge request !4509
|
|
Enable Knapsack only in CI environment
Fixes running tests locally. Enables Knapsack only in CI environment.
cc @grzesiek
See merge request !4528
|
|
Most noticable on the commit header
|
|
Added tests
|
|
|
|
|
|
When filtering by labels, a remove button appears next to each label. This then removes that label & refreshes the issuable filter form
Closes #15474
|
|
|
|
|
|
git-http-controller
Conflicts:
lib/gitlab/workhorse.rb
|
|
Add flexbox to project header
## What does this MR do?
Adds flexbox to project header to keep components vertically centered regardless of description presence/length
## What are the relevant issue numbers?
Closes #18080
## Screenshots (if relevant)
See merge request !4417
|
