| Age | Commit message (Collapse) | Author |
|---|
|
Add width to caret to rid ourselves of the shift
## What does this MR do?
Removes the shift from diff files.
## Are there points in the code the reviewer needs to double check?
That it doesn't shift.
## Why was this MR needed?
There was a shift in the minimizing of diff files.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23424
See merge request !6934
|
|
|
|
Closes #24075
|
|
Add CHANGELOG
uses fa-fw from font awesome instead of using declaring fix width explicitly
moves changelog entry under 8.14
rebased with master
|
|
Updated styling commit SHA on branches page
## What does this MR do?
Updated styling of commit SHA on the branches page to include the commit icon and be blue
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
to make the branches page in line with upcoming update to the commit list, which also styles the commit sha, but slightly different.
## Screenshots (if relevant)
before:
after:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24022
See merge request !7219
|
|
Show log corresponding to env in admin/logs
Closes #23979
See merge request !7191
|
|
Closes #23026
|
|
|
|
first/last child selectors
|
|
Moved most of the functions that contained "window.doSomething" that were located at:
- app/assets/javascripts/application.js
To the following file:
- app/assets/javascripts/lib/utils/common_utils.js
The functions listed here:
- window.ajaxGet
- window.split
- window.extractLast
- window.rstrip
- window.disableButtonIfEmptyField
- window.disableButtonIfAnyEmptyField
- window.sanitize
- window.unbindEvents
- window.shiftWindow
Now will be accessible from the "gl.utils" namespace
|
|
Add new icon for skipped builds; show created state in mini graph
Closes #22914
See merge request !7276
|
|
Hides registry if project repository is disabled
## What does this MR do?
When disabling the projects repository it now hides the container registry as well.
## Screenshots (if relevant)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/19734#note_17224181
See merge request !7036
|
|
No matter which environment Gitlab was running as, the admin/logs view
always showed production.log. This commit selects the logfile based
on Rails.env.
- Rename ProductionLogger to EnvironmentLogger
- Make EnvironmentLogger logfile depend on env
- Update spinach test for log tabs
|
|
|
|
Adds JavaScript validation for group path editing
## What does this MR do?
- Prevents group_edit form submission when special characters are included in the new group name
- Enhances gl_field_errors to support this use case and be more re-usable.
## Are there points in the code the reviewer needs to double check?
**The implementation of validation is here: https://gitlab.com/gitlab-org/gitlab-ce/commit/73d997046cac376ccdbcaac6f183002bc19b9a1f**
The rest of the diff for this MR is augmenting gl_field_errors
## Why was this MR needed?
- Currently we allow submission and a 500 error is returned.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922
See merge request !7041
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
[ci skip]
|
|
Check that JavaScript file names match convention
## What does this MR do?
Introduce a new ESLint rule to check JavaScript file names.
## What are the relevant issue numbers?
fixes #23118
See merge request !7238
|
|
Updated Sortable JS plugin
## What does this MR do?
Updates Sortable JS plugin for issue boards. The older version stopped the issue cards being draggable.
## What are the relevant issue numbers?
Closes #23048
See merge request !6734
|
|
Fix edit button in wiki
## What does this MR do?
Fix edit button in wiki.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
### Show Wiki
### Edit Wiki
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #13444
See merge request !7143
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
This MR adds support for the `token` attribute in the project hook API.
Feature requested on a dependant project: https://github.com/gpocentek/python-gitlab/issues/170
See merge request !7220
|
|
Added guide for upgrading Postgres using Slony
## What does this MR do?
This adds a guide for upgrading PostgreSQL using Slony.
## Are there points in the code the reviewer needs to double check?
Spelling, grammar, etc
## Why was this MR needed?
This process is not documented and we'll need to provide steps on how to do this before we start shipping PostgreSQL 9.6 with omnibus-gitlab.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
cc @pcarranza @marin @axil
See merge request !6711
|
|
Milestone dropdown does not stay selected
Closes #23713
See merge request !7117
|
|
|
|
Add Rake task to create/repair GitLab Shell hooks symlinks
## What does this MR do?
Adds a Rake task wrapper around `gitlab-shell` `bin/create_hooks` script. This makes it easier for an administrator to repair hooks symlinks without worrying about where repository data is located, etc. Just run this task and it takes care of everything based on current configuration.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
`bin/create_hooks` was not well-documented. It requires parameters specifying where repository data is located. It also needs to be run by the `git` user. Wrapping it in a Rake task allows us to take current configuration in to account and makes it easier on the administrator.
See merge request !5634
|
|
|
|
Resolve "Tables pagination is not responsive"
## What does this MR do?
Makes table pagination responsive.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Table pagination was not responsive and was broken in smaller screens
## Screenshots (if relevant)
### Small screen
### Medium screen
### Large screen
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #23053
See merge request !7157
|
|
Resolve "Improve build "Retry" button on Build Page"
* On desktop, adds retry button on build page header
* On mobile, adds retry button in sidebar
Closes #23273
See merge request !7126
|
|
|
|
Update links in side nav and header
* Remove todos, help, and project settings from sidebar
* Remove plus icon from top right header
* Put help link in user dropdown
* Add lighter bg-color at the top of side nav
Closes #22889
See merge request !7161
|
|
Support for post deployment migrations
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22133
See merge request !6572
|
|
Adds label description to issue board title
## What does this MR do?
Adds the label description as a tooltip the issue board title. Tooltip is not visible on the backlog or done list.
## Screenshots (if relevant)
## What are the relevant issue numbers?
Closes #22710
See merge request !6743
|
|
Hide project activity tabs when features are disabled
## What does this MR do?
When features are disabled in project settings, the activity tabs are now correctly hidden.
## Screenshots (if relevant)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/19734#note_17224181
See merge request !7038
|
|
|
|
Fixes changelog
|
|
|
|
Initialize Sidekiq with the list of queues used by GitLab
See merge request !7217
|
|
Add validation errors to Merge Request form
Closes #22448
See merge request !7163
|
|
Media queries for medium screens
Adds entry to CHANGELOG
Rollback to previous design
Adds class for previous sibling
Fix removed class
Fixes after review
Fix scss linter
|
|
into 'master'
Allow admin to search for user by secondary email address
Closes #23761
See merge request !7115
|
|
New todos blank state
## What does this MR do?
Updates the blank state on todos.
### Blank state when user has previously had todos
### Fully empty blank state
## What are the relevant issue numbers?
Closes #20833
See merge request !6823
|
|
|
|
It is not possible to search for a user by his secondary email address in
the Users search bar in the admin interface(/admin/users). A use-case could
be that an admin wants to remove a specific secondary email address of an
user, because it interferes with another user. Issue #23761
This commit adds ability to search not only by main email, but also
by any secondary email in the admin interface.
|
|
The parameter is used to search users by several criretia was
called :name. This request renames it to :search_query which closer
to it actual perpose
|
|
Fix project features default values
closes #23242
See merge request !7181
|
|
Fix relative links in Markdown wiki when displayed in "Project" tab
Refers to #23806
See merge request !7218
|
|
The Sidekiq client API adds an entry to the Sidekiq "queues" list,
but mail_room and gitlab-shell use redis-rb directly to insert jobs
into Redis and thus do not make an extra "sadd" call to Redis
each time a job is inserted. To make it possible to monitor
these queues via the API, add an initialization step to
set up the list at startup.
Closes gitlab-com/infrastructure#682
|
|
|
|
[ci skip]
|
