| Age | Commit message (Collapse) | Author |
|---|
|
Remove inconsistent font weight for sidebar's labels
## What does this MR do?
Removes the `.bold` css class from the sidebar label default value so that it is no longer bold :smile:
**None** => None
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Fixes a UI inconsistency
## What are the relevant issue numbers?
Closes #21141
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5984
|
|
Fix inconsistent checkbox alignment
## What does this MR do?
Vertically aligns the checkboxes to the top so that it is aligned with the issue titles
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Fixes existing UI inconsistency
## What are the relevant issue numbers?
Closes #21398
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6032
|
|
Remove prefixes from transition CSS property
## What does this MR do?
Removes vendor prefixes from the CSS transition property
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Reduces unnecessary CSS
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21614
See merge request !6093
|
|
Optimize branch lookups and force a repository reload for Repository#find_branch
See merge request !6087
|
|
Resolve "Inconsistency: Repo Title "down caret" cropped on smaller viewports"
## What does this MR do?
Fixes an issue where the dropdown chevron for a project list was not visible on smaller viewports.
This MR also changes the dropdown trigger into a `button` element for better accessibility (it can now be tabbed to like any link).
## Are there points in the code the reviewer needs to double check?
None that I can think of.
## Why was this MR needed?
Better accessibility and support for smaller viewports.
## Screenshots (if relevant)
Dropdown toggle now targetable by pressing tab to select.
Chevron no longer hidden when project title length triggers `overflow: ellipsis`.
## Does this MR meet the acceptance criteria?
- [x] CHANGELOG entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21506
See merge request !6140
|
|
Replace play icon font with svg
## What does this MR do?
Replaces the `play` font awesome icon with svg
## Are there points in the code the reviewer needs to double check?
Make sure that the svg is looking great on all the changed pages
## Why was this MR needed?
SVG is better than fonts :smile:
## What are the relevant issue numbers?
#21455
## Screenshots (if relevant)
Before (Pipeline):
After (Pipeline):
Before (Environments):
After (Environments):
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6038
|
|
Center build stage columns in pipeline overview
## What does this MR do?
Centers the build stage table content and headers in the [pipeline view](https://gitlab.com/gitlab-org/gitlab-ce/pipelines)
## Are there points in the code the reviewer needs to double check?
Need to check whether it is okay to remove the following ([commit that added this property](https://gitlab.com/gitlab-org/gitlab-ce/commit/6130376ad6673facb729b78878f9156a29948a5b))
```
.light {
width: 3px;
}
```
## Why was this MR needed?
Improve UI
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21708
See merge request !6135
|
|
|
|
|
|
Project tools visibility level
## part of #19734
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5606
|
|
Merge request sha info
## What does this MR do?
Exposes `sha` and `merge_commit_sha` items in `MergeRequest` API endpoint data.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
It's useful information.
## What are the relevant issue numbers?
Closes #20456.
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5966
|
|
|
|
Use JavaScript tooltips for mentions
## What does this MR do?
- use JavaScript tooltips instead of plain title for mentions (issue, merge request, snippet, user, group, commit, commit range, milestone)
## Why was this MR needed?
JavaScript tooltips look nicer and can wrap.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5261#note_13106713, fixes #21500
See merge request !5301
|
|
Order award tooltips by their created_at date
## What are the relevant issue numbers?
Closes #20601
See merge request !6086
|
|
into 'master'
Fix suggested colors options for new labels in the admin area
## What does this MR do?
Execute the JS related to the suggested colors options when user access the new label in the admin area.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
Clicking in a suggested color when creating a new label in the admin area don't change the background color.
## Screenshots (if relevant)
* Before
* After
## Does this MR meet the acceptance criteria?
- [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/21726
See merge request !6138
|
|
Expire commit view partial after a day
See merge request !6128
|
|
If `git gc` runs and `Repository` has an instance to `Rugged::Repository`, a
bug in libgit2 may cause the instance to return a stale value or a missing
branch. This change not only optimizes the branch lookup so we don't have
to iterate through every branch, but it also works around the `git gc`
issue by forcing a repository reload every time `Repository#find_branch`
is called.
See: https://github.com/libgit2/libgit2/issues/1534
Closes #15392, #21470
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Add a BroadcastMessage API
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/21628
See merge request !6112
|
|
Fix bug where pagination is still displayed despite all todos marked as done
## What does this MR do?
Changes the todo `mark all as done` button callback to remove pagination and add user friendly text `"You're all done!"` so that it is consistent with what the page should look like after refreshing
## Are there points in the code the reviewer needs to double check?
Shouldn't be
## Why was this MR needed?
Resolve existing UI inconsistency
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21048
See merge request !6113
|
|
|
|
Remove redundant js-timeago-pending from user activity log
## What does this MR do?
Enables the `skip_js` feature of `time_ago_with_tooltip()` since the frontend was already re-initializing `timeago` on all the elements after it received the data from the backend.
## Are there points in the code the reviewer needs to double check?
Shouldn't be
## Why was this MR needed?
* Reduces bandwidth usage (Reduced by ~3.1kb)
* Removes redundant code
* Happy DOM :balloon:
## What are the relevant issue numbers?
Closes #21063
## Screenshots (if relevant)
Before (DOM):
After (DOM):
Before (Bandwidth):
After (Bandwidth):
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5871
|
|
Filters tags by name
Closes #21673
See merge request !6121
|
|
'21567-fix-sorting-issues-by-last-updated-after-import-from-github' into 'master'
Fix sorting issues by "last updated" after import from GitHub
## What does this MR do?
Don't touch Issue/Merge Request when importing GitHub comments as it will trigger an update on `updated_at` field. It also use `updated_at` as the last updated date doesn't matter the Issue/Pull Request state.
## Why was this MR needed?
After import from GitHub, sorting issues by "last updated" doesn't work as expected.
## What are the relevant issue numbers?
Fixes #21567
See merge request !6110
|
|
Fixed invisible scroll controlls on build page on iPhone
## What does this MR do?
Fixes invisible scroll controls on build page on iPhone
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
Because it's not correct behavior.
## Screenshots (if relevant)
| Before | After |
| -------- | -------- |
|  |  |
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Not found
See merge request !6125
|
|
|
|
|
|
|
|
Fix repo title alignment
## What does this MR do?
Adds an extra pixel margin to the hamburger button so that it matches the baseline of the repo title
## Are there points in the code the reviewer needs to double check?
Shouldn't be any :smile:
## Why was this MR needed?
Resolve UI Inconsistency
## What are the relevant issue numbers?
Closes #21408
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6046
|
|
Block concurrent pipeline processings
## What does this MR do?
It's possible that two builds that succeed at the same will try to
concurrently process pipeline. This can lead to scenario when it will
fail to trigger next stages.
This MR makes sure that process of updating is blocking.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/21263
See merge request !6090
|
|
API: Expose issue confidentiality flag.
## What does this MR do?
This MR adds support for confidential issues the the API. The property as exposed and users can create or update confidential issues.
## What are the relevant issue numbers?
Closes #17199
See merge request !5384
|
|
|
|
|
|
Create bitmaps during 'git gc'
## What does this MR do?
Add instructions to enable creation of Git packfile bitmaps.
## Why was this MR needed?
Because we still are not using Git packfile bitmaps in GitLab
[ci skip]
See merge request !6104
|
|
|
|
Don't expose a user's private token in the `/api/v3/user` API
## Why was this MR needed?
A user's private token is being leaked in the `/api/v3/user` API.
## What are the relevant issue numbers?
- Closes #20911
## Does this MR meet the acceptance criteria?
- [ ] #20911 !6047 Application-Specific Tokens Are Insecure
- [x] Implementation
- [x] Test
- [x] CHANGELOG
- [x] Make sure build is green
- [x] Assign to endboss
- [ ] Wait for merge
See merge request !6047
|
|
Fixes #20456.
|
|
We rarely use Russian-doll caching in views, and when we do, it's
typically with a naturally-invalidating key. In the case of the commit
partial, though, the author lookup isn't part of the cache key - because
we're not going to use the state of the users table - and so a new email
address can take up to two weeks to show against the commits list.
Limiting this to a day still caches the partial for a healthy amount of
time, without as bad a worst case scenario.
|
|
|
|
Remove redundant pipeline tooltips from short labels
## What does this MR do?
Removes the tooltips from labels that have less than 12 characters, so that the tooltips only show when the pipeline labels are truncated
## Are there points in the code the reviewer needs to double check?
None
## Why was this MR needed?
Removes unnecessary tooltips for non-truncated pipeline labels
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#21542
See merge request !6058
|
|
|
|
|
|
|
|
|
|
|
