Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-25Keep consistent in handling indexOf resultsTakuya Noguchi
2017-02-20Fixed eslint errorPhil Hughes
2017-02-20Changes when loading indicator is added to dropdownPhil Hughes
Previously it was added when you started typing. But there is actually a delay before sending any requests which meant the loading icon was visible but it wasn't actually loading anything
2017-02-18replace implicit this == window with explicit bindingMike Greiling
2017-02-13Display loading indicator when filtering ref switcher dropdownClement Ho
2017-02-06Replaced more jQuery UI datepickersPhil Hughes
2017-02-03Merge branch '25624-anticipate-obstacles-to-removing-turbolinks' into 'master' Jacob Schatz
Remove Turbolinks Closes #25624 See merge request !8570
2017-02-02Remove turbolinks.Bryce Johnson
2017-02-02fix errors within gl_dropdown_spec.js when running in KarmaMike Greiling
2017-01-30Merge branch 'issue-sidebar-empty-assignee' into 'master' Fatih Acet
Resets issue boards assignee dropdown Closes #26514 and #26814 See merge request !8540
2017-01-25Merge branch '25312-search-input-cmd-click-issue' into 'master' Fatih Acet
Prevent removal of input that is the parent dropdown element Closes #25312 See merge request !8397
2017-01-25Prevent removing fields from dropdowns on input elementsSam Rose
2017-01-20Resets issue boards assignee dropdownPhil Hughes
Closes #26514
2017-01-19resolve all x-spacing and no-spaced-x eslint violationsMike Greiling
2017-01-19resolve all padded-blocks eslint violationsMike Greiling
2017-01-19resolve all semi and no-extra-semi eslint violationsMike Greiling
2017-01-19resolve all no-plusplus eslint violationsMike Greiling
2017-01-16Fix dropdown filter input value after blurEric Eastwood
2016-12-19Check if selected object is valid before passing to calbackAlfredo Sumaran
2016-12-16Merge branch '24877-bulk-edit-only-keeps-common-labels-when-searching' into ↵Fatih Acet
'master' Improve bulk assignment This MR improves current implementation of Label dropdown when used for bulk assignment on issuable pages (/:namespace/:project/issues, /:namespace/:project/merge_requests) Previously this dropdown relied on `<input>` tags to get its active items and also to calculate items with indeterminate state. Relying on `<input>` tags is not enough when we want to set/get multiple states on a dropdown. For this case we want to get/set: - Marked items - Unmarked items that were initially marked - Unmarked items that were initially indeterminate - Items with indeterminate state. This MR makes the Label dropdown to save its own state as `data` so it will be easy to get and set whatever state we want no matter if the dropdown is filtering which is the issue that I initially wanted to solve as you can see in the following gif. **Before** ![2016-12-07_11.44.48](/uploads/cb697161b8b39cdee72fdbb95a531100/2016-12-07_11.44.48.gif) **After** ![2016-12-07_11.32.43](/uploads/338255a302de0dd1367474f33232d2a3/2016-12-07_11.32.43.gif) As you can see in the first gif the `bug` label is removed from the selected issues but the `enhancement` label should set but the `critical` should be kept. This is fixed on the next gif. Fixes #24877 See merge request !7765
2016-12-14Address feedbackAlfredo Sumaran
2016-12-14Improve issuable's bulk assignment implementationAlfredo Sumaran
This fixes the case when the user wants to add a label. The user has to use the dropdown’s filter input to look for a label and click it in order to see the bug. Step to reproduce - Select at least two issues, one label should be present in all issues, other label should be present in at least one. - On the label dropdown: Deselect label that is present in all issues, look for another issue using the filter input and click it. - Click on `Update issues` Before: Unmarked label were kept on selected issues. Now: Unmarked label is removed from selected issues
2016-12-14resolve all instances of no-undef eslint rule violationsMike Greiling
2016-12-07Updated members dropdownsPhil Hughes
This ports some code over from EE to reduce conflicts
2016-11-17Merge branch 'explicitly-disable-eslint-inline' into 'master' Alfredo Sumaran
explicitly disable eslint inline ## What does this MR do? Explicitly disables eslint inline. I.E. `/* eslint-disable */` => `/* eslint-disable max-len, no-new, ... */` I used the script from https://gitlab.com/lbennett/eslint-dsblr. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? It will help refactor out eslint issues for older files. ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !7229
2016-11-16Stopped multiple requests with dropdownsPhil Hughes
Opening the user dropdown currently sends 2 requests. This has been changed so only one is sent Closes #24131
2016-11-15explicitly disable eslint inlineLuke "Jared" Bennett
2016-10-28Do not allow text input in dropdown while loadingIdo Leibovich
While loading, the entire dropdown is greyed out. However, The focus is on the text input, so user can input text. Move the focus event to after loading finished to fix this.
2016-10-26Merge branch 'eslint' into 'master' Fatih Acet
Add ESLint ## What does this MR do? - create `package.json` - add ESLint dependencies to `package.json` - add JavaScript linting to CI - add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`) ## Are there points in the code the reviewer needs to double check? Probably not. ## Why was this MR needed? My hovercraft was full of eels. ## What are the relevant issue numbers? - https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658 See merge request !5445
2016-10-26Refactored less readable existance checksJack Davison
CoffeeScript generated JavaScript contains some unreadable expressions. This refactoring addresses complex uses of the exestential operator that produced unreadable Javascript.
2016-10-26Merge branch 'issue-board-sidebar' into 'master' Fatih Acet
Issue board sidebar ## What does this MR do? Adds a sidebar when clicking an issue in the issue boards lists. This allows user to easily update other parts of the issue details without having to visit the issue itself. Same functionality as on issue page. When creating a new issue the sidebar automatically opens. ## Screenshots (if relevant) ![Screen_Shot_2016-10-07_at_13.10.16](/uploads/ad08785f407d8ac3fe9cb078868a7839/Screen_Shot_2016-10-07_at_13.10.16.png) ## What are the relevant issue numbers? Closes #21219 See merge request !6690
2016-10-26Escape quotes in gl_dropdown values to prevent exceptionsAirat Shigapov
2016-10-26disable ESLint for all JavaScript fileswinniehell
2016-10-19Merge branch 'master' into issue-board-sidebarPhil Hughes
2016-10-14Fixed undefined keycode build errorPhil Hughes
2016-10-14Fixed keycode undefinedPhil Hughes
2016-10-14Changed trigger keyup to inputPhil Hughes
2016-10-14Fixed appending jQuery elementsPhil Hughes
2016-10-14Fixed rendering of HTML stringsPhil Hughes
2016-10-14Increased performance of GL dropdown renderItemPhil Hughes
- Fixes an issue where `renderItem` is called several times even when not required - Increased performance when rendering dropdown items Closes #21110
2016-10-10Prevent conflict b/w search field and its dropdownBrennan Roberts
Stop the global search form's default "action" from fighting with dropdown items when using the keyboard to navigate the dropdown. `e.preventDefault()` is now called on the enter key when a dropdown item is already selected. Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-07Fixed sidebar dropdowns to work with VuePhil Hughes
2016-10-04Add position menu above ability to glDropdown.Fatih Acet
2016-09-21Added checks for field before field.length and removed unneeded fieldNameLuke Bennett
2016-09-19Merge branch 'master' into ↵Luke "Jared" Bennett
'21961-issues-filtering-issue-with-labels-that-contain-spaces' # Conflicts: # app/assets/javascripts/gl_dropdown.js
2016-09-16Merge branch 'ee-919-backport-changes' into 'master' Jacob Schatz
Restore gl_dropdown.js changes Restores `fieldName` to allow only string values. `fieldName` was changed to accept function as a value in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/581 Since the approach changed in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/687 there's no need to accept function as value. Backport changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/687 EE Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/919 See merge request !6234
2016-09-14Replace single quotes with escaped single quotes and write spec to test ↵Luke Bennett
multiple lable selection over a page load Added spec for removing label with space and single quote Fixed removing label with single quote
2016-09-08Restore comments lost when converting CoffeeScript to JavaScriptJared Deckard
2016-09-06fieldName can’t be a functionAlfredo Sumaran
Restore changes introduced in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/581
2016-09-06Ensure we update dropdown label after selecting an optionAlfredo Sumaran