Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-02-25 | Added Stylelint Setup | Tim Zallmann | |
Added stylelint to static-analysis Updated yarn dependencies CSS Fixes and rule adoptions of stylelint Added stylelint-scss Deduplicated yarn.lock to clear dependencies First round of advanced stylelint rules Mainly Vendor prefix updates related to flex Updates to more webkit specific vendor prefixes Finished all vendor specific fixes Moved now 4 rules to warning Fixed the new scss lint problems More stylelint adaptions after rebase | |||
2018-07-25 | Replace snake case in SCSS variables | George Tsiolis | |
2018-06-05 | Resolve "Markdown blockquote is not displaying properly" | Paul Slaughter | |
2018-04-26 | [skip ci] Convert blockquote to .blockquote in css | Clement Ho | |
2017-11-03 | Enable MergeableSelector in scss-lint | Takuya Noguchi | |
2017-08-24 | Changed all font-weight values to 400 and 600 | Dimitrie Hoekstra | |
2017-06-13 | use common devise layout and use heading style | Alexis Reigel | |
2017-02-11 | Stylize blockquote in notification emails | Alfredo Sumaran | |
2016-12-13 | Finish refactoring grays | Annabel Dunstone Gray | |
2016-12-02 | Enable ColorVariable in scss-lint | Sam Rose | |
2016-11-25 | Add diff hunks to notification emails on MR | hhoopes | |
Added diff hunks to notification emails of messages on merge requests. This provides code context to the note. Uses existing template for formatting a diff for email (from repository push notifications). | |||
2016-10-24 | Enable SpaceAfterVariableColon in scss-lint | Clement Ho | |
2016-10-15 | Enforce TrailingSemicolon and EmptyLineBetweenBlocks in scss-lint | Clement Ho | |
2016-08-17 | Fix email line-height in Outlook | Sean McGivern | |
Outlook seems to handle `white-space: pre` weirdly, so just use `pre` elements (but only for emails!). | |||
2016-07-21 | Changed tr to be direct descendant | Phil Hughes | |
2016-07-20 | Fixed padding on line content | Phil Hughes | |
2016-07-13 | Changed CSS for emails to be mostly single class selectors | Phil Hughes | |
2016-07-12 | Reduced diff email CSS | Phil Hughes | |
2016-06-17 | Center the header logo for all Devise emails | Robert Speicher | |
2016-06-07 | Optimise email CSS for speed with Premailer | Sean McGivern | |
Remove all descendant selectors from the push email styling, to drastically reduce CPU time when inlining the CSS for syntax-highlighted diffs. Background: Premailer is a Ruby gem that inlines CSS styles from an external stylesheet before emails are sent, so that they are compatible with Gmail. At a high level, it parses the CSS files it finds, and parses the email body with Nokogiri. It then loops through the selectors in the CSS, using Nokogiri to find matching elements, and adds inline styles. (It does more than this, like merging styles applied to the same element, but that's not relevant to this issue.) Nokogiri converts CSS selectors to XPath first, like so: Nokogiri::CSS.xpath_for('foo bar') # => ["//foo//bar"] On documents with high node counts (say, a syntax-highlighted copy of jQuery), having both descendant selectors is very expensive. Both `//foo/bar` and `//bar` will be much more efficient, although neither are directly equivalent. An example, on a document containing two syntax-highlighted copies of jQuery: Benchmark.realtime { p doc.search('.o').count } # 9476 # => 0.3462457580026239 Benchmark.realtime { p doc.search('.code.white .o').count } # 9476 # => 85.51952634402551 The performance is similar for selectors which _don't_ match any elements, and as Premailer loops through all the available selectors, we want to avoid all descendant selectors in push emails. Because of the theming support in the web UI, all syntax highlighting selectors are descendant selectors of classes like `.code.white` or `.code.monokai`. There are over 60 CSS classes for syntax highlighting styles alone, all of which are expressed in the inefficient form above. In emails we always use the white theme, and were reusing the same CSS file. But in emails, we don't need to descend from `.code.white` as that will always be the theme, and we can also remove some other selectors that are only applicable to the web UI. For the remaining descendant selectors, we can convert them to child selectors, type selectors, or class selectors as appropriate. As in the example above, having no descendant selectors at all in the push email CSS can provide a drastic (and surprising) performance improvement. | |||
2016-05-25 | New confirmation email :fire: | Robert Speicher | |
2016-05-17 | Syntax-highlight diffs in push emails | Sean McGivern | |
Based on: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/151 |