| Age | Commit message (Collapse) | Author |
|---|
|
Change auto selection behaviour of emoji and slash commands to be more UX/Type friendly
## What does this MR do?
In the context of a special command (starting with "/", ":", ...), the MR disables auto selection of first item in the dropdown suggestion menu, until at least a character has been typed.
This behavior change originated from #22058 and #23578 in which problems with the ":" special command were pointed out.
## Are there points in the code the reviewer needs to double check?
At lines +187 and +242 there were originally no sorters. Given what ``DefaultOptions.sorter`` does, I don't think it is a problem.
## Why was this MR needed?
To solve #22058 and #23578
## Does this MR meet the acceptance criteria?
- [X] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [X] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22058 and #23578
See merge request !7129
|
|
Remove an extra leading space from diff paste data
## What does this MR do?
Remove an extra leading space from diff paste data.
## Are there points in the code the reviewer needs to double check?
I have checked the following three patterns.
* inline diff
* parallel diff
* blob preview
## Why was this MR needed?
Diff paste data contain an extra leading space.
So it need to remove an extra leading space manually from pasted diff data.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#14176
Closes #23899
See merge request !7133
|
|
24146 Add focus state to buttons and dropdowns
## What does this MR do?
Adds focus state to buttons and dropdowns
## Are there points in the code the reviewer needs to double check?
All focus states of buttons and dropdowns :)
## Why was this MR needed?
Improve accessibility
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24146
See merge request !7347
|
|
Improved build page scroll UX
## What does this MR do?
This MR smoothes the UX of the builds page by more effectively affixing the scroll step buttons.
It also ensures the scroll step buttons are always in view, even if the sidemenu is open.
It also moves the autoscroll button into the same container as the scroll buttons.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
The build scroll buttons are always in unpredictable places and are often hidden behind sidemenus.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Contributes #21832
See merge request !6270
|
|
Replace jQuery.timeago with timeago.js
## What does this MR do?
Replaces jQuery.timeago with [timeago.js](https://github.com/hustcc/timeago.js)
## Are there points in the code the reviewer needs to double check?
* Check to make sure its working everywhere :smile:
* Check to make sure the timeago wording matches what we have now (I think I've got this down but an extra pair of :eyes: would help too)
## Why was this MR needed?
* The jQuery.timeago version we have is outdated
* timeago.js is smaller (7.19 KB => 4.52 KB)
* timeago.js has no jQuery dependency
* removes all inline javascript :crossed_swords: for timeago
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21793
See merge request !6274
|
|
|
|
Use separate email-friendly token for incoming email
See merge request !5914
|
|
into 'master'
Network page appear with an error message when entering nonexistent git revision
Closes #2362
See merge request !7172
|
|
|
|
|
|
reactivates all tests and writes more tests for it
|
|
|
|
|
|
Update avatar container name so it doesnt conflict with other image containers
Bug from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7206 renders all wiki images circular
Before:
After:
cc @tauriedavis @dzaporozhets
See merge request !7268
|
|
Added Element extension with .matches and .closest
## What does this MR do?
This adds `.matches` and `.closest` polyfills that will help when removing/not using jQuery. I added these in another MR which was then refactored to not require these methods, but I thought we might as well not lose the code.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Help when removing/not using jQuery.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
See merge request !6946
|
|
Creates new list from a new label
## What does this MR do?
After creating a new label in the new list dropdown it automatically creates a new list.
## Screenshots (if relevant)
## What are the relevant issue numbers?
Closes #23026
See merge request !6744
|
|
Added various stylistic changes to commit title area
## What does this MR do?
After https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6994 was merged, there were some things left over.
## Are there points in the code the reviewer needs to double check?
Yes, in general the code.
Apart from that I couldn't get the extended commit sha to lign up correctly on smaller screens
## Why was this MR needed?
Some things weren't done yet.
- Commit description and commit sha are now bold like in the original design, and are also both visible on smaller screens
- You can now extend the commit sha on bigger screens and keep it visible truncated on smaller screens.
- options dropdown button now correctly displays on smaller screens (similar to issue/mr view)
## Screenshots (if relevant)
Before:
After:
not aligned correctly:
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
!6994
See merge request !7213
|
|
Move comments to the correct location
Remove array extension usage
Move build options to fixture to match view
|
|
Tidied up UX
Corrected naming convention issues with removing inline JS
@deckar01 saves the day! Simplified `toggleSidebar` and `hideSidebar`
Review changes
Merge conflicts and update autoscroll button
|
|
Fix: Todos Filter Shows All Users
Closes #22588
See merge request !7258
|
|
|
|
|
|
|
|
Backport Group API code that was added in EE only
Group API code that was added in EE only. /cc @vsizov
See merge request !7205
|
|
|
|
Updated styling commit SHA on branches page
## What does this MR do?
Updated styling of commit SHA on the branches page to include the commit icon and be blue
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
to make the branches page in line with upcoming update to the commit list, which also styles the commit sha, but slightly different.
## Screenshots (if relevant)
before:
after:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24022
See merge request !7219
|
|
Closes #23026
|
|
|
|
|
|
first/last child selectors
|
|
|
|
Moved most of the functions that contained "window.doSomething" that were located at:
- app/assets/javascripts/application.js
To the following file:
- app/assets/javascripts/lib/utils/common_utils.js
The functions listed here:
- window.ajaxGet
- window.split
- window.extractLast
- window.rstrip
- window.disableButtonIfEmptyField
- window.disableButtonIfAnyEmptyField
- window.sanitize
- window.unbindEvents
- window.shiftWindow
Now will be accessible from the "gl.utils" namespace
|
|
eslint: Fix invalid filename validation
Attempt to fix the following error which is appearing in every new MR since `eslint-plugin-filenames` was introduced.
```
/builds/gitlab-org/gitlab-ce/app/assets/javascripts/gl_field_error.js.es6
2:1 error Filename 'gl_field_error.js.es6' does not match the naming convention filenames/match-regex
```
This was happening because our ES6 files have the following structure `gl_hello_world.js.es6`. So `eslint-plugin-filenames` was considering as base name `gl_hello_world.js` which didn't pass the previous regex `^[a-z_]+$`
This new regex allows the following filenames to pass as valid:
- `gl_hello_world.js.es6` which base name translates to `gl_hello_world.js`
- `gl_foo_bar.js` which base name translates to `gl_foo_bar`
- `d3.js` which base name translates to `d3` (especial case, maybe we should move this to the vendor dir and make the regex more specific)
See merge request !7281
|
|
|
|
Add new icon for skipped builds; show created state in mini graph
Closes #22914
See merge request !7276
|
|
Hides registry if project repository is disabled
## What does this MR do?
When disabling the projects repository it now hides the container registry as well.
## Screenshots (if relevant)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/19734#note_17224181
See merge request !7036
|
|
Unify dropdown button styles
Unifies dropdown styles across app (use one shade of gray for border, always use caret instead of chevron)
Before:
After:
Should affect _all_ dropdowns
See merge request !7250
|
|
|
|
Remove underline focus state on statuses
Before:
After:
See merge request !7244
|
|
|
|
|
|
Adds JavaScript validation for group path editing
## What does this MR do?
- Prevents group_edit form submission when special characters are included in the new group name
- Enhances gl_field_errors to support this use case and be more re-usable.
## Are there points in the code the reviewer needs to double check?
**The implementation of validation is here: https://gitlab.com/gitlab-org/gitlab-ce/commit/73d997046cac376ccdbcaac6f183002bc19b9a1f**
The rest of the diff for this MR is augmenting gl_field_errors
## Why was this MR needed?
- Currently we allow submission and a 500 error is returned.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922
See merge request !7041
|
|
|
|
|
|
|
|
Updated Sortable JS plugin
## What does this MR do?
Updates Sortable JS plugin for issue boards. The older version stopped the issue cards being draggable.
## What are the relevant issue numbers?
Closes #23048
See merge request !6734
|
|
Removed z-index for filters on issue boards
## What does this MR do?
I dont know how this is has only just become a problem, but when the sidebar is open the filters on issue boards overlap it.
## Screenshots (if relevant)
### Before
### After
See merge request !7235
|
|
|
|
|
|
|
