Age | Commit message (Collapse) | Author |
|
environment related actions
|
|
|
|
|
|
Update wrong initial setting transfer in application_settings_controller.rb
See merge request gitlab-org/gitlab-ce!20059
|
|
Set flash error message only for current request when updating project
Closes #43772
See merge request gitlab-org/gitlab-ce!20126
|
|
|
|
|
|
|
|
|
|
|
|
into 'master'
[Rails5] Force the `protect_from_forgery` callback run first
Closes #48204
See merge request gitlab-org/gitlab-ce!20055
|
|
This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP
header.
|
|
|
|
into 'master'
[Rails5] Set request.format in commits_controller
Closes #48144 et #48143
See merge request gitlab-org/gitlab-ce!20023
|
|
Since Rails 5.0 the `protect_from_forgery` callback doesn't run first by
default anymore. [1]
Instead it gets inserted into callbacks chain where callbacks get
called in order.
This commit forces the callback to run first.
[1]: https://github.com/rails/rails/commit/39794037817703575c35a75f1961b01b83791191
|
|
|
|
Rails5 fix Admin::HooksController
Closes #48142
See merge request gitlab-org/gitlab-ce!20017
|
|
Resolve "Set the language setting to something other than English, the branch of Merge Request will not be visible."
Closes #48100
See merge request gitlab-org/gitlab-ce!20016
|
|
Since Rails 5.0 `request.format` is being set depending on the route extension.
In commits pages we pass a ref as a URL parameter.
If the ref is an extension-like, Rails converts it and sets to
`request.format`.
E.g. if the ref is `some_branch.atom`, Rails starts responding with
`atom` format, but it should response with `html` because `.atom` is the
part of ref name, not the format.
This commit explicitly sets `request.format` to `:html` when needed.
|
|
arguments: DashboardController
|
|
|
|
|
|
Counting commits is done by Gitaly
Closes gitaly#382
See merge request gitlab-org/gitlab-ce!19983
|
|
Closes https://gitlab.com/gitlab-org/gitaly/issues/382
|
|
Rails5 fix format in uploads actions
Closes #46276
See merge request gitlab-org/gitlab-ce!19907
|
|
|
|
Render calendar feed inline when accessed from GitLab
Closes #47672
See merge request gitlab-org/gitlab-ce!19698
|
|
'blackst0ne-rails5-expected-the-response-to-have-status-code-ok-but-it-was-404' into 'master'
Resolve "[Rails5] expected the response to have status code :ok but it was 404"
Closes #48008
See merge request gitlab-org/gitlab-ce!19937
|
|
[Rails5] Explicitly set request.format for blob_controller
Closes #47921
See merge request gitlab-org/gitlab-ce!19876
|
|
With text/calendar as Content-Type, the browser always downloads the
content as a file (even ignoring the Content-Disposition header). We
want to display the content inline when accessed from GitLab, similarly
to the RSS feed.
|
|
Resolve "Milestone not updating in MR sidebar after selection"
Closes #47933
See merge request gitlab-org/gitlab-ce!19870
|
|
Since Rails 5 request.format gets set by extension if it's not explicitly
set.
That means artifacts_controller#file no longer works as expected.
This commit explicitly sets request.format for artifacts_controller#file.
|
|
|
|
Rails5 fix passing Group objects array into for_projects_and_groups milestone scope
Closes #47836
See merge request gitlab-org/gitlab-ce!19863
|
|
IDE sends last commit ID when committing changes
Closes #46192
See merge request gitlab-org/gitlab-ce!19552
|
|
[CE backport] Backport InternalRedirect#sanitize_redirect
See merge request gitlab-org/gitlab-ce!19795
|
|
|
|
Closes #46192
|
|
|
|
In Rails 4.2 if params[:format] is empty, Rails set it to :html
But since Rails 5.0 the framework now looks for an extension.
E.g. for `blob/master/CHANGELOG.md` in Rails 4 the format would be
`:html`, but in Rails 5 on it'd be `:md`
This commit explicitly sets the `:html` format for all requests unless
`:format` is set by a client e.g. by JS for XHR requests.
|
|
|
|
html_render=false
|
|
milestone scope
|
|
|
|
The `errors/access_denied` page should not fail to render when no
message is provided.
When accessing something as a sessionless user, we should also display
the terms message if possible.
|
|
When a user checks the `accept` checkbox, we will track that
acceptance as usual. That way they don't need to accept again after
they complete the registration.
When an unauthenticated user visits the `/-/users/terms` page, there
is no button to accept, decline or continue. The 'current-user menu'
is also hidden from the top bar.
|
|
|
|
Resolve "Timeout searching group issues"
Closes #46648
See merge request gitlab-org/gitlab-ce!19429
|
|
38542-application-control-panel-in-settings-page
|
|
Customizable favicon
Closes #15661
See merge request gitlab-org/gitlab-ce!14497
|