| Age | Commit message (Collapse) | Author |
|---|
|
Fix specifying a non-default ref when requesting an archive using the legacy URL
Closes #45507
See merge request gitlab-org/gitlab-ce!18468
|
|
|
|
|
|
|
|
[Rails5] Add `safe_params` helper
See merge request gitlab-org/gitlab-ce!18241
|
|
|
|
Embedded Snippets Support
Closes #8088
See merge request gitlab-org/gitlab-ce!15695
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
If form does not have import sources checkboxes we should not reset
import sources to empty. This fixes issue when import sources got reset
after user modifies unrelated settings section like GitLab pages
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Make archived projects completely read-only
Closes #44788
See merge request gitlab-org/gitlab-ce!18136
|
|
Optimise rendering of Markdown documents that belong to different projects
See merge request gitlab-org/gitlab-ce!18157
|
|
|
|
This refactors the Markdown pipeline so it supports the rendering of
multiple documents that may belong to different projects. An example of
where this happens is when displaying the event feed of a group. In this
case we retrieve events for all projects in the group. Previously we
would group events per project and render these chunks separately, but
this would result in many SQL queries being executed. By extending the
Markdown pipeline to support this out of the box we can drastically
reduce the number of SQL queries.
To achieve this we introduce a new object to the pipeline:
Banzai::RenderContext. This object simply wraps two other objects: an
optional Project instance, and an optional User instance. On its own
this wouldn't be very helpful, but a RenderContext can also be used to
associate HTML documents with specific Project instances. This work is
done in Banzai::ObjectRenderer and allows us to reuse as many queries
(and results) as possible.
|
|
This could only be possible for users that can create merge requests
within a project.
So they need to be a allowed to create a branch and create a merge request.
|
|
|
|
So we can distinguish between the permissions on the source and the
target project.
- `create_merge_request_from` indicates a user can create a merge
request with the project as a source_project
- `create_merge_request_in` indicates a user can create a merge
request with the project as a target_project
|
|
This prevents creating merge requests targeting archived projects.
This could happen when a project was already forked, but then the
source was archived.
|
|
The `RAILS5=1 rspec spec/controllers/admin/application_settings_controller_spec.rb`
command throws the error:
Failures:
1) Admin::ApplicationSettingsController PUT #update falls back to defaults when settings are omitted
Failure/Error: import_sources = params[:application_setting][:import_sources]
NoMethodError:
undefined method `[]' for nil:NilClass
# ./app/controllers/admin/application_settings_controller.rb:62:in `application_setting_params'
This commit fixes it.
|
|
Handle legacy repository archive requests with no ref given
Closes #45154
See merge request gitlab-org/gitlab-ce!18246
|
|
The legacy endpoint requires no reference and defaults to the root
ref.
Closes #45154
|
|
|
|
Rails 5.0 requires to explicitly permit attributes when building a URL
using current `params` object.
The `safe_params` helper allows developers to just call `safe_params.merge(...)`
instead of manually adding `permit` to every call.
https://github.com/rails/rails/pull/20868
|
|
The TIMESTAMP data type is used for values that contain both date and
time parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to
'2038-01-19 03:14:07' UTC.
A Forever lib class was included to handle future dates for PostgreSQL
and MySQL, also changes were made to DeployToken to enforce Forever.date
Also removes extra conditional from JwtController
|
|
|
|
- Adds a default on expires_at datetime
- Modifies deploy tokens views to handle default expires at value
- Use datetime_with_timezone where possible
- Remove unused scopes
|
|
|
|
We use controller actions to pass a newly created token and errors
|
|
Also:
- Changes scopes from serializer to use boolean columns
- Fixes broken specs
|
|
- Remove extra method for authorize_admin_project
- Ensure project presence
- Rename 'read_repo' to 'read_repository' to be more verbose
|
|
- When using 'read_repo' password and project are sent, so we used both
of them to fetch for the token
- When using 'read_registry' only the password is sent, so we only use
that for fetching the token
|
|
|
|
- Keep 'Deploy Section' open upon save, otherwise the token might get
lost
- When an error appears, display the error inside the form and also keep
the Deploy Section open
- Changue copy of revoke modal
|
|
Includes:
- Model, factories, create service and controller actions
- As usual, includes specs for everything
- Builds UI (copy from PAT)
- Add revoke action
Closes #31591
|
|
Add alternative archive route
Closes #38830
See merge request gitlab-org/gitlab-ce!17225
|
|
'blackst0ne-rails5-update-skip-before-action-in-authenticates-with-two-factor-concern' into 'master'
[Rails5] Add `raise: false` to skip_before_action in authenticates_with_two_factor.rb
See merge request gitlab-org/gitlab-ce!18221
|
|
Resolve "Show a message when loading the issues / merge requests dashboard without filters"
Closes #43246
See merge request gitlab-org/gitlab-ce!17961
|
|
Repository archives are always named `<project>-<ref>-<sha>` even if
the ref is a commit. A consequence of always including the sha even
for tags is that packaging a release is more difficult because both
the ref and sha must be known by the packager.
- add `<project>/-/archive/<ref>/<filename>.<format>` route using the
`-` separator to prevent namespace collisions. If the filename is
`<project>-<ref>` or the ref is a sha, the sha will be omitted,
otherwise the default filename will be used.
- deprecate previous archive route `repository/<ref>/archive`
|
|
authenticates_with_two_factor.rb
Rails 5.0 raises `ArgumentErrror` if an unrecognised callback is skipped.
https://github.com/rails/rails/commit/8b88df94ebda2e829782f514ff51caeaf5e694dd
This commit adds `raise: false` to the filter.
|
|
|
|
Show issues of subgroups in group-level issue board
Closes #44270
See merge request gitlab-org/gitlab-ce!18187
|
|
|
|
Direct upload of artifacts
See merge request gitlab-org/gitlab-ce!18160
|
|
Resolve "Allow HTTPS cloning by Runners if it is disabled for users"
Closes #44389
See merge request gitlab-org/gitlab-ce!18021
|
|
Fix `JobsController#raw` endpoint can not read traces in database
Closes #44665
See merge request gitlab-org/gitlab-ce!18101
|
|
|
|
Adjust 404's for LegacyDiffNote discussion rendering
Closes #44295
See merge request gitlab-org/gitlab-ce!18201
|
|
|
|
|
|
'master'
Use chronic duration attribute for project build timeout
See merge request gitlab-org/gitlab-ce!17386
|
|
|
