We want to drop the generic #avatar_icon helper that supports both an email
and a user object being passed in. Instead, we want to explicitly use the #avatar_icon_for_user
and #avatar_icon_for_email helpers depending on what we have at hand.
This allows us to avoid unnecessary database queries (e.g. call
User.find_by_any_email if we already have the user).
In situations like here, this makes it less convenient to use.
Resolve "Format branch, tag, and commit in environment list"
## What does this MR do?
Updates Environments page rows to match the new pipeline updates
## Are there points in the code the reviewer needs to double check?
I removed `private` from `avatars_helper.rb` so I could use `user_avatar`.
## What are the relevant issue numbers?
Closes #20059
## Screenshots (if relevant)
See merge request !5687
