Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-07-11 | Banzai - avoid redis if attr is in DB cache | Mario de la Ossa | |
When cache_collection_render runs we end up reading and writing things to redis even if we already have the rendered field cached in the DB. This commit avoids using redis at all whenever we have the field already rendered in the DB cache. | |||
2018-11-12 | Turn reference regex constants into methods | Yorick Peterse | |
`Mentionable::ReferenceRegexes` used to define the following two constants: 1. DEFAULT_PATTERN 2. EXTERNAL_PATTERN These two constants were built using some of the class methods that reside in this same module. In EE we redefine one of these methods by using `prepend` at the start of the `ReferenceRegexes` module. This poses a problem: we can not move the `prepend` to the end of the file, because the constants later on depend on it. To resolve this problem, this commit turns these constants into class methods that memoize their results. This allows EE to redefine the appropriate methods before these two class methods are used, in turn allowing us to move the `prepend` to the end of the file. See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8198 for more information. | |||
2018-09-17 | Remove EE-specific code from Mentionable | Sean McGivern | |
2018-08-29 | Updates code using class_methods over module ClassMethods | Jacopo | |
2018-08-07 | Enable more frozen string in app/models/**/*.rb | gfyoung | |
Partially addresses #47424. | |||
2017-11-30 | Merge remote-tracking branch 'upstream/master' into no-ivar-in-modules | Lin Jen-Shin | |
* upstream/master: (170 commits) support ordering of project notes in notes api Redirect to an already forked project if it exists Reschedule the migration to populate fork networks Create fork networks for forks for which the source was deleted. Fix item name and namespace text overflow in Projects dropdown Minor backport from EE fix link that was linking to `html` instead of `md` Backport epic tasklist Add timeouts for Gitaly calls SSHUploadPack over Gitaly is now OptOut fix icon colors in commit list Fix star icon color/stroke Backport border inline edit Add checkboxes to automatically run AutoDevops pipeline BE for automatic pipeline when enabling Auto DevOps I am certainly weary of debugging sidekiq but I don't think that's what was meant Ensure MRs always use branch refs for comparison Fix issue comment submit button disabled on GFM paste Lock seed-fu at the correct version in Gemfile.lock Improve indexes on merge_request_diffs ... | |||
2017-11-23 | Fix link text from group context | Jarka Kadlecova | |
2017-11-17 | Use StrongMemoize and enable/disable cops properly | Lin Jen-Shin | |
2017-09-18 | Allow simple ivar ||= form. Update accordingly | Lin Jen-Shin | |
2017-09-18 | Add cop to make sure we don't use ivar in a module | Lin Jen-Shin | |
2017-08-14 | Whitelist or fix additional `Gitlab/PublicSend` cop violations | Robert Speicher | |
An upcoming update to rubocop-gitlab-security added additional violations. | |||
2017-05-11 | Fix cross referencing for private and internal projects | Jarka Kadlecova | |
2017-05-09 | Fallback to default pattern when note does not belong to project | Toon Claes | |
In commit 020295ff a regex was added to quickly determine if mentionables might be referenced. But this didn't take into account the note might not belong to a project. So when it doesn't belong to a project, assume the default issue tracker is used, and use DEFAULT_PATTERN to check if there are mentionables. Fixes gitlab-org/gitlab-ce#31993 | |||
2017-05-04 | Use regex to skip unnecessary reference processing in ProcessCommitWorker | James Edwards-Jones | |
2017-02-08 | Create directly_addressed Todos when mentioned in beginning of a line | Ershad Kunnakkadan | |
2017-01-25 | address comments | Jarka Kadlecova | |
2017-01-19 | make mentions working when project not specified | Jarka Kadlecova | |
2016-11-21 | Allow JIRA references for project snippets | Felipe Artur | |
2016-10-04 | Simplify Mentionable concern instance methods | Paco Guzman | |
We remove some arguments that are rarely used or used just to simplify setups on specs. Modified Mentionable#create_new_cross_references method we don’t need to calculate previous references to avoid the duplication because we do that at database level when creating references extracted from the current entity state. MergeRequests won’t create cross_references for commits that are included so we change a spec to use a different merge request to make references to commits to other branches | |||
2016-07-15 | Use cattr_accessor instead duplicating code on NoteOnDiff concern | Douglas Barbosa Alexandre | |
2016-06-30 | Ensure logged-out users can't see private refs | Sean McGivern | |
2016-05-26 | Refactor Mentionable | Yorick Peterse | |
Caching is now always enabled when rendering attributes as there's no reason to not cache them. The method Mentionable#all_references has also been modified to take an optional Gitlab::ReferenceExtractor instance to allow other code to create one and re-use it between multiple calls. | |||
2016-05-07 | Fix adding a todo for private group members | Ahmad Sherif | |
Fixes #14002 | |||
2016-01-06 | Fix mentionable reference extraction caching. | Douwe Maan | |
2015-12-24 | Only allow group/project members to mention `@all` | Douwe Maan | |
2015-12-16 | Only cache markdown when object has been saved and has a proper cache_key. | Douwe Maan | |
2015-12-15 | Move Markdown/reference logic from Gitlab::Markdown to Banzai | Douwe Maan | |
2015-12-07 | Merge branch 'master' into reference-pipeline-and-caching | Douwe Maan | |
2015-12-01 | Fix referenced_mentionables method. | Douwe Maan | |
2015-12-01 | Fix specs | Douwe Maan | |
2015-10-21 | Merge branch 'master' into reference-pipeline-and-caching | Douwe Maan | |
2015-10-15 | Merge branch 'master' into rs-redactor-filter | Douwe Maan | |
2015-10-14 | Merge branch 'master' into rs-redactor-filter | Douwe Maan | |
2015-10-14 | Cache rendered contents of issues, MRs and notes | Douwe Maan | |
2015-10-14 | Participable doesn't need to know about Mentionable | Douwe Maan | |
2015-10-14 | Make Mentionable#cross_reference_exists? private. | Douwe Maan | |
2015-10-14 | Have Issue#participants load all users mentioned in notes using a single query | Douwe Maan | |
2015-10-12 | Fix cross-references originating from notes | Douwe Maan | |
2015-10-12 | Simplify code around (cross)-references | Douwe Maan | |
2015-10-07 | Always allow references to the current project | Douwe Maan | |
2015-07-14 | Rename `notice_added_references` to `create_new_cross_references!` | Robert Speicher | |
2015-07-14 | Refactor Mentionable#notice_added_references | Robert Speicher | |
It now accounts for models that have changed but have already been persisted, such as when called from an UpdateService. Closes #1773 | |||
2015-06-22 | Replace remaining references to `Note.create_cross_reference_note` | Robert Speicher | |
2015-06-09 | Correctly remove already-mentioned commits for cross references | Robert Speicher | |
Fixes #1778 | |||
2015-05-26 | More SystemNoteService cleanup | Robert Speicher | |
2015-05-26 | Minor documentation updates | Robert Speicher | |
2015-05-26 | Implement gfm_reference directly in Mentionable | Robert Speicher | |
Except for Note, which still overrides it. | |||
2015-05-14 | Fix mentioning of private groups. | Douwe Maan | |
2015-05-11 | Add a SystemNoteService class | Robert Speicher | |
There's a lot of code in the Note model that only deals with creating system notes, so we're going to split that into its own class. | |||
2015-04-24 | Link cross-project cross-reference notes to correct project. | Douwe Maan | |