Age | Commit message (Collapse) | Author | |
---|---|---|---|
2021-05-12 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2021-03-17 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2021-02-17 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2021-02-15 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-12-07 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-01-15 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-11-12 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-09-13 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-07-26 | Prefer `flat_map` over `map` + `flatten` | Peter Leitzen | |
Convert several occurrences of `map` + `flatten` to `flat_map` where applicable. | |||
2018-08-13 | Refactor ProtectedRefMatcher to be more generic | Duana Saskia | |
2018-08-07 | Enable more frozen string in app/models/**/*.rb | gfyoung | |
Partially addresses #47424. | |||
2018-07-09 | Updates from `rubocop -a` | Lin Jen-Shin | |
2018-04-24 | Allow admins to push to empty repos | Bob Van Landuyt | |
2017-08-25 | Remove 'dependent: :destroy' from ProtectedRef has_many :"#{type}_access_levels" | James Edwards-Jones | |
2017-07-25 | Merge branch '30634-protected-pipeline' into 'master' | Kamil Trzciński | |
Implement "Block pipelines on protected branches" Closes #30634, #34616, and #33130 See merge request !11910 | |||
2017-07-25 | Explicitly define inverse of acces_level relations | Bob Van Landuyt | |
2017-07-19 | Eliminate N+1 queries on checking different protected refs | Lin Jen-Shin | |
I realized where the N+1 queries were actually coming from project.protected_branches, but how come we cannot preload this, or cache this at all? Then I found that this is somehow a Rails limitation. What we're doing before, eventually come to: project.protected_branches.matching But why it's not cached? (project.protected_branches.loaded? is always false) It's because matching is a class method, which is called on the proxy. In this case, Rails cannot cache the result. I don't know if this is possible to implement or not, because clearly this would require some tricks to implement class methods on associations. So instead, we could just pass project.protected_branches to ProtectedRef.matching, then it would work regularly. With this change, there's no more N+1 queries. | |||
2017-07-06 | Added Cop to blacklist the use of `dependent:` | Yorick Peterse | |
This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk). | |||
2017-05-31 | Backport EE refactorings for Protected Tag EE-only functionality | James Edwards-Jones | |
Improvements and refactorings were made while adding role based permissions for protected tags to EE. This doesn’t backport the feature, but should improve code quality and minimize divergence. | |||
2017-04-06 | Protected Tags backend review changes | James Edwards-Jones | |
Added changelog | |||
2017-04-04 | Fixed UserAccess#can_create_tag? after create_access_levels rename | James Edwards-Jones | |
2017-04-04 | Cleanup & tests for UserAccess#can_create_tag? | James Edwards-Jones | |
2017-04-04 | Fixed developers_can_push in RepoBranch API entity | James Edwards-Jones | |
2017-04-04 | Fix typos in ProtectedRef concern and whitespace detected by rubocop | James Edwards-Jones | |
2017-04-03 | Clean up non TODO rubocop errors | James Edwards-Jones | |
2017-04-03 | Use delegation in ProtectedRef concern | James Edwards-Jones | |
2017-04-03 | Extract ProtectedRef Concern | James Edwards-Jones | |