Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-27Enable frozen string in app/models/*.rbgfyoung
Partially addresses #47424.
2018-05-24Persist truncated note diffs on a new tableOswaldo Ferreira
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
2018-05-01Use persisted diff data instead fetching Git on discussionsOswaldo Ferreira
Today, when fetching diffs of a note, we always go to Gitaly in order to diff between commits and return the diff of each discussion note. With this change we avoid doing that for notes on the "current version" of the MR.
2017-12-22Improve performance of DiffDiscussion#truncated_diff_lines and ↵Douwe Maan
DiffNote#diff_line by removing expensive diff position calculation and comparison
2017-12-07Allow commenting on individual commits inside an MRDouwe Maan
2017-11-13Prevents position update for image diff notesFelipe Artur
2017-10-07Commenting on image diffsFelipe Artur
2017-07-06Rename ActiverecordSerialize copYorick Peterse
This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
2017-06-01Merge branch 'dm-update-discussion-diff-position' into 'master'Grzegorz Bizon
Update diff discussion position per discussion instead of per note Closes #33157 See merge request !11833
2017-05-31Update diff discussion position per discussion instead of per noteDouwe Maan
2017-05-31Added Cop to blacklist the use of serializeYorick Peterse
This Cop blacklists the use of ActiveRecord's "serialize" method, except for cases where we already use this.
2017-05-26Merge branch 'dm-diff-cleanup' into 'master'Robert Speicher
Clean up diff rendering See merge request !11390
2017-05-24Add system note with link to diff comparison when MR discussion becomes outdatedDouwe Maan
2017-05-23Pass fallback_diff_refs to Diff::File instead of using view helpersDouwe Maan
2017-05-03Allow commenting on older versions of the diff and comparisons between diff ↵Douwe Maan
versions
2017-04-08Link to outdated diff in older MR version from outdated diff discussionDouwe Maan
2017-04-06Refactor resolvability checks based on typeDouwe Maan
2017-04-05Address review commentsDouwe Maan
2017-04-05Don't use original_discussion_idDouwe Maan
2017-04-05Extract commonalities between DiffDiscussion and LegacyDiffDiscussionDouwe Maan
2017-04-05Add specsDouwe Maan
2017-04-05Add option to start a new discussion on an MRDouwe Maan
2017-02-23Enable Style/WordArrayDouwe Maan
2016-09-06Optimize discussion notes resolving and unresolvingAlejandro Rodríguez
Use `update_all` to only require one query per discussion to update the notes resolved status. Some changes had to be made to the discussion spec to accout for the fact that notes are not individually updated now
2016-08-30Move #to_discussion to NoteOnDiffSean McGivern
2016-08-20Call `set_discussion_id` again in DiffNote `before_validation` because the ↵Douwe Maan
order is important
2016-08-19Fix bug where notes weren’t shown in discussion when the code had changed ↵Douwe Maan
after creation
2016-08-19Improve performance of MR show pageDouwe Maan
2016-08-17Fix a lingering conflict.Connor Shea
2016-08-17Merge branch 'master' into diff-line-comment-vuejsConnor Shea
2016-08-17Store discussion_id on Note for faster discussion lookup.Douwe Maan
2016-08-16Address review feedbackDouwe Maan
2016-08-12Don't allow resolving invalid conflictsSean McGivern
An MR can only be resolved in the UI if: - It has conflicts. - It has valid diff_refs (in other words, it supports new diff notes). - It has no conflicts with one side missing. - It has no conflicts in binary files. - It has no conflicts in files too large to display. - It has no conflicts containing invalid conflict markers.
2016-08-12Add specs for new Note and DiffNote methods.Douwe Maan
2016-08-04Merge branch 'master' into diff-line-comment-vuejsDouwe Maan
# Conflicts: # app/models/discussion.rb # db/schema.rb
2016-08-02Speedup DiffNote#active? on discussions, preloading noteables and avoid ↵Paco Guzman
touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha.
2016-07-29Backend tweaksDouwe Maan
2016-07-26Use sha1 of discussion ID.Douwe Maan
2016-07-26Add methods to resolve diff notes and discussionsDouwe Maan
2016-07-26Add resolved_at and resolved_by_id to DiffNoteDouwe Maan
2016-07-07Make `DiffNote#update_position` privateDouwe Maan
2016-07-07Keep around DiffNote position commitsDouwe Maan
2016-07-07Automatically update diff note positions when MR is pushed toDouwe Maan
2016-07-07Support new diff notes on MRs with diff_refsDouwe Maan
2016-07-07Add DiffNote modelDouwe Maan