Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-15Revert "Merge branch ↵Rubén Dávila
'rd-43185-revert-sanitize-extra-blank-spaces-used-when-uploading-a-ssh-key' into 'master'" This reverts commit e607fd796657afd214b8f25201919d3e33b3f35f.
2018-02-12Revert "Merge branch ↵Rubén Dávila
'rd-40552-gitlab-should-check-if-keys-are-valid-before-saving' into 'master'" This reverts commit a58f8c32c62bcf5824d1fe1d0de53e9bda974d65, reversing changes made to cd5d75c362cdf06efb8174eddfbd0f4b65687dec.
2018-02-02Merge branch 'rd-40552-gitlab-should-check-if-keys-are-valid-before-saving' ↵Douwe Maan
into 'master' Sanitize extra blank spaces used when uploading a SSH key Closes #40552 See merge request gitlab-org/gitlab-ce!16821
2018-02-02use Gitlab::UserSettings directly as a singleton instead of ↵Mario de la Ossa
including/extending it
2018-02-02Sanitize extra blank spaces used when uploading a SSH keyRubén Dávila
2017-12-05Consistently schedule Sidekiq jobsDouwe Maan
2017-11-16Cache the number of user SSH keysYorick Peterse
By caching the number of personal SSH keys we reduce the number of queries necessary on pages such as ProjectsController#show (which can end up querying this data multiple times). The cache is refreshed/flushed whenever an SSH key is added, removed, or when a user is removed.
2017-10-03Ensure key fingerprints are generated correctly when modifiedNick Thomas
2017-09-20Stop using Sidekiq for updating Key#last_used_atYorick Peterse
This makes things simpler as no scheduling is involved. Further we remove the need for running a SELECT + UPDATE just to get the key and update it, whereas we only need an UPDATE when setting last_used_at directly in a request. The added service class takes care of updating Key#last_used_at without using Sidekiq. Further it makes sure we only try to obtain a Redis lease if we're confident that we actually need to do so, instead of always obtaining it. We also make sure to _only_ update last_used_at instead of also updating updated_at. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
2017-09-15created services for keyshaseeb
2017-08-30Address review commentsNick Thomas
2017-08-30Rework the permissions model for SSH key restrictionsNick Thomas
`allowed_key_types` is removed and the `minimum_<type>_bits` fields are renamed to `<tech>_key_restriction`. A special sentinel value (`-1`) signifies that the key type is disabled. This also feeds through to the UI - checkboxes per key type are out, inline selection of "forbidden" and "allowed" (i.e., no restrictions) are in. As with the previous model, unknown key types are disallowed, even if the underlying ssh daemon happens to support them. The defaults have also been changed from the lowest known bit size to "no restriction". So if someone does happen to have a 768-bit RSA key, it will continue to work on upgrade, at least until the administrator restricts them.
2017-08-30Add settings for minimum key strength and allowed key typeNick Thomas
This is an amalgamation of: * Cory Hinshaw: Initial implementation !5552 * Rémy Coutable: Updates !9350 * Nick Thomas: Resolve conflicts and add ED25519 support !13712
2017-08-03fix #35133 strip new lines from ssh keyshaseeb
2017-06-02Don’t schedule workers from inside transactionsDouwe Maan
2017-05-10Enable the Style/TrailingCommaInArguments copRémy Coutable
Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-20Record used SSH keys only once per dayAdam Niedzielski
Use Gitlab::ExclusiveLease to make sure that we enqueue Sidekiq job at most once per day for given key.
2017-01-08Record and show last used date of SSH KeysVincent Wong
Addresses: Issue #13810 1. Adds a last_used_at attribute to the Key table/model 2. Update a key's last_used_at whenever it gets used 3. Display how long ago an ssh key was last used
2016-12-12Merge CSSFilipa Lacerda
2016-12-06Use :maximum instead of :within for length validators with a 0..N rangeRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-11-17Don't notify user for deploy keys, feedback:Lin Jen-Shin
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7383#note_18517263
2016-11-15Use setter for key instead AR callbackSemyon Pupkov
ref: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6763
2016-08-02Add simple identifier to public SSH keysKeith Pope
2016-06-20Remove Duplicated keys add UNIQUE index to fingerprintPaco Guzman
2016-06-01Add leading comment space copFelipe Artur
2016-05-09Remove the annotate gem and delete old annotationsJeroen van Baarsen
In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
2016-05-06Annotate the modelsZeger-Jan van de Weg
2016-03-15Ensure "new SSH key" email do not ends up as dead Sidekiq jobsRémy Coutable
Related to #2235. This is done by: 1. Delaying the notification sending after the SSH key is commited in DB 2. Gracefully exit the mailer method if the record cannot be found
2015-08-04Only publish ssh key-type and keyZeger-Jan van de Weg
2015-07-11Add error message for SSH key linebreaksNikita Verkhovin
2015-05-03Re-annotate modelsStan Hu
2015-04-14Refactor key fingerprint generation.Douwe Maan
2015-03-24The new fingerprint format wis incompatible with the previous regex.Sašo Stanovnik
2015-03-24Use 2 spaces for indentation, not 4.Sašo Stanovnik
2015-03-24Fixed generating SSH key fingerprints in OpenSSH 6.8.Sašo Stanovnik
2015-02-06Explicitly define ordering in models using default_scopeDmitriy Zaporozhets
2015-01-18Fix various typosSteven Burgart
signe-in -> signed-in go_to_gihub_for_permissions -> go_to_github_for_permissions descendand -> descendant behavour -> behaviour recepient_email -> recipient_email generate_fingerpint -> generate_fingerprint dependes -> depends Cant't -> Can't wisit -> visit notifcation -> notification sufficent_scope -> sufficient_scope? levet -> level
2014-12-28Simplify SSH fingerprint regexp extractionCiro Santilli
[\d\h] is the same as \h
2014-09-03Add system hook for ssh key changesLukas Erlacher
Add system hook for ssh key create and destroy Update and fix documentation Update tests
2014-06-26Key strong paramsDmitriy Zaporozhets
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-04-09Re-annotate modelsDmitriy Zaporozhets
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-04-02Remove KeysObserverDmitriy Zaporozhets
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-02-25Adapt use of Gitlab::Popen to new styleJacob Vosmaer
2013-08-21ReannotateDmitriy Zaporozhets
2013-07-17Validate fingerprint uniquenessJacob Vosmaer
2013-07-17Use Tempfile.open for automatic cleanupJacob Vosmaer
2013-07-12Merge branch 'master' into 6-0-devDmitriy Zaporozhets
2013-07-11Allow ecdsa SSH keysAkiva Levy
Update app/models/key.rb to permit SSH keys of type ecdsa rather than forcing dsa and rsa algorithms.
2013-06-24store and display public key fingerprintDmitriy Zaporozhets
2013-06-19AnnotatedDmitriy Zaporozhets