Age | Commit message (Collapse) | Author |
|
Get GITLAB_FEATURES from Project#licensed_features instead of Namespace#features (#5320)
See merge request gitlab-org/gitlab-ce!18189
|
|
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
|
|
|
|
Goldiloader is great, but has several issues with has_many :through relations:
* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18
Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
|
|
Goldiloader (https://github.com/salsify/goldiloader) can eager load
associations automatically. This removes the need for adding "includes"
calls in a variety of different places. This also comes with the added
benefit of not having to eager load data if it's not used.
|
|
Namespace#features (#5320)
|
|
Also:
- Changes scopes from serializer to use boolean columns
- Fixes broken specs
|
|
Includes:
- Model, factories, create service and controller actions
- As usual, includes specs for everything
- Builds UI (copy from PAT)
- Add revoke action
Closes #31591
|
|
|
|
Allow passing params to import API to override project attributes
Closes gitlab-ee#4788
See merge request gitlab-org/gitlab-ce!18086
|
|
Since we can regenerate `description_html` from the `description`, we
should not export it. This avoids some complexity when overriding the
description during an import/export where we would need to invalidate
this cached field.
Now we refresh the markdown cache after the import
|
|
'master'
Use chronic duration attribute for project build timeout
See merge request gitlab-org/gitlab-ce!17386
|
|
This makes accessing LFS Objects for a project easier
project.lfs_storage_project.lfs_objects`
becomes
project.all_lfs_objects
This will make the refactor in
https://gitlab.com/gitlab-org/gitlab-ce/issues/39769 easier to deal
with.
|
|
|
|
This means import data doesn't necessarily have to have an import_url
anymore.
The `ProjectImportData` could just contain the override data in it's
serialized data attribute.
The import data is automatically cleaned up after it is finished by
the state machine.
|
|
|
|
into 'master'
Use shard name in Git::GitlabProjects instead of shard path
Closes gitaly#1110
See merge request gitlab-org/gitlab-ce!18015
|
|
|
|
Closes gitaly#1110
|
|
|
|
|
|
HTTPS only Pages
Closes #28857
See merge request gitlab-org/gitlab-ce!16273
|
|
Route path lookups through legacy_disk_path
See merge request gitlab-org/gitlab-ce!17743
|
|
Closes #28857
|
|
|
|
Server Side Request Forgery in Services and Web Hooks
See merge request gitlab/gitlabhq!2337
|
|
Atomic generation of internal ids for issues.
Closes #31114
See merge request gitlab-org/gitlab-ce!17580
|
|
Clarify ambiguous with_artifacts implication
Closes #44138
See merge request gitlab-org/gitlab-ce!17720
|
|
and fixes the project description not being imported
|
|
|
|
Introduce CI/CD variables collection
Closes #33042
See merge request gitlab-org/gitlab-ce!14439
|
|
|
|
|
|
|
|
This commit backports method signatures and related implementation to
the CE, to make CE and EE identical. This does not add any features from
EE, it is only aimed to reduce conflicts between CE and EE in the
future.
|
|
* master: (211 commits)
|
|
Prior to this change, this method was called add_namespace, which broke
the CRUD convention and made it harder to grep for what I was looking
for. Given the change was a find and replace kind of fix, this was
changed without opening an issue and on another feature branch.
If more dynamic calls are made to add_namespace, these could've been
missed which might lead to incorrect bahaviour. However, going through
the commit log it seems thats not the case.
|
|
|
|
|
|
|
|
We only allow users that can merge the merge request to push to the
fork.
|
|
The query becomes a lot simpler if we can check the branch name as
well instead of having to load all branch names.
|
|
When an MR is created using `allow_maintainer_to_push`, we enable some
abilities while the MR is open.
This should allow every user with developer abilities on the target
project, to push to the source project.
|
|
# Conflicts:
# app/models/group.rb
# db/schema.rb
|
|
Fix project dashboard showing the wrong timestamps
Closes #27181
See merge request gitlab-org/gitlab-ce!17504
|
|
Resolve "API endpoint for exporting project"
Closes #29130
See merge request gitlab-org/gitlab-ce!15860
|
|
Use the max of the `last_activity_at` and `last_repository_updated_at`
columns. The latter is updated only when a push happens, but the former is
updated whenever any activity (e.g. issue creation) happens.
Closes #27181
|
|
|
|
|
|
|