| Age | Commit message (Collapse) | Author |
|---|
|
Fix errors on pushing/editing files on empty repositories
Closes #44618 and #42583
See merge request gitlab-org/gitlab-ce!18462
|
|
|
|
Introduce new ProjectCiCdSettings model with group_runners_enabled
See merge request gitlab-org/gitlab-ce!18144
|
|
Expose Deploy Token info as environment variables to CI/CD jobs
Closes #44447
See merge request gitlab-org/gitlab-ce!18414
|
|
|
|
|
|
|
|
Prior to this change, Flowdock used Grit to get the difference between
commits and post that to the remote service. This required direct path
access, which doesn't work with Gitaly.
Fixes gitlab-org/gitaly#1113
|
|
Also include a class method for retriving the gitlab_deploy_token on
DeployTokens
|
|
|
|
Also:
- Includes more specs
- Improves a bit the documentation
|
|
- If a deploy token with a name 'gitlab-deploy-token' is exists for the
project, CI_DEPLOY_USER and CI_DEPLOY_PASSWORD variables will be
expose
|
|
|
|
Resolve "Show new branch/merge request button even if a branch / merge request already exists"
Closes #42803
See merge request gitlab-org/gitlab-ce!17712
|
|
|
|
Fix N+1 queries when loading participants for a commit note
Closes #45526
See merge request gitlab-org/gitlab-ce!18471
|
|
[Rails5] Fix `User#manageable_groups`
See merge request gitlab-org/gitlab-ce!18330
|
|
|
|
|
|
|
|
Old records have a null value of file_store column.
This causes the problems with current direct_upload implementation,
as this makes it to choose Store::REMOTE instead of Store::LOCAL.
This change moves the store save when change saving the object.
|
|
Resolve "Calculating total size of a project's CI artifacts"
Closes #41059
See merge request gitlab-org/gitlab-ce!17839
|
|
(#41059)
Previously we scheduled a worker to just some this but we were running
into performance issues when the build table was getting too large. So
now we've updated the code such that this column is updated immediately
and incremented/decremented by the correct amount whenever artifacts are
created or deleted.
We've also added the performance optimization that we do not update this
statistic if a project is deleted because it could result in many
updates for a project with many builds.
|
|
Get GITLAB_FEATURES from Project#licensed_features instead of Namespace#features (#5320)
See merge request gitlab-org/gitlab-ce!18189
|
|
We saw about 10,000 SQL queries for some commits in the NewNoteWorker,
which stalled the Sidekiq queue for other new notes. The notification
service took up to 8 minutes to process the commits. Avoiding this
N+1 query brings the time down significantly.
Closes #45526
|
|
In `arel 7.0` (`7.1.4` version is used for rails5) there were introduced
some changes that break our code in the `User#manageable_groups` method.
The problem is that `arel_table[:id].in(Arel::Nodes::SqlLiteral)` generates
wrong `IN ()` construction. The selection for `IN` is missing:
=> "\"namespaces\".\"id\" IN (0)"
That caused such spec errors for the `rails5` branch:
```
4) User groups with child groups #manageable_groups does not include duplicates if a membership was added for the subgroup
Failure/Error: expect(user.manageable_groups).to contain_exactly(group, subgroup)
expected collection contained: [#<Group id:232 @group29>, #<Group id:234 @group29/group30>]
actual collection contained: []
the missing elements were: [#<Group id:232 @group29>, #<Group id:234 @group29/group30>]
# ./spec/models/user_spec.rb:699:in `block (5 levels) in <top (required)>'
# ./spec/spec_helper.rb:188:in `block (2 levels) in <top (required)>'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:112:in `block in run'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `loop'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `run'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:30:in `block (2 levels) in setup'
```
This commit changes `User#manageable_groups` in the way to drop the usage of
`Arel::Nodes::SqlLiteral` and adds usage of raw SQL query.
This change should be updated when we're migrated to Rails 5.2 because arel
was fixed in `9.0.0` (which is used in Rails 5.2).
|
|
Revert the addition of goldiloader
See merge request gitlab-org/gitlab-ce!18458
|
|
Fix issues on groups group trees
Closes #42407
See merge request gitlab-org/gitlab-ce!18390
|
|
|
|
|
|
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
|
|
Ensure that cached_markdown_version is handled correctly for CommonMark
See merge request gitlab-org/gitlab-ce!18431
|
|
Email notification on issue due date
Closes #27500
See merge request gitlab-org/gitlab-ce!17985
|
|
|
|
Resolve "Concurrent requests to api/v4/jobs/request cause DB locks on ci_builds_metadata table"
Closes #45456
See merge request gitlab-org/gitlab-ce!18428
|
|
Improve jobs queuing time metric (fixed version)
Closes #45205
See merge request gitlab-org/gitlab-ce!18283
|
|
and also make sure that if a field is saved, then the existing cache version is maintained or only upgraded to the version with the same markdown engine.
|
|
|
|
Memoize Git::Repository#has_visible_content?
See merge request gitlab-org/gitlab-ce!18383
|
|
'master'
[Rails5] Fix `undefined method 'arel_table' for Ci::Group:Class` error
See merge request gitlab-org/gitlab-ce!18329
|
|
This model and the corresponding table will be used for storing settings
specific to CI/CD, starting with the "group_runners_enabled" boolean.
The model is called ProjectCiCdSetting and not ProjectCiCdSettings. The
project exporter doesn't like plural model names as it uses "classify"
which turns those into singular (so "ProjectCiCdSettings" becomes
"ProjectCiCdSetting", producing an error if said class is undefined).
The initial work in this commit was done by Dylan Griffith, with most of
the migration work being done by Yorick Peterse.
|
|
This is useful for a transition period to migrate away from
`NoninternalAtomicId`. In a situation where both the old and new code to
generate a iid value is run at the same time (for example, during a
deploy different nodes may serve both versions), this will lead to
problems regarding the correct `last_value`. That is, what we track in
`InternalId` may get out of sync with the maximum iid present for
issues.
With this change, we double-check that and correct the `last_value` with
the maximum iid found in issues if necessary.
This is subject to be removed with the 10.8 release and tracked over
here: https://gitlab.com/gitlab-org/gitlab-ce/issues/45389
Closes #45269.
|
|
|
|
Make archived projects completely read-only
Closes #44788
See merge request gitlab-org/gitlab-ce!18136
|
|
Some specs fail in rails5 branch with errors like
```
1) Group#secret_variables_for when the ref is not protected contains only the secret variables
Failure/Error: variables = Ci::GroupVariable.where(group: list_of_ids)
NoMethodError:
undefined method `arel_table' for Ci::Group:Class
```
This commit fixes it.
|
|
'master'
[CE Backport] Propagate broadcast messages to secondaries
See merge request gitlab-org/gitlab-ce!18324
|
|
|
|
In Rails 5.0 the `ActiveRecord::Inheritance::subclass_from_attributes`
method was updated.
Now it calls the `find_sti_class` method [1] which is overriden in the `Event`
model and returns needed class (`Event` vs `PushEvent`).
[1]: https://github.com/rails/rails/blob/5-0-stable/activerecord/lib/active_record/inheritance.rb#L209
This commit fixes the errors like
```
143) User#contributed_projects doesn't include IDs for unrelated projects
Failure/Error: action = attrs.with_indifferent_access[inheritance_column].to_i
NoMethodError:
undefined method `with_indifferent_access' for nil:NilClass
# ./app/models/event.rb:118:in `subclass_from_attributes'
```
which are raised on the `RAILS5=1 rspec ...` command.
|
|
This prevents performing the requests, and disables all emoji reaction buttons
|
|
|
