| Age | Commit message (Collapse) | Author |
|---|
|
Expand diff to entire file
Closes #19054
See merge request gitlab-org/gitlab-ce!24406
|
|
Update spec
|
|
Add preload
Fix
ok
Write tests
test only postgresql
ok
add more test
;
Improve wording
Add changelog
Fix
|
|
Returns all diff lines for frontend if full is true.
Turn UnfoldForm into presenter, and move controller logic to presenter.
|
|
- extends presenters to include update endpoint path
- sends path to the client on clusters clusters show view.
|
|
Fix
ok
Add spec
Fix
ok
Fix
Add changelog
Fix
Add memoization
a
fix
|
|
|
|
fix
fix and fix
Allow full ref specification for pipeline creation
Add spec
Support backward compatibility
Use ref path
Runner feature flag
Simplify the things
Support fork workflow (Public only)
Expose ref spec
Use refspec
Glooming
Decouple unrelated changes
Add changelog
Revert unrelated file
Decouple unnecessary
Add spec
Use refspecs
Fix changelog
Simplify
Fix coding offence
Fix
a
ok
ok
ok
ok
ok
a
a
Fix
Add workaround for ignore_column
Fix git depth
Fix coding offence
Fix spec
Simplify more
Do not set ignored column
Fix tests
Fix pipeline
Fix spec
fix fixture yes
Revert nonsense
fix
Revert more
ok
Decouple mr pipelines
fix spev
Remove unrelated changes
|
|
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
|
|
|
|
|
Resolve "Rename project tags to project topics"
Closes #54167
See merge request gitlab-org/gitlab-ce!24219
|
|
- Rename CSS class
- Fix broken test
- Update project settings docs
- Update general project settings image
- Rename helper methods
|
|
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53463
|
|
Include a new policy in Clusterables
(projects and groups), which checks if another cluster
can be added
clusterable_has_cluster? and multiple_clusters_available
private methods will be overriden in EE
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/34758
|
|
Part of the code such as #show_path is already present on the presenter.
Also avoid having code in two places (helper and presenter)
Sanitize and assert html_safe. Additional layer of defense - on top of
GitLab already requiring group names to be composed of small set of
chars A-Z, - and spaces.
Only link to cluster if user can read cluster
Make clear that arg is a GroupClusterablePresenter
Add more specs for completeness
|
|
|
|
Continues the iteration on the project overview UI:
- moved star, fork and new clone button
(copy SSH/HTTPS URLs) to top right,
made them smaller
- avatar is now larger (64px)
- 'Request access' is now a link instead
of a button
- overview comes before the description +
changed styling and added icons
- description font-size is now 16px (large-paragraph)
- quick links to files are moved downwards
below the commit/pipeline info
- margins changed to group content into
4 groups to clean up the interface
- visibility info reduced to icon-only and
moved to the right of the title
|
|
permissions but permissions are not overridden"
|
|
Not project clusters
|
|
This suggests possibly related issues when the user types a title.
This uses GraphQL to allow the frontend to request the exact
data that is requires. We also get free caching through the Vue Apollo
plugin.
With this we can include the ability to import .graphql files in JS
and Vue files.
Also we now have the Vue test utils library to make testing
Vue components easier.
Closes #22071
|
|
In a few models we define ActiveRecord enums that are redefined in EE
using the following pattern:
enum :some_enum, {
...
}.merge(EE_ENUM_VALUES)
This particular approach is problematic to deal with, because it
requires that we `prepend` and EE module _before_ defining the enum.
This typically translates to the `prepend` being the first line in the
model in EE, but this can easily lead to merge conflicts when developers
add more `include` and/or `prepend` lines.
As part of https://gitlab.com/gitlab-org/gitlab-ee/issues/8244 and
https://gitlab.com/gitlab-org/gitlab-ee/issues/8241 we are moving
`prepend` to the last line in a file, reducing the chances of running
into merge conflicts. This poses a bit of a problem with the pattern
above, because this pattern does not allow us to move the `prepend`
further down a file.
To resolve this problem, we simply move the Hash value of the enum to a
separate class method. This method is defined in a separate module where
necessary, allowing us to use it like so:
enum :failure_reasons, ::SomeModelEnums.failure_reasons
The method in turn is defined in a very straightforward manner:
module SomeModelEnums
def self.failure_reasons
{
...
}
end
end
This makes it easy for EE to add values without requiring the `prepend`
to be placed before the `enum` is defined.
For more information, see the following issues and merge requests:
* https://gitlab.com/gitlab-org/gitlab-ee/issues/8244
* https://gitlab.com/gitlab-org/gitlab-ee/issues/8241
* https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8424
|
|
Use presenters instead otherwise we will have x2 overides in EE
|
|
Refacotr project or group specific `if` logic to be contained within
each presenter instead.
Also add :override to ensure super method exists.
|
|
Use model method as single source of truth instead of splitting between
presenter and Kubernetes model
|
|
|
|
|
|
Group clusters should not allow Project Namespace so don't show that
field input too
|
|
- Add pages javascripts to intialize clusters for group pages
- Move specs asserting gcp specific validations from controller into
UpdateService spec
- Also teach Clusters::ApplicationController about groups
|
|
The soft-archived builds cannot be run after some deadline time.
The intent is to aggressively recycle old builds after sometime.
|
|
Top level clusters controller
See merge request gitlab-org/gitlab-ce!22438
|
|
To reduce the number of abstract methods, use polymorphic_paths for
collection routes. Unfortunately for member routes, polymorphic_paths
does not support namespaced classes, so still continue to override
methods.
|
|
Also add missing interface in abstract class.
|
|
Use ClustersController as base while having Projects::ClustersController
to inform what `clusterable` is. Thanks @ayufan for the great suggestion
!
- View changes to work with new approach
- Fix javascript for new approach
- Fix feature specs for new approach
- Fix QA
|
|
- Move show path for cluster to ClusterPresenter
- Create ClusterablePresenter to encapsulate logic. Consolidates
scattered methods from BaseController and ClustersHelper into an object.
|
|
Fix quick links button styles
Closes #52220 and #52063
See merge request gitlab-org/gitlab-ce!22657
|
|
|
|
This is to DRY the repeated file size check.
Move spec and constants to Highlight
|
|
Force FoundBlob to use BlobPresenter
|
|
|
|
[master] Fix XSS in MR source branch name
See merge request gitlab/gitlabhq!2544
|
|
|
|
|
|
Add RAW file format which is used to store security reports
Closes gitlab-ee#7996
See merge request gitlab-org/gitlab-ce!22365
|
|
- This introduces and uses `:raw` format for all legacy reports,
the ones that do not have yet proper parsers on Backend
- Raw format is needed to make Frontend be able to parse reports,
without the need of decompressing,
- This also extends fixtures to seed security reports with database,
even though parser code is part of EE
|
|
This integration no longer works and does not appear to be supported.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39697
|
|
|
|
|
|
|
|
|
