Age | Commit message (Collapse) | Author | |
---|---|---|---|
2018-10-22 | Move Project#rename_repo to a service class | Yorick Peterse | |
This moves the logic of Project#rename_repo and all methods _only_ used by this method into a new service class: Projects::AfterRenameService. By moving this code into a separate service class we can more easily refactor it, and we also get rid of some RuboCop "disable" statements automatically. During the refactoring of this code, I removed most of the explicit logging using Gitlab::AppLogger. The data that was logged would not be useful when debugging renaming issues, as it does not add any value on top of data provided by users. I also removed a variety of comments that either mentioned something the code does in literal form, or contained various grammatical errors. Instead we now resort to more clearly named methods, removing the need for code comments. This method was chosen based on analysis in https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue we determined this method has seen a total of 293 lines being changed in it. We also noticed that RuboCop determined the ABC size (https://www.softwarerenovation.com/ABCMetric.pdf) was too great. | |||
2018-10-05 | Make GitLab pages support access control | Tuomo Ala-Vannesluoma | |
2018-09-11 | Disable existing offenses for the CodeReuse cops | Yorick Peterse | |
This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop. | |||
2018-08-16 | Resolve "Enable Auto DevOps instance-wide on GitLab.com" | Dylan Griffith | |
2018-08-03 | Resolve "Hashed storage: extend "Enable hashed storage for all new projects" ↵ | Valery Sizov | |
to "for all new and renamed projects"" | |||
2018-07-31 | Remove todos when project feature visibility changes | Jarka Kadlecová | |
2018-07-30 | Delete todos when users loses target read permissions | Jarka Kadlecová | |
2018-07-18 | Enable more frozen string in app/services/**/*.rb | gfyoung | |
Partially addresses #47424. | |||
2018-07-09 | Updates from `rubocop -a` | Lin Jen-Shin | |
2018-06-06 | Don't update/create projects errors were added | Bob Van Landuyt | |
This could be done when a block is passed in EE. | |||
2018-06-05 | Merge branch ↵ | Kamil Trzciński | |
'46452-nomethoderror-undefined-method-previous_changes-for-nil-nilclass' into 'master' Resolve "NoMethodError: undefined method `previous_changes' for nil:NilClass" Closes #46452 See merge request gitlab-org/gitlab-ce!19190 | |||
2018-06-05 | Use nullcheck operator instead of checking for null | Matija Čupić | |
2018-06-04 | Yield to an optional block in Projects::UpdateService | Robert Speicher | |
See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5825#note_75764799 | |||
2018-06-04 | Bring CE-EE parity to app/services/projects/update_service.rb | Robert Speicher | |
2018-05-28 | Add check for nil auto_devops in Projects::UpdateService | Matija Čupić | |
2018-03-22 | Add HTTPS-only pages | Rob Watson | |
Closes #28857 | |||
2018-03-08 | Fix Error 500 when updating a project | Stan Hu | |
If no parameters were specified for project features but Wikis were disabled, we would get "NoMethodError: undefined method `[]' for nil:NilClass". Closes #44019 | |||
2018-02-26 | Make sure wiki exists when it's enabled | Valery Sizov | |
2018-02-02 | use Gitlab::UserSettings directly as a singleton instead of ↵ | Mario de la Ossa | |
including/extending it | |||
2017-12-04 | Remove Auto DevOps checkboxes - backend | bikebilly | |
2017-11-28 | BE for automatic pipeline when enabling Auto DevOps | Matija Čupić | |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38962 | |||
2017-09-13 | Fix project feature being deleted when updating project with invalid ↵ | Felipe Artur | |
visibility level | |||
2017-09-06 | Refactor based on code review | Michael Kozono | |
2017-09-06 | Dry up method for code climate | Michael Kozono | |
2017-08-08 | Add checks for branch existence before changing HEAD | blackst0ne | |
2017-07-24 | Fix editing project with container images present | Grzegorz Bizon | |
2017-07-14 | Add specs for changing default branch in a project | Grzegorz Bizon | |
2017-07-13 | Recover from renaming project that has container images | Grzegorz Bizon | |
2017-01-26 | Add a system hook for when a project is updated. | Tommy Beadle | |
This sends a project_update hook when a repo is updated. This does not include renaming or transferring a project. Those are covered by project_rename and project_transfer. This will get called, however, when the visibility is changed. | |||
2017-01-16 | Add a spec and actually display the flash notice | Rémy Coutable | |
Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2017-01-15 | Fix to display notice when project settings updated. | sandish chen | |
Change validity checking for UpdateService. Add return value for project update service. Return 302(redirect_to) when successfully updated. Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2016-12-16 | Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741 | Rydkin Maxim | |
2016-07-27 | Fix Project#to_param to keep invalid project suitable for use in URLs | Douglas Barbosa Alexandre | |
2016-07-27 | Fix renaming repository when name contains invalid chars under settings | Douglas Barbosa Alexandre | |
2016-07-06 | Services: code style fixes, minor refactoring | Valery Sizov | |
2016-03-20 | Tweaks, refactoring, and specs | Douwe Maan | |
2015-11-20 | Change update_forks_visibility_level into after_update hook in Project model | Tomasz Maczukin | |
2015-11-20 | Prevent unnecessary forks iteration at parent update | Tomasz Maczukin | |
2015-11-19 | Change forks method to has_many relation | Tomasz Maczukin | |
2015-11-05 | Update forks visibility_level after parent project visibility_level change | Tomasz Maczukin | |
2015-11-03 | Fix Project update service | Tomasz Maczukin | |
When project is updated and it is a fork, then visibility_level should not be less restrictive than in its parent project. | |||
2015-03-09 | Enforce restricted visibilities for snippets | Vinnie Okada | |
Add new service classes to create and update project and personal snippets. These classes are responsible for enforcing restricted visibility settings for non-admin users. | |||
2015-03-09 | Allow admins to override restricted visibility | Vinnie Okada | |
Allow admins to use restricted visibility levels when creating or updating projects. | |||
2014-06-27 | Make app works with strong params | Dmitriy Zaporozhets | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | |||
2014-06-26 | Remove protected_atrributes gem and start moving to strong params | Dmitriy Zaporozhets | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | |||
2014-06-17 | Remove project observer | Dmitriy Zaporozhets | |
2014-01-16 | Move all Context classes into Services | Dmitriy Zaporozhets | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> |