| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Resolve "Make Auto DevOps settings first class"
Closes #43466
See merge request gitlab-org/gitlab-ce!18321
|
|
CE Backport: Reveal labels dropdown when labels icon is clicked on collapsed Epic sidebar
See merge request gitlab-org/gitlab-ce!18255
|
|
Add 2FA filter to users API for admins only
See merge request gitlab-org/gitlab-ce!18503
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
|
|
Prior to this change, Flowdock used Grit to get the difference between
commits and post that to the remote service. This required direct path
access, which doesn't work with Gitaly.
Fixes gitlab-org/gitaly#1113
|
|
'No job log' message is no longer necessary since we returned an image
when a build does not have a trace. See
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18278 for more
details
Closes #45625
|
|
|
|
|
|
|
|
Resolve "Show new branch/merge request button even if a branch / merge request already exists"
Closes #42803
See merge request gitlab-org/gitlab-ce!17712
|
|
discussion after the discussion is resolved"
|
|
Fix issues without links when added from boards new issue modal
Closes #45435
See merge request gitlab-org/gitlab-ce!18460
|
|
|
|
|
|
|
|
|
|
Fix specifying a non-default ref when requesting an archive using the legacy URL
Closes #45507
See merge request gitlab-org/gitlab-ce!18468
|
|
Fix N+1 queries when loading participants for a commit note
Closes #45526
See merge request gitlab-org/gitlab-ce!18471
|
|
[Rails5] Fix `User#manageable_groups`
See merge request gitlab-org/gitlab-ce!18330
|
|
|
|
|
|
|
|
|
|
Fixed IDE diff markers being cached too long
See merge request gitlab-org/gitlab-ce!18311
|
|
Added staged files state to IDE
Closes #44842, #44844, and gitlab-ee#4541
See merge request gitlab-org/gitlab-ce!17898
|
|
Old records have a null value of file_store column.
This causes the problems with current direct_upload implementation,
as this makes it to choose Store::REMOTE instead of Store::LOCAL.
This change moves the store save when change saving the object.
|
|
Resolve "Calculating total size of a project's CI artifacts"
Closes #41059
See merge request gitlab-org/gitlab-ce!17839
|
|
(#41059)
Previously we scheduled a worker to just some this but we were running
into performance issues when the build table was getting too large. So
now we've updated the code such that this column is updated immediately
and incremented/decremented by the correct amount whenever artifacts are
created or deleted.
We've also added the performance optimization that we do not update this
statistic if a project is deleted because it could result in many
updates for a project with many builds.
|
|
|
|
|
|
|
|
|
|
Get GITLAB_FEATURES from Project#licensed_features instead of Namespace#features (#5320)
See merge request gitlab-org/gitlab-ce!18189
|
|
We saw about 10,000 SQL queries for some commits in the NewNoteWorker,
which stalled the Sidekiq queue for other new notes. The notification
service took up to 8 minutes to process the commits. Avoiding this
N+1 query brings the time down significantly.
Closes #45526
|
|
In `arel 7.0` (`7.1.4` version is used for rails5) there were introduced
some changes that break our code in the `User#manageable_groups` method.
The problem is that `arel_table[:id].in(Arel::Nodes::SqlLiteral)` generates
wrong `IN ()` construction. The selection for `IN` is missing:
=> "\"namespaces\".\"id\" IN (0)"
That caused such spec errors for the `rails5` branch:
```
4) User groups with child groups #manageable_groups does not include duplicates if a membership was added for the subgroup
Failure/Error: expect(user.manageable_groups).to contain_exactly(group, subgroup)
expected collection contained: [#<Group id:232 @group29>, #<Group id:234 @group29/group30>]
actual collection contained: []
the missing elements were: [#<Group id:232 @group29>, #<Group id:234 @group29/group30>]
# ./spec/models/user_spec.rb:699:in `block (5 levels) in <top (required)>'
# ./spec/spec_helper.rb:188:in `block (2 levels) in <top (required)>'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:112:in `block in run'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `loop'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `run'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
# /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:30:in `block (2 levels) in setup'
```
This commit changes `User#manageable_groups` in the way to drop the usage of
`Arel::Nodes::SqlLiteral` and adds usage of raw SQL query.
This change should be updated when we're migrated to Rails 5.2 because arel
was fixed in `9.0.0` (which is used in Rails 5.2).
|
|
|
|
Revert the addition of goldiloader
See merge request gitlab-org/gitlab-ce!18458
|
|
Fix issues on groups group trees
Closes #42407
See merge request gitlab-org/gitlab-ce!18390
|
|
|
|
This reverts commit 2c3c5b35549185080296670cfe6710aa80f99944.
Revisit this after https://gitlab.com/gitlab-org/gitlab-ce/issues/45441
|
|
|
|
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
|
|
fixed up duplicate is-collapsed classes
|
|
set proper signature marker in mails
Closes #43617
See merge request gitlab-org/gitlab-ce!17979
|
|
|
|
Fix regression around new SHA widget in "New Merge Request" Screen
Closes #45446
See merge request gitlab-org/gitlab-ce!18422
|
|
Improve web IDE commit input
Closes #44832
See merge request gitlab-org/gitlab-ce!18389
|
