| Age | Commit message (Collapse) | Author |
|---|
|
Document not using ActiveRecord's serialize method
See merge request !11821
|
|
Fix N+1 queries for non-members in comment threads
See merge request !11827
|
|
'31602-display-whether-shared-runner-is-enabled-in-the-admin-dashboard' into 'master'
Display Shared Runner status in Admin Dashboard
Closes #31602
See merge request !11783
|
|
Fix: A diff comment on a change at last line of a file shows as two comments in discussion
Closes #32353
See merge request !11802
|
|
Fixes multi-line math in notebooks
Closes #30900 and #33074
See merge request !11789
|
|
When getting the max member access for a group of users, we stored the results
in RequestStore. However, this will only return results for project members, so
anyone who wasn't a member of the project would be checked once at the start,
and then once for each comment they made. These queries are generally quite
fast, but no query is faster!
|
|
Consistent diff and blob size limit names
See merge request !11776
|
|
Don't match email addresses or foo@bar as user references
See merge request !11837
|
|
Resolve N+1 query issue with discussions
Closes #33013
See merge request !11775
|
|
|
|
# Conflicts:
# db/schema.rb
|
|
|
|
Rename BuildsController to JobsController
Closes #30699
See merge request !11407
|
|
|
|
Update task_list to version 2.0.0
Closes #22470
See merge request !11525
|
|
Issue inline editing
Closes #24873
See merge request !11322
|
|
Fixed the show_user_callout method
See merge request !11689
|
|
in discussion
|
|
|
|
* upstream/master: (63 commits)
Update docs related to protected actions
Add changelog for protected branches abilities fix
Ask for an example project for bug reports
Center loading spinner in issuable filters
Fix chat commands specs related to protected actions
Fix builds controller specs related to protected actions
Fix pipeline retry specs related to protected actions
Fix environment model specs related to protected actions
Fix build factory specs related to protected actions
Fix job play service specs related to protected actions
Fix play status specs related to protected actions
Fix deploy chat command specs for protected actions
Fix environment specs related to protected actions
Fix pipeline processing specs related to protected actions
Fix build entity specs related to protected actions
Check only a merge ability for protected actions
Add tag_list param to project api
Allow PostReceivePack to be enabled with Gitaly
Remove some deprecated methods
Add :owned param to ProjectFinder
...
|
|
Improve /project API performance
Closes #31855 and #31937
See merge request !11666
|
|
Center loading spinner in issuable filters
Closes #33137
See merge request !11818
|
|
'master'
Check only a merge ability for protected actions
Closes #32618
See merge request !11648
|
|
|
|
This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.
|
|
Add API support for pipeline schedule
Closes #30892
See merge request !11307
|
|
* upstream/master: (116 commits)
Revert "Merge branch 'grpc-1.3.4' into 'master'"
Return nil when looking up config for unknown LDAP provider
Avoid crash when trying to parse string with invalid UTF-8 sequence
Enable Gitaly by default in GitLab 9.3
Don’t create comment on JIRA if link already exists
Disable sub_group_issuables_spec.rb for mysql
Fix math rendering on blob pages
Add changelog
Don't allow to pass a user to ProjectWiki#http_url_to_repo
Revert "Merge branch '1937-https-clone-url-username' into 'master'
"
Fix bottom padding for build page
Fix /unsubscribe slash command creating extra todos
Fix omniauth-google-oauth2 dependencies in Gemfile.lock
Update looks job log
'New issue'/'New merge request' dropdowns should show only projects with issues/merge requests feature enabled
Fix spec for Members::AuthorizedDestroyService
31616-add-uptime-of-gitlab-instance-in-admin-area
Set head pipeline when creating merge requests
Create a separate helper to check if we show particular tab on a search page
Add performance deltas between app deployments on Merge Request widget
...
|
|
|
|
|
|
|
|
To avoid the use of slow queries, remove some deprecated methods and encourage
the use of ProjectFinder to find projects.
|
|
And use it in the API.
|
|
Now it is possible to combine the :non_public parameter. This might be useful
when a user wants to know the trending projects they are member of.
|
|
Instead of applying WHERE on a UNION, apply the WHERE on each of the seperate
SELECT statements, and do UNION on that.
Local tests with about 2_000_000 projects:
- 1_500_000 private projects
- 40_000 internal projects
- 400_000 public projects
For the API endpoint `/api/v4/projects?visibility=private` the slowest query was:
```sql
SELECT "projects".*
FROM "projects"
WHERE ...
```
The original query took 1073.8ms.
The query refactored to UNION of SELECT/WHERE took 2.3ms.
The original query was:
```sql
SELECT "projects".*
FROM "projects"
WHERE "projects"."pending_delete" = $1
AND (projects.id IN
(SELECT "projects"."id"
FROM "projects"
INNER JOIN "project_authorizations" ON "projects"."id" = "project_authorizations"."project_id"
WHERE "projects"."pending_delete" = 'f'
AND "project_authorizations"."user_id" = 23
UNION SELECT "projects"."id"
FROM "projects"
WHERE "projects"."visibility_level" IN (20,
10)))
AND "projects"."visibility_level" = $2
AND "projects"."archived" = $3
ORDER BY "projects"."created_at" DESC
LIMIT 20
OFFSET 0 [["pending_delete", "f"],
["visibility_level", 0],
["archived", "f"]]
```
The refactored query:
```sql
SELECT "projects".*
FROM "projects"
WHERE "projects"."pending_delete" = $1
AND (projects.id IN
(SELECT "projects"."id"
FROM "projects"
INNER JOIN "project_authorizations" ON "projects"."id" = "project_authorizations"."project_id"
WHERE "projects"."pending_delete" = 'f'
AND "project_authorizations"."user_id" = 23
AND "projects"."visibility_level" = 0
AND "projects"."archived" = 'f'
UNION SELECT "projects"."id"
FROM "projects"
WHERE "projects"."visibility_level" IN (20,
10)
AND "projects"."visibility_level" = 0
AND "projects"."archived" = 'f'))
ORDER BY "projects"."created_at" DESC
LIMIT 20
OFFSET 0 [["pending_delete", "f"]]
```
|
|
The `starred` parameter couldn't be used in combination with `trending` or
`non_public`. But this is changed now.
|
|
Add a scope to search for the projects that are starred by a certain user.
|
|
Resolve "Allow to disable username on checkout url"
Closes #30410 and #30174
See merge request !11792
|
|
Remove extra bottom padding on Job log page
Closes #30502
See merge request !11791
|
|
|
|
|
|
|
|
|
|
|
|
Closes #30900
|
|
Don’t create comment on JIRA if link already exists
Closes #25373
See merge request !11485
|
|
|
|
|
|
|
|
|
|
`canEdit` changes for conditional remove button on filtered search -- EE backport
Closes gitlab-ee#2433
See merge request !11696
|
