| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This is step one of resolving
https://gitlab.com/gitlab-org/gitlab-ce/issues/56838.
Here is what changed:
- Revert the security fix from bdee9e8412d.
- Do not leak repository information (tag name, commit) to guests in API
responses.
- Do not include links to source code in API responses for users that do
not have download_code access.
- Show Releases in sidebar for guests.
- Do not display links to source code under Assets for users that do not
have download_code access.
GET ':id/releases/:tag_name' still do not allow guests to access
releases. This is to prevent guessing tag existence.
|
|
Impove the performance of expanding full diff
Closes #58597
See merge request gitlab-org/gitlab-ce!27413
|
|
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58597
|
|
Switch to sassc-rails for faster stylesheet compilation
Closes #18432
See merge request gitlab-org/gitlab-ce!26224
|
|
When this option is enabled, GitLab will create namespaces and service
accounts as usual. When disabled, GitLab wont create any project
specific kubernetes resources
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56557
|
|
Use PostgreSQL 10.7 in tests
See merge request gitlab-org/gitlab-ce!28020
|
|
- Adds an endpoint on PipelinesController
- Adds a service that iterates over every build in a stage and
plays it.
- Includes 'play_manual' details on EntitySerializer
- Builds a new Stage state: PlayManual. An stage can take this status if
it has manual builds or an skipped, scheduled or manual status
- Includes FE modifications and specs
|
|
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
|
|
The new two-step Gitaly `Rebase` RPC yields the rebase commit SHA to the
client before proceeding with the rebase.
This avoids an issue where the rebase commit SHA was returned when the
RPC had fully completed, and in some cases this would be after the Rails
`post_receive` worker services had already run. In these situations,
the merge request did not yet have its rebase_commit_sha attribute set
introducing the possibility for bugs (such as previous approvals being
reset).
https://gitlab.com/gitlab-org/gitlab-ee/issues/5966
|
|
Include link to user and commit title.
Rearrange text
|
|
This new field will allow to keep track of the storage used by the
packages features, it provides also aggregation at namespace level.
|
|
- Vue confirmation modal implementation
- CSS tweaks for modal default height
|
|
Fix IDE get file data with '/' as relative root
See merge request gitlab-org/gitlab-ce!27911
|
|
'53064-bypassing-pipeline-jobs-by-canceling-the-pipeline-and-manually-running-later-jobs' into 'master'
Disable retrying cancelled jobs
Closes #53064
See merge request gitlab-org/gitlab-ce!27503
|
|
Allow a member to have an access level equal to parent group
Closes gitlab-ee#11323
See merge request gitlab-org/gitlab-ce!27913
|
|
|
|
- Moved discussion notes out of `NoteableDiscussion` component into a
new `DiscussionNotes` component
- Wrote Jest tests for the new `DiscussionNotes` component
- Updated Jest config for emojis fixtures
- Updated Karma tests `NoteableDiscussion` to match its new structure
- Convert `DiffDiscussions` tests to use Vue test utils
|
|
[ci skip]
|
|
Fix webpack asset patch with '/' as relative root
See merge request gitlab-org/gitlab-ce!27909
|
|
|
|
Suppose you have this configuration:
1. Subgroup `hello/world`
2. Subgroup `hello/mergers`.
3. Project `hello/world/my-project` has invited group `hello/world` to
access protected branches.
4. The rule allows the group to merge but no one can push.
5. User `newuser` has Owner access to the parent group `hello`.
Previously, there was no way for the user `newuser` to be added to the
`hello/mergers` group since the validation only allowed a user to be
added at a higher access level.
Since membership in a subgroup confers certain access rights, such as
being able to merge or push code to protected branches, we have to
loosen the validation and allow someone to be added at an equal level
granted by the parent group.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11323
|
|
feat: add option to define the Sentry Environment
See merge request gitlab-org/gitlab-ce!27091
|
|
https://gitlab.com/gitlab-org/gitlab-ce/issues/60932
|
|
refactor(sidebar): Refactored shared sidebar component tests to Jest
Closes #58830
See merge request gitlab-org/gitlab-ce!27688
|
|
https://gitlab.com/gitlab-org/gitlab-ce/issues/60932
|
|
|
|
[ci skip]
|
|
`on_stop` is not automatically triggered with pipelines for merge requests
Closes #60885
See merge request gitlab-org/gitlab-ce!27618
|
|
Add basic GraphQL for a Group
Closes #60786
See merge request gitlab-org/gitlab-ce!27492
|
|
Due to the nature of pipelines for merge requests, deployments.ref can
be a merge request ref instead of a branch name.
We support the environment auto-stop hook for this case
|
|
Domain will be removed by verification worker after 1 week
of being disabled
|
|
Disable method replacement in avatar loading
Closes #60903
See merge request gitlab-org/gitlab-ce!27866
|
|
We've seen a significant performance penalty when using
`BatchLoader#__replace_with!`. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
`method_missing`, which is slower. However, we've noticed that
`method_missing` can be faster if:
1. The objects being loaded have a large interface.
2. We don't call too many methods on the loaded object.
Avatar uploads meet both criteria above, so let's use the newly-released
feature in https://github.com/exAspArk/batch-loader/pull/45.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
|
|
Source branch can be removed after the merge and
we have to make sure to avoid rendering links if it's the case.
|
|
Fix base domain help text update
Closes #61036
See merge request gitlab-org/gitlab-ce!27746
|
|
Prevent concurrent execution of PipelineScheduleWorker
Closes gitlab-com/gl-infra/production#805
See merge request gitlab-org/gitlab-ce!27781
|
|
Before this commit using `/rails/letter_opener` in `development`
environment failed with:
undefined method `before_filter'
See https://github.com/fgrehm/letter_opener_web/issues/68
This commit upgrades `letter_opener_web` to 1.3.4 so Rails 5.1 is
supported.
|
|
|
|
Make `CI_COMMIT_REF_NAME` and `SLUG` variable idempotent
Closes #60822
See merge request gitlab-org/gitlab-ce!27663
|
|
Format extra help page text like wiki
Closes #55948
See merge request gitlab-org/gitlab-ce!26782
|
|
|
|
'master'
Disallow read user scope to read project events
See merge request gitlab/gitlabhq!3067
|
|
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.
When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:
```
def _app_views_project_show_html_haml___12345(local_assigns, output)
"hello world"
end
```
When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:
* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter
After this change:
* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.
How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:
```
Benchmark.bm do |x|
x.report do
1000.times do
ActionView::CompiledTemplates.module_eval("def testme\nend")
end
end
end
```
This revealed a 11x jump in the time spent in `core#define_method`
alone.
Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
|
|
With Pipelines for Merge Requests feature, users cannout keep using
$CI_COMMIT_REF_NAME and _SLUG predefined variables for dynamic
environments. We fix this problem by explicitly looking at the source
ref.
|
|
This commit contains the patch suggested by @fjsanpedro in the issue
covering broken links in wiki search results.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
|
|
Resolve "Deployment jobs broken as of 11.10.0"
Closes #60821
See merge request gitlab-org/gitlab-ce!27687
|
|
into 'master'
Init MR Popovers on system note mounted
Closes #60855
See merge request gitlab-org/gitlab-ce!27747
|
|
|
|
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27687
|
