| Age | Commit message (Collapse) | Author |
|---|
|
[ci skip]
|
|
This reverts commit 4f6293e2a0fc636de6de8b105b1de06f906ef33a.
|
|
[ci skip]
|
|
When post-processing relative links to absolute links
RelativeLinkFilter didn't take into consideration that
internal repository data could be exposed for users
that do not have repository access to the project.
This commit solves that by checking whether the user
can `download_code` at this repository, avoiding any
processing of this filter if the user can't.
Additionally, if we're processing for a group (
no project was given), we check if the user can
read it in order to expand the href as an extra.
That doesn't seem necessarily a breach now,
but an extra check doesn't hurt as after all
the user needs to be able to `read_group`.
|
|
Prevent disclosure of merge request id via email
See merge request gitlab/gitlabhq!3351
|
|
Send TODOs for comments on commits correctly
See merge request gitlab/gitlabhq!3366
|
|
Add method to store session ids by ip
Add new specs for storing session ids
Add cleaning up records after login
Add retrieving anonymous sessions
Add login recaptcha setting
Add new setting to sessions controller
Add conditions for showing captcha
Add sessions controller specs
Add admin settings specs for login protection
Add new settings to api
Add stub to devise spec
Add new translation key
Add cr remarks
Rename class call
Add cr remarks
Change if-clause for consistency
Add cr remarks
Add code review remarks
Refactor AnonymousSession class
Add changelog entry
Move AnonymousSession class to lib
Move store unauthenticated sessions to sessions controller
Move link to recaptcha info
Regenerate text file
Improve copy on the spam page
Change action filter for storing anonymous sessions
Fix rubocop offences
Add code review remarks
Fix schema
Update schema version
|
|
Use image proxy to mitigate stealing ip addresses
See merge request gitlab/gitlabhq!3231
|
|
Limit the size of issuable description and comments
See merge request gitlab/gitlabhq!3271
|
|
Permission fix for MergeRequestsController#pipeline_status
See merge request gitlab/gitlabhq!3278
|
|
Enforce max chars and max render time in markdown math
See merge request gitlab/gitlabhq!3287
|
|
DNS Rebind SSRF in Kubernetes Integration
See merge request gitlab/gitlabhq!3289
|
|
into '12-1-stable'
Fix HTML injection for label description
See merge request gitlab/gitlabhq!3298
|
|
'12-1-stable'
Ensure only authorised users can create notes on merge requests and issues
See merge request gitlab/gitlabhq!3307
|
|
'12-1-stable'
Filter out old system notes for epics in notes api endpoint response
See merge request gitlab/gitlabhq!3310
|
|
Fix DNS rebind vulnerability for JIRA integration
See merge request gitlab/gitlabhq!3311
|
|
'12-1-stable'
Add merge note type as cross reference
See merge request gitlab/gitlabhq!3327
|
|
Project visibility restriction bypass
See merge request gitlab/gitlabhq!3331
|
|
'12-1-stable'
Clear reset_password_tokens when login (email or username) change
See merge request gitlab/gitlabhq!3347
|
|
Restrict MergeRequests#test_reports to authenticated users with read-access on Builds
See merge request gitlab/gitlabhq!3355
|
|
Add direct upload support for personal snippets
See merge request gitlab/gitlabhq!3358
|
|
admin_group authorization for Groups::RunnersController
See merge request gitlab/gitlabhq!3363
|
|
At present, the TodoService uses the `:read_project` ability to decide
whether a user can read a note on a commit. However, commits can have a
visibility level that is more restricted than the project, so this is a
security issue.
This commit changes the code to use the `:read_commit` ability in this
case instead, which ensures TODOs are only generated for commit notes
if the users can see the commit.
|
|
When we un-escape HTML text to find references in it, we should then
re-escape the whole text again, not only found matches.
Because we replace matches with milestone/label links (which contain
HTML tags we don't want to escape again), we re-escape HTML text
with placeholders instead of these links and then replace placeholders
in the escaped text.
|
|
|
|
- Use authorize_admin_group! instead of authorize_admin_pipeline!
- Added role-based permission specs for Groups::RunnersController
|
|
Limiting the size of issuable description and comments to 1_000_000,
which is close to ~1MB of ASCII characters, which represents 99.9% of
all descriptions and comments we have in DB at the moment. This should
help prevent DoS attacks when comments contain refference strings.
Also this change updates regexp matching the namespaces paths by
limiting the namespaces paths to Namespace::NUMBER_OF_ANCESTORS_ALLOWED,
as we allow 20 levels deep groups.
see https://gitlab.com/gitlab-org/gitlab-ce/issues/61974#note_191274234
|
|
on Builds
|
|
Do not disclosure merge request id via email for unauthorized users
when closing issues.
|
|
Devise checks before updating any of the authentication_keys if it
needs to clear the reset_password_tokens.
This should fix:
https://gitlab.com/gitlab-org/gitlab-ce/issues/42733 (Weak
authentication and session management)
|
|
User images and videos will get proxied through
the Camo server in order to keep malicious
sites from collecting the IP address of users.
|
|
Add Gitlab::VisibilityLevelChecker that verifies
selected project visibility level (or overridden param)
is not restricted when creating or importing a project
|
|
|
|
- Use set_pipeline_variables to filter for visible pipelines
- Mimic response of nonexistent pipeline if not found
- Provide set_pipeline_variables as a before_filter for other actions
|
|
[ci skip]
|
|
|
|
|
|
Uses Gitlab::HTTP for JIRA requests instead of Net::Http.
Gitlab::Http comes with some built in SSRF protections.
|
|
* Prevent creating notes on inaccessible MRs
This applies the notes rules at the MR scope. Rather than adding extra
rules to the Project level policy, preventing :create_note here is
better since it only prevents creating notes on MRs.
* Prevent creating notes in inaccessible Issues
without this policy, non-team-members are allowed to comment on issues
even when the project has the private-issues policy set. This means that
without this change, users are allowed to comment on issues that they
cannot read.
* Add CHANGELOG entry
|
|
KaTeX math will now render progressivly and asynchronously. There
are upper limits on the character count of each formula, and on
cumulative render time.
|
|
[ci skip]
|
|
|
|
Improve job log rendering performance
See merge request gitlab-org/gitlab-ce!31262
(cherry picked from commit eb2d4adf38726da62f62e850d181cedf12c64c5e)
6b45d85e Prevent empty classes in ansi2html conversion
5366c89b Fix deep DOM tree problem in ansi2html
d1f4d8c7 Improve size of rendered job trace
|
|
Set DOCKER_TLS_CERTDIR in CI job templates
See merge request gitlab-org/gitlab-ce!31201
(cherry picked from commit 82ce29d32fc8d98571ee43a6d348f89bdecfa9c0)
8d4f53a0 Set DOCKER_TLS_CERTDIR in CI job templates
25486f40 Merge remote-tracking branch 'upstream/master' into patch-72
2535575c Add changelog.
|
|
Add exclusive lease to mergeability check process
See merge request gitlab-org/gitlab-ce!31082
(cherry picked from commit c017dc578dc78729050792d22b449ce0529479cf)
f4cd926c Add exclusive lease to mergeability check process
|
|
|
|
Kubeclient uses rest-client. We hack into to access the net/http object
so that we can patch to connect to the resolved IP + set
hostname_override.
Add specs for discord. The discord integration also uses rest-client, so
since we patched rest-client, spec that the DNS rebinding protection
works
|
|
|
|
[ci skip]
|
|
Fix exception handling in Gitaly autodetection
Closes #65328
See merge request gitlab-org/gitlab-ce!31285
(cherry picked from commit d92a8c1a5f9b061a10140239bed44b432b28abdf)
3b76d298 Fix exception handling in Gitaly autodetection
|
