| Age | Commit message (Collapse) | Author |
|---|
|
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
|
|
Render new issue link in failed job as a regular link instead of a UJS one
Closes #36158
See merge request !13450
|
|
Fix conflicting redirect search
See merge request !13357
|
|
|
|
|
|
|
|
Simplify checking if objects exist code in new issaubles workers
Closes #36119
See merge request !13365
|
|
|
|
|
|
'36010-api-v4-allows-setting-a-branch-that-doesn-t-exist-as-the-default-one' into 'master'
Resolve "API v4 allows setting a branch that doesn't exist as the default one"
Closes #36010
See merge request !13359
|
|
'35052-please-select-a-file-when-attempting-to-upload-or-replace-from-the-ui' into 'master'
Resolve "'Please select a file' when attempting to upload or replace from the UI"
Closes #35052
See merge request !12863
|
|
Raise encoding confidence threshold to 50
Closes #35098
See merge request !12990
|
|
Fix the /projects/:id/repository/commits endpoint to handle dots in the ref name…
Closes #15651
See merge request !13370
|
|
hide placeholder text when files have been added
vertically center dropzone area content
close modal after file upload succeeds
|
|
|
|
|
|
|
|
name when the project full path contains a `/`
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
name when the project full path contains a `/`
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Resolve "Store MergeWorker JID on merge request, and clean up stuck merges"
Closes #31207
See merge request !13207
|
|
|
|
|
|
Issuables: Move some code from create services to Sidekiq workers
See merge request !13326
|
|
|
|
Store & use ConvDev percentages returned by Version app
Closes #35761
See merge request !13217
|
|
|
|
Improve GitHub importer
Closes #27429
See merge request !12886
|
|
Allow projects to be started from a template
Closes #32420
See merge request !13108
|
|
Support group milestone references
Closes #34778
See merge request !13289
|
|
|
|
|
|
|
|
|
|
|
|
Resolve "Navigation - Make contextual sidebar collapsible"
Closes #34028
See merge request !13281
|
|
add feature rename wiki title
Closes #27800
See merge request !10069
|
|
add star for action scope, in order to delete image from registry
Closes #26465
See merge request !13248
|
|
|
|
Improve various parts of Dashboard::ProjectsController
See merge request !13319
|
|
Circuitbreaker for storage paths
Closes #32207, #33117, gitlab-com/infrastructure#1946, and gitlab-com/infrastructure#1775
See merge request !11449
|
|
34764 Rename about to overview for group and project page
Closes #34764
See merge request !13318
|
|
|
|
|
|
|
|
This solves an N+1 query problem where for every project we'd query the
creator separately just to figure out what avatar to display.
|
|
The method User#projects_limit_left would run "personal_projects.count"
but such a query is not memoized. As a result multiple calls to
User#projects_limit_left would result in multiple COUNT(*) queries being
executed.
To work around this this commit adds User#personal_projects_count which
simply memoizes the result of the COUNT(*) in an instance variable.
|
|
The "events" table has a foreign key on "events.project_id" with a
cascading delete. As such it's impossible for an event to have a
non-existing project ID.
|
|
In various places we check if the same relation would return projects.
This is done using "any?" which will run a COUNT query with any
LIMIT/OFFSET values still applied.
To work around all this we introduce 2 helper methods that take care of
doing the right thing. This leads to the produced queries being simpler
and fewer queries being executed.
|
|
|
