| Age | Commit message (Collapse) | Author |
|---|
|
Remove the need to use health check token by adding ability to whitelist hosts
Closes #33949
See merge request !12612
|
|
Test logging in via the Authentiq OAuth provider in a feature spec
Closes #34737
See merge request !12694
|
|
Remove option to disable Gitaly in Rails
See merge request !12677
|
|
|
|
- The `migration:path-pg` build was previously failing when the Authentiq
feature spec was enabled by placing Authentiq configuration in the `test`
section of `gitlab.yml`
- The `migration:path-pg` task checks out an old revision of the
codebase (`v8.14.10`) and runs a `schema:load`. It then checks out the commit
under test, and runs `db:migrate`, to verify that migrations run without
errors.
- The problem here is that `v8.14.10` does not have the Authentiq module
installed, but is run with the `gitlab.yml` for `master`, which would contain
the `Authentiq` configuration in the `test` section.
- The solution was to use the `v8.14.10` `gitlab.yml` for the `schema:load`,
rather than the `gitlab.yml` from master.
|
|
Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login"
Closes #34713
See merge request !12668
|
|
- This is causing autoload-related errors in the `migration:path` builds. We
need to find a better way of testing this provider.
|
|
- Don't use `request.env['omniauth.params']` if it isn't present.
- Remove the `saml` section from the `gitlab.yml` test section. Some tests
depend on this section not being initially present, so it can be overridden
in the test. This MR doesn't add any tests for SAML, so we didn't really need
this in the first place anyway.
- Clean up the test -> omniauth section of `gitlab.yml`
|
|
- I tried to get this to work by stubbing out portions of the config within the
test. This didn't work as expected because Devise/Omniauth loaded before the
stub could run, and the stubbed config was ignored.
- I attempted to fix this by reloading Devise/Omniauth after stubbing the
config. This successfully got Devise to load the stubbed providers, but failed
while trying to access a route such as `user_gitlab_omniauth_authorize_path`.
- I spent a while trying to figure this out (even trying
`Rails.application.reload_routes!`), but nothing seemed to work.
- I settled for adding this config directly to `gitlab.yml` rather than go down
this path any further.
|
|
This reverts merge request !11963
|
|
Honor the "Remember me" parameter for OAuth-based login
Closes #18000
See merge request !11963
|
|
|
|
as deprecated
|
|
in favor of whitelist that will be used to
control the access to monitoring resources
|
|
|
|
- Don't use `request.env['omniauth.params']` if it isn't present.
- Remove the `saml` section from the `gitlab.yml` test section. Some tests
depend on this section not being initially present, so it can be overridden
in the test. This MR doesn't add any tests for SAML, so we didn't really need
this in the first place anyway.
- Clean up the test -> omniauth section of `gitlab.yml`
|
|
- I tried to get this to work by stubbing out portions of the config within the
test. This didn't work as expected because Devise/Omniauth loaded before the
stub could run, and the stubbed config was ignored.
- I attempted to fix this by reloading Devise/Omniauth after stubbing the
config. This successfully got Devise to load the stubbed providers, but failed
while trying to access a route such as `user_gitlab_omniauth_authorize_path`.
- I spent a while trying to figure this out (even trying
`Rails.application.reload_routes!`), but nothing seemed to work.
- I settled for adding this config directly to `gitlab.yml` rather than go down
this path any further.
|
|
|
|
|
|
|
|
|
|
Add username parameter to gravatar URL
Closes #24472
See merge request !11741
|
|
|
|
|
|
|
|
|
|
|
|
GitLab uses the import_project method in GitLab Shell,
This method uses a timeout for the operation, hardcoded to 800 seconds.
With this MR the timeout is now configurable in the gitlab_shell
settings.
|
|
Hard-coding location of configuration files is very bad practice. This
patch applies the same approach as currently used for
gitlab_shell_secret file.
|
|
|
|
twice a day
|
|
|
|
|
|
Closes gitaly#166
|
|
Use full path for moving directories when changing namespace path
See merge request !2078
|
|
|
|
|
|
The GitLab Pages external-http and external-https arguments can be specified multiple times
See merge request !9812
|
|
Note that the old migrations depend on 1_settings.rb, so we can't
quite remove those completely.
|
|
Enable snippets for new projects by default
Closes #28192
See merge request !9857
|
|
|
|
If there is an existing gitlab.yml file with snippets explicitly
disabled, they won't be enabled with this change.
|
|
multiple times
|
|
Update storage settings to allow extra values per shard
See merge request !9597
|
|
Fix typo in Gitlab application config file
Closes #24998
See merge request !9702
|
|
Add storage class configuration option for Amazon S3 remote backups
See merge request !9599
|
|
|
|
This will be necessary when adding gitaly settings. This version
doesn't make any functional changes, but allows us to include this
breaking change in 9.0 and add the needed extra settings in the future
with backwards compatibility
|
|
|
|
|
