| Age | Commit message (Collapse) | Author |
|---|
|
Update metric names to match Prometheus guidelines.
Closes #35031
See merge request !12812
|
|
|
|
|
|
Fixes needed when GitLab sign-in is not enabled
See merge request !12491
|
|
When sign-in is disabled:
- skip password expiration checks
- prevent password reset requests
- don’t show Password tab in User Settings
- don’t allow login with username/password for Git over HTTP requests
- render 404 on requests to Profiles::PasswordsController
|
|
+ fix tests after metrics rename
|
|
Disabled prepared statements in test
See merge request !12773
|
|
Remove the need to use health check token by adding ability to whitelist hosts
Closes #33949
See merge request !12612
|
|
Some tests may test migrations and change the types of columns. If this
happens, Rails may cache a statement that will cause PostgreSQL to fail with
the message, "cached plan must not change result type":
https://github.com/rails/rails/issues/12330
This happened in https://gitlab.com/gitlab-org/gitlab-ee/issues/2890#note_34636077.
|
|
|
|
# Conflicts:
# lib/gitlab/current_settings.rb
|
|
This reverts commit 83ec509ce43c56da601335de5b9ea4422c785560, reversing
changes made to 57f0677ad854b7b17bd57e1e3b0ef542ce322b56.
|
|
This is a follow-up for !12362 where this was documented but the code
was removed in the last iteration. Since this can still be useful and
this is already supported by the API, I think re-adding the code was
the best course of action.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Add creation time filters to user search API for admins
Closes #29507
See merge request !12682
|
|
#20628 Enable implicit flow in Gitlab as OAuth Provider
Closes #20628, #2716, and #19470
See merge request !12384
|
|
Include new URL helpers retroactively into includers of Gitlab::Routing
Closes #34821
See merge request !12716
|
|
Test logging in via the Authentiq OAuth provider in a feature spec
Closes #34737
See merge request !12694
|
|
|
|
|
|
|
|
Closes #20628 by re-enabling implicit grant in Doorkeeper config. OAuth2 documentation refactored.
|
|
|
|
Add Group secret variables
Closes #12729
See merge request !12582
|
|
Remove option to disable Gitaly in Rails
See merge request !12677
|
|
|
|
|
|
Fix static-snalysis
Move the precedence of group secure variable before project secure variable. Allow project_id to be null.
Separate Ci::VariableProject and Ci::VariableGroup
Add the forgotton files
Add migration file to update type of ci_variables
Fix form_for fpr VariableProject
Fix test
Change the table structure according to the yorik advice
Add necessary migration files. Remove unnecessary migration spec.
Revert safe_model_attributes.yml
Fix models
Fix spec
Avoid self.variable. Use becomes for correct routing.
Use unique index on group_id and key
Add null: false for t.timestamps
Fix schema version
Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable
Rename the rest of them
Add the rest of files
Basic BE change
Fix static-snalysis
Move the precedence of group secure variable before project secure variable. Allow project_id to be null.
Separate Ci::VariableProject and Ci::VariableGroup
Add the forgotton files
Add migration file to update type of ci_variables
Fix form_for fpr VariableProject
Fix test
Change the table structure according to the yorik advice
Add necessary migration files. Remove unnecessary migration spec.
Revert safe_model_attributes.yml
Fix models
Fix spec
Avoid self.variable. Use becomes for correct routing.
Use unique index on group_id and key
Add null: false for t.timestamps
Fix schema version
Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable
Rename the rest of them
Add the rest of files
Implement CURD
Rename codes related to VariableGroup and VariableProject FE part
Remove unneccesary changes
Make Fe code up-to-date
Add protected flag to migration file
Protected group variables essential package
Update schema
Improve doc
Fix logic and spec for models
Fix logic and spec for controllers
Fix logic and spec for views(pre feature)
Add feature spec
Fixed bugs. placeholder. reveal button. doc.
Add changelog
Remove unnecessary comment
godfat nice catches
Improve secret_variables_for arctecture
Fix spec
Fix StaticAnlysys & path_regex spec
Revert "Improve secret_variables_for arctecture"
This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.
Use ayufan suggestion for secret_variables_for
Use find instead of find_by
Fix spec message for variable is invalid
Fix spec remove variable.group_id = group.id
godffat spec nitpicks
Use include Gitlab::Routing.url_helpers for presenter spec
|
|
- The `migration:path-pg` build was previously failing when the Authentiq
feature spec was enabled by placing Authentiq configuration in the `test`
section of `gitlab.yml`
- The `migration:path-pg` task checks out an old revision of the
codebase (`v8.14.10`) and runs a `schema:load`. It then checks out the commit
under test, and runs `db:migrate`, to verify that migrations run without
errors.
- The problem here is that `v8.14.10` does not have the Authentiq module
installed, but is run with the `gitlab.yml` for `master`, which would contain
the `Authentiq` configuration in the `test` section.
- The solution was to use the `v8.14.10` `gitlab.yml` for the `schema:load`,
rather than the `gitlab.yml` from master.
|
|
Fix shorter route helpers in production environment
Closes #34741
See merge request !12675
|
|
|
|
|
|
Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login"
Closes #34713
See merge request !12668
|
|
I don't know exactly when Rails picks each module to use, but this seems to be
used by `app` in the console (for instance, `app.project_path` would fail
before, but works now).
|
|
Update Prometheus Metrics Library
See merge request !12621
|
|
- This is causing autoload-related errors in the `migration:path` builds. We
need to find a better way of testing this provider.
|
|
- Don't use `request.env['omniauth.params']` if it isn't present.
- Remove the `saml` section from the `gitlab.yml` test section. Some tests
depend on this section not being initially present, so it can be overridden
in the test. This MR doesn't add any tests for SAML, so we didn't really need
this in the first place anyway.
- Clean up the test -> omniauth section of `gitlab.yml`
|
|
- I tried to get this to work by stubbing out portions of the config within the
test. This didn't work as expected because Devise/Omniauth loaded before the
stub could run, and the stubbed config was ignored.
- I attempted to fix this by reloading Devise/Omniauth after stubbing the
config. This successfully got Devise to load the stubbed providers, but failed
while trying to access a route such as `user_gitlab_omniauth_authorize_path`.
- I spent a while trying to figure this out (even trying
`Rails.application.reload_routes!`), but nothing seemed to work.
- I settled for adding this config directly to `gitlab.yml` rather than go down
this path any further.
|
|
Create and use project path helpers that only need a project, no namespace
See merge request !12566
|
|
|
|
This reverts merge request !11963
|
|
Closes #34278
|
|
Honor the "Remember me" parameter for OAuth-based login
Closes #18000
See merge request !11963
|
|
|
|
+ fix wrong test setup
|
|
|
|
as deprecated
|
|
in favor of whitelist that will be used to
control the access to monitoring resources
|
|
|
|
|
|
|
