gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2019-04-16	Refer to guidelines on when to assign MRs close to the freeze	Douwe Maan

2019-04-16	Rewrite "Review turnaround time" section	Douwe Maan

2019-03-25	Add ssot link to security reviews documentation	James Ritchey

2019-02-21	Apply suggestion to doc/development/code_review.md	Marcia Ramos

2019-02-21	Update code review guidelines	Marcia Ramos

2019-02-18	Merge branch 'docs/zj-reviewer-guidelines' into 'master'	Nick Thomas
	Add a soft SLA for reviewers and maintainers See merge request gitlab-org/gitlab-ce!25192
2019-02-18	Improve language	Zeger-Jan van de Weg

2019-02-13	Reviewer roulette via Danger	Nick Thomas
	Make danger pick reviewers and maintainers at random, for feontend, backend, database, etc, changes, whenever files belonging to those teams get changed.
2019-02-13	Add a soft SLA for reviewers and maintainers	Zeger-Jan van de Weg
	By setting expectations both the contributor and reviewer have more certainty on what gets reviewed when, and at what speed changes could be merged.
2018-12-11	Fix links to sections that were moved	Michael Kozono

2018-11-30	Fix Red/Orange data link markdown	Philippe Lafoucrière

2018-11-29	Merge branch ↵	Rémy Coutable
	'docs/8608-update-approval-guidelines-to-include-red-orange-data-reviews' into 'master' Add RED data security requirement to code review See merge request gitlab-org/gitlab-ce!23426
2018-11-29	Merge branch 'mk/author-preparation-docs' into 'master'	Marcia Ramos
	Encourage MR author preparation in Code Review Guidelines documentation See merge request gitlab-org/gitlab-ce!23360
2018-11-28	Add RED data security requirement to code review	Philippe Lafoucrière
	closes #8608
2018-11-28	Encourage MR author preparation	Michael Kozono

2018-11-28	Left shift security in our workflow	Philippe Lafoucrière

2018-11-27	Clearer docs when it is OK for maintainer to squash	Dylan Griffith

2018-11-13	Resolve Markdown ordered lists not conforming to styleguide	Evan Read

2018-11-06	Includes the way approvals are handled to the documentation	Dimitrie Hoekstra

2018-10-17	Strongly recommend involving a domain expert, especially when in doubt.	Douwe Maan

2018-10-17	Merge branch 'master' into 'dm-document-role-maintainer'	Douwe Maan
	# Conflicts: # doc/development/code_review.md
2018-10-17	Clarify responsibilities of MR author and maintainer based on feedback.	Douwe Maan

2018-10-16	Fix "ready for review" link	Jan Provaznik
	Remove assignee_id=0 condition from search filters, we agreed that just presence of "ready of review" label is sufficient for filtering MRs, no need to unassign yourself.
2018-10-15	Add documentation how to assign a merge request for review	Jarka Kadlecová

2018-10-10	Rewrite guidance on getting your merge request reviewed, approved, and merged	Douwe Maan

2018-10-09	Document the role of the maintainer	Douwe Maan

2018-09-12	Update code_review.md to include a recommendation for assigning maintainers ↵	Luke Bennett
	from different teams Improve recommended maintainer docs
2018-09-06	Resolve "CE documentation is not CommonMark compliant"	Brett Walker

2018-05-30	Fixed broken link to build team in documentation	Eddie Stubbington

2018-05-11	Add Code Review documentation that maintainers also perform code review	Robert Speicher

2018-05-11	Move footnote from CONTRIBUTING.md to doc/development/code_review.md	Robert Speicher
	A section was moved in f644b8c8 but this got lost.
2017-08-01	Merge branch 'master' into 'docs-specific-review-examples'	Clement Ho
	# Conflicts: # doc/development/code_review.md
2017-08-01	Add code review guidelines related to Build [CI skip].	Marin Jankovski

2017-07-31	Add note about UX paradigm	Clement Ho

2017-07-31	Add specific code review guidelines	Clement Ho

2017-07-24	Add GitLab-specific concerns to code review guide	Sean McGivern

2017-05-09	Fix links in code review docs	Sean McGivern

2017-05-04	Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md	Rémy Coutable
	Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-03	Improve the Code review guidelines documentation	Rémy Coutable
	Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-02-15	Rename builds to jobs in docs	Achilleas Pipinellis
	[ci skip]
2017-01-13	Rename endboss -> maintainer, miniboss -> reviewer	Sean McGivern
	We want to describe these roles in a way that is more understandable to people not familiar with GitLab.
2016-12-05	Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master'	Kamil Trzciński
	Rename MWBS service to Merge When Pipeline Succeeds ## What does this MR do? This MR renames Merge When Build Succeeds feature to Merge When Pipeline Succeeds, because we recently changed the behavior, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6675. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] All builds are passing ## What are the relevant issue numbers? Closes #23354 See merge request !7135
2016-12-02	Remove change to MWBS in code review guideline	Grzegorz Bizon
	[ci skip]
2016-12-01	Copy-edit text about right balance in code reviews	Grzegorz Bizon
	[ci skip]
2016-11-30	Extend code review docs with chapter about the right balance	Grzegorz Bizon

2016-11-21	Update some docs to reflect MWPS name change	Grzegorz Bizon

2016-10-07	Fix typo and add he MWBS accronym for "Merge When Build Succeeds"	Rémy Coutable
	Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-07	Improve the contribution and MR review guide	Rémy Coutable
	Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-04-11	Re-add a note about sarcasm to the Code Review guide	Robert Speicher
	[ci skip]
2016-04-10	First pass at a Code Review guide	Robert Speicher
	Largely borrowed from thoughtbot's code review guide, so attribution is included. [ci skip]