Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-09-10 | Fix broken link to the handbook | David H. Wilkins | |
- Broken link to "How to work with the distribution team" | |||
2019-09-04 | What to avoid in code review | Marin Jankovski | |
2019-09-03 | Add Danger bot development documentation | Nick Thomas | |
This is overdue, and some of the suggestions are embarrassing, but this is how we actually develop Danger today. | |||
2019-07-25 | Add a section of examples | Kerri Miller | |
We have a fairly good guide to Code Reviews, but can be improved by adding a few examples of what a good code review looks like at GitLab, specifically ones where there is a bit of back and forth, "nit-picking," etc. This would: + help set expectations of newly hired engineers around what our process looks like when it is functioning what level of scrutiny their code will be under + how we have technical conversations + show by example how after you're done crafting a solution, there can still be extra work done either tidying up code and/or managing the communication and conversations about your proposed MR | |||
2019-07-19 | Document database review process | Toon Claes | |
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069 | |||
2019-07-19 | Update numbered lists for docs standards | Marcel Amirault | |
Ensure that all numbered lists use only 1. and no other numbers. Also ensure that numbered lists use proper spacing. | |||
2019-07-18 | Fix unordered list spacing | Marcel Amirault | |
Correct the spacing of unordered markdown lists in docs, to maintain standards of documentation. | |||
2019-07-15 | Rename "discussions" to "threads" in docs | Michel Engelen | |
2019-07-09 | Update the installation link | Cindy Pallares | |
The installation link has changed from /installation/ to /install/. This commit will update all the remaining links that are missing. | |||
2019-06-24 | Require database reviews for migrations | Andreas Brandl | |
2019-05-27 | Use relative URLs in development docs | Achilleas Pipinellis | |
This is part of https://gitlab.com/gitlab-org/gitlab-ce/issues/61945 | |||
2019-04-30 | Give reviewer roulette its own header in the docs | Sean McGivern | |
2019-04-16 | Refer to guidelines on when to assign MRs close to the freeze | Douwe Maan | |
2019-04-16 | Rewrite "Review turnaround time" section | Douwe Maan | |
2019-03-25 | Add ssot link to security reviews documentation | James Ritchey | |
2019-02-21 | Apply suggestion to doc/development/code_review.md | Marcia Ramos | |
2019-02-21 | Update code review guidelines | Marcia Ramos | |
2019-02-18 | Merge branch 'docs/zj-reviewer-guidelines' into 'master' | Nick Thomas | |
Add a soft SLA for reviewers and maintainers See merge request gitlab-org/gitlab-ce!25192 | |||
2019-02-18 | Improve language | Zeger-Jan van de Weg | |
2019-02-13 | Reviewer roulette via Danger | Nick Thomas | |
Make danger pick reviewers and maintainers at random, for feontend, backend, database, etc, changes, whenever files belonging to those teams get changed. | |||
2019-02-13 | Add a soft SLA for reviewers and maintainers | Zeger-Jan van de Weg | |
By setting expectations both the contributor and reviewer have more certainty on what gets reviewed when, and at what speed changes could be merged. | |||
2018-12-11 | Fix links to sections that were moved | Michael Kozono | |
2018-11-30 | Fix Red/Orange data link markdown | Philippe Lafoucrière | |
2018-11-29 | Merge branch ↵ | Rémy Coutable | |
'docs/8608-update-approval-guidelines-to-include-red-orange-data-reviews' into 'master' Add RED data security requirement to code review See merge request gitlab-org/gitlab-ce!23426 | |||
2018-11-29 | Merge branch 'mk/author-preparation-docs' into 'master' | Marcia Ramos | |
Encourage MR author preparation in Code Review Guidelines documentation See merge request gitlab-org/gitlab-ce!23360 | |||
2018-11-28 | Add RED data security requirement to code review | Philippe Lafoucrière | |
closes #8608 | |||
2018-11-28 | Encourage MR author preparation | Michael Kozono | |
2018-11-28 | Left shift security in our workflow | Philippe Lafoucrière | |
2018-11-27 | Clearer docs when it is OK for maintainer to squash | Dylan Griffith | |
2018-11-13 | Resolve Markdown ordered lists not conforming to styleguide | Evan Read | |
2018-11-06 | Includes the way approvals are handled to the documentation | Dimitrie Hoekstra | |
2018-10-17 | Strongly recommend involving a domain expert, especially when in doubt. | Douwe Maan | |
2018-10-17 | Merge branch 'master' into 'dm-document-role-maintainer' | Douwe Maan | |
# Conflicts: # doc/development/code_review.md | |||
2018-10-17 | Clarify responsibilities of MR author and maintainer based on feedback. | Douwe Maan | |
2018-10-16 | Fix "ready for review" link | Jan Provaznik | |
Remove assignee_id=0 condition from search filters, we agreed that just presence of "ready of review" label is sufficient for filtering MRs, no need to unassign yourself. | |||
2018-10-15 | Add documentation how to assign a merge request for review | Jarka Kadlecová | |
2018-10-10 | Rewrite guidance on getting your merge request reviewed, approved, and merged | Douwe Maan | |
2018-10-09 | Document the role of the maintainer | Douwe Maan | |
2018-09-12 | Update code_review.md to include a recommendation for assigning maintainers ↵ | Luke Bennett | |
from different teams Improve recommended maintainer docs | |||
2018-09-06 | Resolve "CE documentation is not CommonMark compliant" | Brett Walker | |
2018-05-30 | Fixed broken link to build team in documentation | Eddie Stubbington | |
2018-05-11 | Add Code Review documentation that maintainers also perform code review | Robert Speicher | |
2018-05-11 | Move footnote from CONTRIBUTING.md to doc/development/code_review.md | Robert Speicher | |
A section was moved in f644b8c8 but this got lost. | |||
2017-08-01 | Merge branch 'master' into 'docs-specific-review-examples' | Clement Ho | |
# Conflicts: # doc/development/code_review.md | |||
2017-08-01 | Add code review guidelines related to Build [CI skip]. | Marin Jankovski | |
2017-07-31 | Add note about UX paradigm | Clement Ho | |
2017-07-31 | Add specific code review guidelines | Clement Ho | |
2017-07-24 | Add GitLab-specific concerns to code review guide | Sean McGivern | |
2017-05-09 | Fix links in code review docs | Sean McGivern | |
2017-05-04 | Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md | Rémy Coutable | |
Signed-off-by: Rémy Coutable <remy@rymai.me> |