| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Documentation about unicorn settings.
Helps with https://news.ycombinator.com/item?id=9213180
See merge request !1704
|
|
|
|
|
|
|
|
Update monthly doc to mention wip blogpost for next release.
See merge request !1697
|
|
Restricted visibility levels - bug fix and new feature
This allows admin users to override restricted visibility settings when creating and updating projects and snippets, and moves the restricted visibility configuration from gitlab.yml to the web UI. See #1903.
## Move configuration location
I added a new section to the application settings page for restricted visibility levels. Each level has a checkbox, styled with Bootstrap to look like a toggle button. A checked box means that the level is restricted. I added a glowing text shadow and changed the background color for checked buttons because the default styles made it hard to distinguish between checked and unchecked. This image shows the new section with the "Public" box checked:
## Allow admins to override
To allow admin users to override the restricted visibility levels, I had to remove the `visibility_level` validation from the `Project` class. The model doesn't know about the `current_user`, which should determine whether the restrictions can be overridden. We could use the creator in the validation, but that wouldn't work correctly for projects where a non-admin user is the creator and an admin tries to change the project to a restricted visibility level.
The `Project::UpdateService` and `Project::CreateService` classes already had code to determine whether the current user is allowed to use a given visibility level; now all visibility level validation is done in those classes. Currently, when a non-admin tries to create or update a project using a restricted level, these classes silently set the visibility level to the global default (create) or the project's existing value (update). I changed this behavior to be more like an Active Model validation, where using a restricted level causes the entire request to be rejected.
Project and personal snippets didn't have service classes, and restricted visibility levels weren't being enforced in the model or the controllers. The UI disabled radio buttons for restricted levels, but that wouldn't be difficult to circumvent. I created the `CreateSnippetService` and `UpdateSnippetService` classes to do the same restricted visibility check that the project classes do. And since I was dealing with snippet visibility levels, I updated the API endpoints for project snippets to allow users to set and update the visibility level.
## TODO
* [x] Add more tests for restricted visibility functionality
cc @sytse @dzaporozhets
See merge request !1655
|
|
|
|
|
|
Conflicts:
db/schema.rb
|
|
|
|
|
|
|
|
Enhance Markdown linebreak docs
The "Line Breaks" section within the Markdown docs was missing an example of creating a line break within a paragraph by ending a line with two spaces.
See merge request !335
|
|
Emoji cheatsheet fix
Worked through the help text for emoji to properly reference and use EmojiOne tags. Removed the ninja and reworked the first sentence a bit, as ninja isn't supported by EmojiOne. Should resolve ticket #953.
See merge request !384
|
|
|
|
|
|
|
|
|
|
|
|
GitLab, and Google.
|
|
Allow admins to use restricted visibility levels when creating or
updating projects.
|
|
|
|
Web Hook sends email of pusher
See merge request !1630
|
|
|
|
|
|
else. It is now linked.
|
|
Clearly mark it as installation from source.
See merge request !1622
|
|
|
|
|
|
Aorimn-add-irker-service
Conflicts:
app/controllers/projects/services_controller.rb
|
|
|
|
More reasons why prefixing is good
Inspired by http://www.dwheeler.com/essays/filenames-in-shell.html
See merge request !1604
|
|
Irker is a gateway which sends IRC messages on git updates. This new
service provides an interface to this gateway, integrated in Gitlab, for
each updates.
As per the guidelines, this commit adds the new feature in the
CHANGELOG, tests and documentation.
See http://www.catb.org/esr/irker/
|
|
Error in docs for closing an issue
API docs for issues says you set parameter 'closed' to '1'. I was not able to do that but I could set 'state_event' to 'close' which closed the issue.
Does not work
"https://gitlab.com/api/v3/projects/:id/issues/:issue_id?closed=1"
Does work
"https://gitlab.com/api/v3/projects/:id/issues/:issue_id?state_event=close"
See merge request !342
|
|
Expose avatar_url in projects API
|
|
* Impl Project#avatar_url
* Refactor ApplicationHelper: Use Project#avatar_url
* Update changelog
|
|
formatting cleanup on mysql_to_postgresql.md
|
|
use gitlab branch of mysql-postgresql-converter
|
|
Correct json payload [ci skip]
|
|
Mention audit events ee feature in logs documentation.
Related to gitlab/gitlabhq#1979
See merge request !1609
|
|
Add 'confirm' option to users api
For #1990
Based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/129
See merge request !1610
|
|
Conflicts:
lib/api/users.rb
|
|
|
|
patch release documentation.
|
|
Inspired by http://www.dwheeler.com/essays/filenames-in-shell.html
|
|
Conflicts:
app/views/import/gitorious/status.html.haml
db/schema.rb
|
|
|
|
Web Editor: save to new branch
Implements #1931
See merge request !1523
|
